Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/66d75440143d22782a75684f5aee60aca124a076
commit
66d75440143d22782a75684f5aee60aca124a076
[log]
author
Keita Suzuki <suzukikeita@chromium.org>
Wed May 01 01:37:17 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed May 01 05:14:43 2024
tree
70473c91a8a9fa4ea6cf07bdf3d86c2c89915e40
parent
d9882851278e670464a461cbf50e68fe8954b1ef [diff]
[ServiceWorker] Check optinal for ServiceWorkerRouterInfo.ruleIdMached

This CL adds check if `SerivceWorkerRouterInfo.ruleIdMatched` is optional
or not. In https://crrev.com/c/5481450, the field has been modifed to be
an optional number. To support this, we check if the field is optional
or not before accessing the field. If the field is optional, we pass on
0 which indicates an invalid rule ID.

Bug: 335524390
Change-Id: I053d32d9fed46d2bd37d81c8164d80a0e843385a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5504629
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
1 file changed
tree: 70473c91a8a9fa4ea6cf07bdf3d86c2c89915e40
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch