Google Git
Sign in
chromium / devtools / devtools-frontend / bf132c052eebd268de51be2bb346febcff4bf490
commitbf132c052eebd268de51be2bb346febcff4bf490[log] [tgz]
authorJack Franklin <jacktfranklin@chromium.org>Wed May 01 08:35:14 2024
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 01 09:00:31 2024
tree9e72da9b61e5410c971e95ff829206f9cfb61fe6
parent54f63864043c10cb07c7598d77fde3a3f4e43d7c [diff]
RPP: stop selector stats scrolling to the bottom

This CL fixes two issues (one user facing) with the selector stats
implementation:

1. As the user panned/zoomed around the timeline and the data changed,
   the data-grid would detect new data and scroll it to the bottom. This
   is not useful in this context, so this CL adds a flag to allow that
   behaviour to be turned off.

2. The selector stats table was being re-generated all the time, even if
   the set of visible UpdateLayoutTree events that backed it remained
   the same. This CL adds a check to compare the last set of events with
   the current, and bails without doing anything if they are the same.
   This severely reduces the amount of re-renders of the data grid we
   are doing.

Fixed: 337999939
Change-Id: I2f4ebf3fa887bbc306cdc89e371c5a94b9b30e12
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5501380
Reviewed-by: Paul Irish <paulirish@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
3 files changed
tree: 9e72da9b61e5410c971e95ff829206f9cfb61fe6
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch