ExtensionTraceDataHandler ignores non-obj perf marks This code accidentally relied on the details being something that is `JSON.parse`d as an object, so we can then use the 'in' operator to search for it. The fix in this context is to wrap the code in a try catch and return null if it errors - which means either the details data was not valid JSON, or it wasn't of the structure we need for the sake of extensions. Both of these are OK and we just need the extension code to ignore the event in that case. Fixed: 341254293 Change-Id: Ic81c006d039b9a240e2c8d7ce8d37d0985fe022b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5548337 Reviewed-by: Victor Porof <victorporof@chromium.org> Commit-Queue: Victor Porof <victorporof@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.
The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.
DevTools frontend repository is mirrored on GitHub.
DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.
The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.
All DevTools commits: View the log or follow @DevToolsCommits on Twitter
All open DevTools tickets on crbug.com
File a new DevTools ticket: new.crbug.com
Code reviews mailing list: devtools-reviews@chromium.org
@ChromeDevTools on Twitter
Chrome DevTools mailing list: groups.google.com/forum/google-chrome-developer-tools