Google Git
Sign in
chromium / devtools / devtools-frontend / ccfb914765146ce514b9645117d9f95052bd3471
commitccfb914765146ce514b9645117d9f95052bd3471[log] [tgz]
authorErgün Erdoğmuş <ergunsh@chromium.org>Mon Sep 26 14:17:20 2022
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Sep 27 08:13:41 2022
treeb148254f3ea8e76addb6310acf5f637d158de9eb
parentd3caf2b631f05bf0403753b9a155bcb02f15102e [diff]
Autocomplete CSS property name on pressing space

Currently, adding space in property names
gives us an undefined behavior and can be
a cause of funny bugs (See Fixed)

This CL changes the behavior of CSSPropertyPrompt
to accept autocomplete suggestion on space
press just like tab press.

The reason of the bug was, `TextPrompt`
has space as the stopping character. Thus,
when it was providing autocompletions for
`a 1` it was only providing auto completions
for value `1` and replacing `a 1` with
`a font-weight: 100` which in turn
adds style `a\nfont-weight: 100` to
the stylesheet which causes an unwanted
behavior described in the bug

Fixed: 1343316
Change-Id: I16f260dcb32f65859783bd4b72e3cd3b7b0f267a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3918390
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2 files changed
tree: b148254f3ea8e76addb6310acf5f637d158de9eb
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch