Add VE context to Issues panel tree elements. This change adds a unique jslogContext to various TreeElement instances within the Issues panel, including hidden issues, issue kinds, individual issues, and issue categories. Bug: none Change-Id: I421c5d38e851e366124f5a6d06651219713a5f85 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7637752 Commit-Queue: Danil Somsikov <dsv@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Danil Somsikov <dsv@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
diff --git a/front_end/panels/issues/HiddenIssuesRow.ts b/front_end/panels/issues/HiddenIssuesRow.ts index 44ffebf..0ee968c 100644 --- a/front_end/panels/issues/HiddenIssuesRow.ts +++ b/front_end/panels/issues/HiddenIssuesRow.ts
@@ -66,7 +66,7 @@ #view: View; constructor(view: View = DEFAULT_VIEW) { - super(undefined, true); + super(undefined, true, 'hidden-issues'); this.#view = view; this.toggleOnClick = true; this.listItemElement.classList.add('issue-category', 'hidden-issues');
diff --git a/front_end/panels/issues/IssueKindView.ts b/front_end/panels/issues/IssueKindView.ts index a328b1d..9ba0218 100644 --- a/front_end/panels/issues/IssueKindView.ts +++ b/front_end/panels/issues/IssueKindView.ts
@@ -5,6 +5,7 @@ import * as Common from '../../core/common/common.js'; import * as i18n from '../../core/i18n/i18n.js'; +import * as Platform from '../../core/platform/platform.js'; import * as IssuesManager from '../../models/issues_manager/issues_manager.js'; import * as Adorners from '../../ui/components/adorners/adorners.js'; import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js'; @@ -64,7 +65,7 @@ #issueCount: HTMLElement; constructor(kind: IssuesManager.Issue.IssueKind) { - super(undefined, true); + super(undefined, true, Platform.StringUtilities.toKebabCase(kind)); this.#kind = kind; this.#issueCount = document.createElement('span');
diff --git a/front_end/panels/issues/IssueView.ts b/front_end/panels/issues/IssueView.ts index 081cebd..1a9a506 100644 --- a/front_end/panels/issues/IssueView.ts +++ b/front_end/panels/issues/IssueView.ts
@@ -6,7 +6,7 @@ import * as Common from '../../core/common/common.js'; import * as Host from '../../core/host/host.js'; import * as i18n from '../../core/i18n/i18n.js'; -import type * as Platform from '../../core/platform/platform.js'; +import * as Platform from '../../core/platform/platform.js'; import * as Protocol from '../../generated/protocol.js'; import type {AggregatedIssue} from '../../models/issues_manager/IssueAggregator.js'; import * as IssuesManager from '../../models/issues_manager/issues_manager.js'; @@ -230,7 +230,7 @@ #contentCreated = false; constructor(issue: AggregatedIssue, description: IssuesManager.MarkdownIssueDescription.IssueDescription) { - super(); + super(undefined, undefined, Platform.StringUtilities.toKebabCase(issue.getCategory())); this.#issue = issue; this.#description = description; this.#throttle = new Common.Throttler.Throttler(250);
diff --git a/front_end/panels/issues/IssuesPane.ts b/front_end/panels/issues/IssuesPane.ts index a578c59..cab30b9 100644 --- a/front_end/panels/issues/IssuesPane.ts +++ b/front_end/panels/issues/IssuesPane.ts
@@ -7,7 +7,7 @@ import * as Common from '../../core/common/common.js'; import * as i18n from '../../core/i18n/i18n.js'; -import type * as Platform from '../../core/platform/platform.js'; +import * as Platform from '../../core/platform/platform.js'; import * as IssuesManager from '../../models/issues_manager/issues_manager.js'; import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js'; import * as UI from '../../ui/legacy/legacy.js'; @@ -121,7 +121,7 @@ #category: IssuesManager.Issue.IssueCategory; constructor(category: IssuesManager.Issue.IssueCategory) { - super(); + super(undefined, undefined, Platform.StringUtilities.toKebabCase(category)); this.#category = category; this.toggleOnClick = true;
diff --git a/front_end/ui/visual_logging/KnownContextValues.ts b/front_end/ui/visual_logging/KnownContextValues.ts index e1c0e97..bcae65d 100644 --- a/front_end/ui/visual_logging/KnownContextValues.ts +++ b/front_end/ui/visual_logging/KnownContextValues.ts
@@ -492,6 +492,7 @@ 'attribute', 'attribute-modified', 'attributes', + 'attribution-reporting', 'attribution-reporting-details', 'auction-worklet', 'audio-context', @@ -679,6 +680,7 @@ 'break-before', 'break-inside', 'break-on', + 'breaking-change', 'breakpoint', 'breakpoint-group', 'breakpoint-tooltip', @@ -928,6 +930,7 @@ 'content-encoding', 'content-length', 'content-policy', + 'content-security-policy', 'content-type', 'content-visibility', 'context', @@ -963,6 +966,7 @@ 'converter-puppeteer', 'converter-puppeteer-firefox', 'converter-puppeteer-replay', + 'cookie', 'cookie-control-override-enabled', 'cookie-flag-controls', 'cookie-preview', @@ -1054,6 +1058,7 @@ 'corner-top-right-shape', 'corner-top-shape', 'corners', + 'cors', 'cors-details', 'count', 'count-delta', @@ -1087,6 +1092,7 @@ 'credential-id', 'credentialId', 'critical', + 'cross-origin-embedder-policy', 'cs', 'css', 'css-angle', @@ -1777,6 +1783,7 @@ 'gen-ai-settings-panel', 'general', 'generative-ai-terms-of-service', + 'generic', 'generic-details', 'geolocation', 'geolocation.get-current-position', @@ -1863,6 +1870,7 @@ 'heap-snapshot.retaining-paths-view', 'heap-tracking-overview', 'heavy', + 'heavy-ad', 'heavy-ad-details', 'height', 'help', @@ -1875,6 +1883,7 @@ 'heuristic-mitigation-disabled', 'hex', 'hi', + 'hidden-issues', 'hide-all-others', 'hide-children', 'hide-data-urls', @@ -1933,6 +1942,7 @@ 'import-har', 'import-recording', 'important', + 'improvement', 'in-range', 'increase-priority', 'indeterminate', @@ -2504,6 +2514,7 @@ 'lostpointercapture', 'low-contrast-details', 'low-end-mobile', + 'low-text-contrast', 'lt', 'lv', 'macos', @@ -2631,6 +2642,7 @@ 'min-width', 'missing-debug-info', 'mix-blend-mode', + 'mixed-content', 'mixed-content-details', 'mk', 'ml', @@ -2898,6 +2910,7 @@ 'page-break-after', 'page-break-before', 'page-break-inside', + 'page-error', 'page-margin-safety', 'page-orientation', 'paint-order', @@ -2946,6 +2959,7 @@ 'performance.sidebar-toggle', 'periodic-background-sync', 'periodic-sync-tag', + 'permission-element', 'permission-element-elements', 'persist-flame-config', 'persistence-automatic-workspace-folders', @@ -3089,6 +3103,7 @@ 'quick-open.show', 'quick-open.show-command-menu', 'quickOpen.show', + 'quirks-mode', 'quota-override', 'quotes', 'r',