Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/efd41183e091a05cca36c2b9ce7581af814c87dc
commit
efd41183e091a05cca36c2b9ce7581af814c87dc
[log]
author
Ergun Erdogmus <ergunsh@chromium.org>
Thu Nov 16 11:44:21 2023
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Nov 17 12:17:16 2023
tree
58cf2f2eb40d3f04981ed69e29196aea3d61bb12
parent
d13f23b6b05b66be191294a0be6832b1d5f66a3a [diff]
[CSSStyleDeclaration] Remove parseUnusedText logic

It is introduced in crrev.com/c/1089295 and is served well to us
until now, with the nesting introduced.

Its custom logic for trying to figure out which properties
might the user intended to write is getting more and more complex with
the addition of new CSS features (nesting again...).

So, this is getting a risky logic that would break Styles pane
in some situations.

The UX win it provides (crbug.com/813435) does not justify
our maintenance costs and the risk it introduces to the reliability.

So, it's time we say goodbye to our fellow logic.

Fixed: 1473339
Change-Id: Ieaf87f7f9dbcc02d835ec042628a75ec0e13de15
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5033671
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>
2 files changed
tree: 58cf2f2eb40d3f04981ed69e29196aea3d61bb12
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch