| 2012-10-03 Benjamin Poulain <bpoulain@apple.com> |
| |
| Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation |
| https://bugs.webkit.org/show_bug.cgi?id=97608 |
| |
| Reviewed by Sam Weinig. |
| |
| The test fast/dom/Geolocation/window-close-crash.html was crashing because |
| handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how |
| the page was created, the void* clientInfo can either be a PlatformWebView or |
| a TestController. |
| |
| Using the global TestController fixes the issue. |
| |
| * WebKitTestRunner/GeolocationProviderMock.cpp: |
| (WTR::GeolocationProviderMock::setPosition): |
| (WTR::GeolocationProviderMock::setPositionUnavailableError): |
| To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position |
| to clear the error and vice versa. |
| This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1. |
| |
| (WTR::GeolocationProviderMock::sendPositionIfNeeded): |
| (WTR::GeolocationProviderMock::sendErrorIfNeeded): |
| Some tests expect the position/error cant be sent multiple time, |
| just keep the position after sending. |
| |
| * WebKitTestRunner/TestController.cpp: |
| (WTR::decidePolicyForGeolocationPermissionRequest): |
| (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible): |
| * WebKitTestRunner/TestController.h: |
| Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real |
| client would have to do. |
| |
| 2012-10-03 Otto Derek Cheung <otcheung@rim.com> |
| |
| [BlackBerry] Implementing the NetworkInfo API for BB port |
| https://bugs.webkit.org/show_bug.cgi?id=98273 |
| |
| Reviewed by Rob Buis. |
| |
| Enabling NetworkInfo API for the BlackBerry port. |
| |
| * Scripts/webkitperl/FeatureList.pm: |
| |
| 2012-10-03 Anders Carlsson <andersca@apple.com> |
| |
| Exception thrown when running accessibility/container-node-delete-causes-crash.html test |
| https://bugs.webkit.org/show_bug.cgi?id=98291 |
| |
| Reviewed by Andreas Kling. |
| |
| The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree |
| to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown |
| when trying to access the children of an element that didn't have any children. Fix this by adding |
| BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children. |
| |
| * DumpRenderTree/mac/AccessibilityControllerMac.mm: |
| (findAccessibleObjectById): |
| |
| 2012-10-03 Ojan Vafai <ojan@chromium.org> |
| |
| Make partytime work when loading garden-o-matic from trac.webkit.org |
| https://bugs.webkit.org/show_bug.cgi?id=98283 |
| |
| Reviewed by Adam Barth. |
| |
| CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive. |
| * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: |
| |
| 2012-10-03 Roger Fong <roger_fong@apple.com> |
| |
| Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform. |
| https://bugs.webkit.org/show_bug.cgi?id=98288 |
| |
| * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: |
| (ChromiumAndroidDriverTest.test_command_from_driver_input): |
| |
| 2012-10-03 Ojan Vafai <ojan@chromium.org> |
| |
| Get rid of warning about non-existant platform name when loading garden-o-matic |
| https://bugs.webkit.org/show_bug.cgi?id=98282 |
| |
| Reviewed by Adam Barth. |
| |
| If you loaded without a platform query parameter we'd return "null" as the platform name |
| instead of null. |
| * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: |
| * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: |
| |
| 2012-10-03 Balazs Kelemen <kbalazs@webkit.org> |
| |
| [Qt] Enable mock scrollbars |
| https://bugs.webkit.org/show_bug.cgi?id=98011 |
| |
| Reviewed by Csaba Osztrogonác. |
| |
| Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline. |
| |
| * DumpRenderTree/qt/DumpRenderTreeQt.cpp: |
| (WebCore::DumpRenderTree::DumpRenderTree): |
| * WebKitTestRunner/TestController.cpp: |
| (WTR::TestController::resetStateToConsistentValues): |
| |
| 2012-10-03 Alberto Garcia <agarcia@igalia.com> |
| |
| [GTK] [WK2] Add favicon support to the MiniBrowser |
| https://bugs.webkit.org/show_bug.cgi?id=98063 |
| |
| Reviewed by Carlos Garcia Campos. |
| |
| Set the icon in the URI text entry using the favicon property of |
| the WebKitWebView. |
| |
| * MiniBrowser/gtk/BrowserWindow.c: |
| (_BrowserWindow): |
| (updateUriEntryIcon): |
| (uriEntryTextChanged): |
| (faviconChanged): |
| (browserWindowFinalize): |
| (browser_window_init): |
| (browserWindowConstructed): |
| |
| 2012-10-03 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> |
| |
| [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference. |
| https://bugs.webkit.org/show_bug.cgi?id=98200 |
| |
| Reviewed by Csaba Osztrogonác. |
| |
| * DumpRenderTree/qt/TestRunnerQt.cpp: |
| (TestRunner::overridePreference): |
| |
| 2012-10-03 Zoltan Arvai <zarvai@inf.u-szeged.hu> |
| |
| [Qt][WRT] Fix build error with MSVC on Windows. |
| https://bugs.webkit.org/show_bug.cgi?id=97697 |
| |
| Reviewed by Simon Hausmann. |
| |
| WTR build is failing when WebKit directory is located on a longer path. |
| This seems to caused by source files that has the same name in |
| WTR and DRT directories. The solution is removing referencies |
| from Target.pri to DRT directory and adding an alternate version of |
| the required files to WTR. Those files simply include the real ones from DRT. |
| |
| * WebKitTestRunner/InjectedBundle/Target.pri: |
| * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added. |
| * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added. |
| |
| 2012-10-03 Christophe Dumez <christophe.dumez@intel.com> |
| |
| [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness |
| https://bugs.webkit.org/show_bug.cgi?id=98238 |
| |
| Reviewed by Csaba Osztrogonác. |
| |
| Reset AlwaysAcceptCookies setting between tests to avoid |
| flakiness due to TestRunner.setAlwaysAcceptCookies(). |
| |
| * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: |
| (WTR::InjectedBundle::beginTesting): |
| |
| 2012-10-03 Harald Alvestrand <hta@google.com> |
| |
| Add data passing to the GetStats interface of RTCPeerConnection |
| https://bugs.webkit.org/show_bug.cgi?id=98003 |
| |
| Reviewed by Adam Barth. |
| |
| * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: |
| (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask): |
| (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler): |
| (MockWebRTCPeerConnectionHandler::addStream): |
| (MockWebRTCPeerConnectionHandler::removeStream): |
| (MockWebRTCPeerConnectionHandler::getStats): |
| * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: |
| (MockWebRTCPeerConnectionHandler): |
| |
| == Rolled over to ChangeLog-2012-10-02 == |
