Google Git
Sign in
chromium / external / Webkit / 670cbed4eac3c6446c657054cefa8f811a602e9a / . / Tools / ChangeLog
blob: f749f84120d830e72d16ac4cfcfcd2d84b2c0e99 [file] [log] [blame]
2013-05-15 Brent Fulgham <bfulgham@apple.com>
[Windows] Update various build tools to understand VS2010 environment.
https://bugs.webkit.org/show_bug.cgi?id=116169.
Reviewed by Anders Carlsson.
* Scripts/build-api-tests: Identify VS2010 environment.
* Scripts/build-dumprendertree: Ditto.
* Scripts/build-webkit: Ditto.
* Scripts/webkitdirs.pm:
(dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
range of acceptable SDK's.
2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu>
Allow http tests on Arch Linux
https://bugs.webkit.org/show_bug.cgi?id=116155
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/port/base.py:
(Port._is_arch_based): Added check for /etc/arch-release file.
(Port._apache_config_file_name_for_platform): Call the check.
* Scripts/webkitpy/port/port_testcase.py:
(test_linux_distro_detection): Testcase added.
2013-05-15 Peter Gal <galpeter@inf.u-szeged.hu>
Remove a leftover v8 file from the watchlist
https://bugs.webkit.org/show_bug.cgi?id=116158
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2013-05-15 Alberto Garcia <agarcia@igalia.com>
[GTK] Fails to build while generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=115612
Reviewed by Philippe Normand.
Fix typo in the prerequisites of docs-build.stamp.
* GNUmakefile.am:
2013-05-15 Zan Dobersek <zdobersek@igalia.com>
Unreviewed, fixing the current test-webkitpy failure.
* Scripts/webkitpy/port/mac_unittest.py:
(test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2013-05-14 Jaehun Lim <ljaehun.lim@samsung.com>
Fix build after r150090.
https://bugs.webkit.org/show_bug.cgi?id=116129
Unreviewed build fix after r150090.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2013-05-14 Brent Fulgham <bfulgham@apple.com>
[Windows, others] Unreviewed build fix after r150090.
* DumpRenderTree/TestRunner.cpp:
(getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
doesn't exist on other platforms.
2013-05-14 Brent Fulgham <bfulgham@webkit.org>
[Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
https://bugs.webkit.org/show_bug.cgi?id=115889
Reviewed by Benjamin Poulain.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
* DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2013-05-14 Brent Fulgham <bfulgham@apple.com>
[Windows] Identify proper run environment for scripts.
https://bugs.webkit.org/show_bug.cgi?id=116114
Reviewed by David Kilzer.
Determine (based on Visual Studio version) which path to use for
executables (bin versus bin32).
* Scripts/webkitdirs.pm:
(determineVisualStudioInstallDir): Added.
(determineVisualStudioVersion): Added.
(determineConfigurationProductDir): Modified to choose proper bin
or bin32 directory.
(visualStudioVersion): Added
(setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2013-05-14 Alexey Proskuryakov <ap@apple.com>
[Mac] Add tests for secure event input
https://bugs.webkit.org/show_bug.cgi?id=116121
Reviewed by Mark Rowe.
* DumpRenderTree/TestRunner.cpp:
(getSecureEventInputIsEnabledCallback):
(TestRunner::staticValues):
Expose an accessor for current secure event input state.
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::secureEventInputIsEnabled):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
Expose an accessor for current secure event input state. This has to be done in
UI process, as this is where it's changed by WebKit.
2013-05-14 Alexey Proskuryakov <ap@apple.com>
[Mac] Add a testing shim for secure event input functions
https://bugs.webkit.org/show_bug.cgi?id=116122
Reviewed by Mark Rowe.
* Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
Inject WebCore testing shim library to override system framework functions.
2013-05-14 Brent Fulgham <bfulgham@apple.com>
[Windows] Switch to embedded manifest commands for launcher executables.
https://bugs.webkit.org/show_bug.cgi?id=116109
Reviewed by Darin Adler.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
now-unused WinLauncher.exe.manifest file.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
* win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
when building with VS2010 or newer.
2013-05-14 Brent Fulgham <bfulgham@apple.com>
[Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
https://bugs.webkit.org/show_bug.cgi?id=116079
Reviewed by David Kilzer.
* Scripts/old-run-webkit-tests:
(setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2013-05-14 Zan Dobersek <zdobersek@igalia.com>
[GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115921
Reviewed by Gustavo Noronha Silva.
* GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
* TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2013-05-13 Alex Christensen <achristensen@apple.com>
Added testRunner.setPrinting.
https://bugs.webkit.org/show_bug.cgi?id=42693
rdar://problem/8213845
Reviewed by Darin Adler.
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
Added setPrinting JavaScript function.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump):
Dump the external representation for printing if setPrinting has been called.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::isPrinting): Added.
(WTR::TestRunner::setPrinting): Added.
Added and initialized m_isPrinting member boolean.
2013-05-13 Csaba Osztrogonác <ossy@webkit.org>
[webkitpy] Make FileInfo.repository_name support SVN version > 1.6
https://bugs.webkit.org/show_bug.cgi?id=116016
Reviewed by Dirk Pranke.
Same fix as in the upstream style checker, but without hg support.
( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
* Scripts/webkitpy/style/checkers/cpp.py:
(FileInfo.repository_name):
2013-05-13 Zan Dobersek <zdobersek@igalia.com>
[GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
https://bugs.webkit.org/show_bug.cgi?id=115918
Reviewed by Gustavo Noronha Silva.
Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
when linking, simplifying the code and suppressing all the layering violations so they do not cause build
problems.
First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
These are then used as dependencies for the archive creation rule as well as the list from which the archive
file paths are constructed and then used to dump the member files from these archives. The member files are
then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
successfully link.
* TestWebKitAPI/GNUmakefile.am:
2013-05-13 Anders Carlsson <andersca@apple.com>
Remove UnusedParam.h
https://bugs.webkit.org/show_bug.cgi?id=116029
Reviewed by Andreas Kling.
Stop including UnusedParam.h.
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
* WebKitTestRunner/qt/TestInvocationQt.cpp:
2013-05-12 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r149955.
http://trac.webkit.org/changeset/149955
https://bugs.webkit.org/show_bug.cgi?id=115990
Broke lots of tests (Requested by smfr on #webkit).
* Scripts/webkitpy/port/mac.py:
2013-05-12 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=115914
Reviewed by Martin Robinson.
* GtkLauncher/main.c:
(createToolbar):
* MiniBrowser/gtk/BrowserWindow.c:
(_BrowserWindow):
(browserWindowSetStatusText):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
2013-05-11 Anders Carlsson <andersca@apple.com>
Crash when terminating a process that has not been fully launched
https://bugs.webkit.org/show_bug.cgi?id=115962
<rdar://problem/13660916>
Reviewed by Andreas Kling.
Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
before the process has had a chance to be fully launched.
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2013-05-10 Laszlo Gombos <l.gombos@samsung.com>
Remove Mac OS X Leopard (10.5) support
https://bugs.webkit.org/show_bug.cgi?id=107964
Reviewed by Ryosuke Niwa.
Removed the code for 10.5 and removed if-def for 10.6.
* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(convertMIMEType):
(createXMLStringFromWebArchiveData):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::authenticateSession):
(TestRunner::setTextDirection):
* WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertMIMEType):
(createXMLStringFromWebArchiveData):
2013-05-10 Brent Fulgham <bfulgham@apple.com>
[Windows] Allow VS2010 Build to use VS2005 Support Libraries
https://bugs.webkit.org/show_bug.cgi?id=115935
Reviewed by Jer Noble.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
to the new manifest file.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2013-05-10 Jacky Jiang <zhajiang@blackberry.com>
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
Fix the following warnings for BlackBerry:
DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
used as truth value [-Wparentheses].
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2013-05-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
[WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
https://bugs.webkit.org/show_bug.cgi?id=115928
Reviewed by Kenneth Rohde Christiansen.
WKViewSetThemePath was moved to WKViewEfl.h.
* TestWebKitAPI/efl/PlatformWebView.cpp:
2013-05-10 Andreas Kling <akling@apple.com>
I accidentally the Java testing.
* Scripts/webkitpy/port/mac.py:
2013-05-10 Brian Holt <brian.holt@samsung.com>
[GTK] Module Cairo fails to build under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=115854
Reviewed by Martin Robinson.
Make cairo depend on glib in jhbuild.modules.
* gtk/jhbuild.modules:
2013-05-10 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=115904
Reviewed by Martin Robinson.
* ImageDiff/gtk/ImageDiff.cpp:
(main):
2013-05-10 Balazs Kelemen <kbalazs@webkit.org>
Add my new address to contributors.json. (Unreviewed)
* Scripts/webkitpy/common/config/contributors.json:
2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
Unreviewed. Move myself to the reviewers list.
* Scripts/webkitpy/common/config/contributors.json:
2013-05-10 Christophe Dumez <ch.dumez@sisa.samsung.com>
Unreviewed. Add my email to a few watchlists.
* Scripts/webkitpy/common/config/watchlist:
2013-05-10 Simon Pena <simon.pena@samsung.com>
Unicode support missing from string representation of Contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=115859
Reviewed by Darin Adler.
Contributors, in committers.py, provided a string representation in __str__ which
didn't support unicode characters, so printing a contributor would fail in that case.
This patch implements __unicode__ and makes __str__ use it to represent a contributor.
The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
* Scripts/webkitpy/common/config/committers.py: Move the existing string representation
to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
representation.
(Contributor.__str__):
(Contributor):
(Contributor.__unicode__):
* Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
a contributor with unicode characters can be represented as a string.
(CommittersTest):
(CommittersTest.test_contributor_encoding):
2013-05-09 Patrick Gansterer <paroga@webkit.org>
[WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
https://bugs.webkit.org/show_bug.cgi?id=92371
Reviewed by Brent Fulgham.
Use JavaScriptThreading.cpp where the same functionality is
implemented too. This reduces the dependency on the pthread
library. Also replace assert() with WebKit ASSERT().
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
* DumpRenderTree/win/DumpRenderTree.cpp:
(dumpHistoryItem):
(dumpBackForwardList):
* DumpRenderTree/win/DumpRenderTree.vcproj:
2013-05-09 Patrick Gansterer <paroga@webkit.org>
[DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
https://bugs.webkit.org/show_bug.cgi?id=92505
Reviewed by Brent Fulgham.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
(javaScriptThreadsMutex):
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):
* DumpRenderTree/pthreads: Removed.
* DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
2013-05-09 Mario Sanchez Prada <mario.prada@samsung.com>
Unreviewed. Update Simon Pena email on his behalf.
* Scripts/webkitpy/common/config/contributors.json:
2013-05-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
Add support for [NoInterfaceObject] Web IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=115714
Reviewed by Kentaro Hara.
Update BindingsTests.generate_supplemental_dependency() to pass an
additional windowConstructorsFile argument to preprocess-idls.pl.
* Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
2013-05-09 ChangSeok Oh <changseok.oh@collabora.com>
[GTK][AC] Buildfix after r149694
https://bugs.webkit.org/show_bug.cgi?id=115797
Reviewed by Gustavo Noronha Silva.
Add CLUTTER_LIBS for linking TestWebCore.
* TestWebKitAPI/GNUmakefile.am:
2013-05-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[EFL] Remove unnecessary pkgs in EFL jhbuild
https://bugs.webkit.org/show_bug.cgi?id=114908
Reviewed by Laszlo Gombos.
p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
handle them using jhbuild. We can reduce build time when using --update-efl.
* efl/jhbuild.modules:
2013-05-08 Seokju Kwon <seokju.kwon@gmail.com>
[EFL] Disable SHADOW DOM feature in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=115834
Reviewed by Gyuyoung Kim.
* Scripts/webkitperl/FeatureList.pm:
2013-05-08 Lucas Forschler <lforschler@apple.com>
Add Scheduler for Mac MtnLion 32bit Release builder.
Unreviewed.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2013-05-08 Denis Nomiyama <d.nomiyama@samsung.com>
Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
https://bugs.webkit.org/show_bug.cgi?id=115808
Reviewed by Darin Adler.
The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
was left outdated after r127191, when the m_string member was changed
from UString to String. This patch calls the right pretty printer for it.
* gdb/webkit.py:
(JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
WTFImplPrettyPrinter.
2013-05-08 Andy Estes <aestes@apple.com>
[WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
https://bugs.webkit.org/show_bug.cgi?id=115790
Reviewed by Alexey Proskuryakov.
Added two API tests:
1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::decidePolicyForNavigationAction):
(CustomProtocolInvalidSchemeTest):
(TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
2013-05-08 Lucas Forschler <lforschler@apple.com>
Teach buildbot how to compile 32-bit on Mac.
Reviewed by Ryosuke Niwa.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
(ExtractTestResultsAndLeaks):
2013-05-08 Eli Fidler <efidler@blackberry.com>
[BlackBerry] Fix usage of BlackBerry::Platform::String
https://bugs.webkit.org/show_bug.cgi?id=115781
Reviewed by Rob Buis.
BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setUserStyleSheetLocation):
* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
(LoadHTMLStringItem::invoke):
2013-05-08 Alberto Garcia <agarcia@igalia.com>
Tools: add new BlackBerry include dirs.
https://bugs.webkit.org/show_bug.cgi?id=115514
Reviewed by Rob Buis.
iType include dirs are missing, and HarfBuzz needs to be fixed.
* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
2013-05-08 José Dapena Paz <jdapena@igalia.com> and Zan Dobersek <zdobersek@igalia.com>
[GTK] Plumb the Automake build system for the Battery Status API feature
https://bugs.webkit.org/show_bug.cgi?id=115718
Reviewed by Martin Robinson.
* Scripts/webkitdirs.pm:
(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.
2013-05-08 Ryosuke Niwa <rniwa@webkit.org>
new-run-webkit-websocketserver doesn't work after Chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115816
Reviewed by Joseph Pecoraro.
Fix the bug by instantiating the correct port object.
* Scripts/new-run-webkit-websocketserver:
(main):
2013-05-07 Lucas Forschler <lforschler@apple.com>
Configure buildbot for 32bit builder.
https://bugs.webkit.org/show_bug.cgi?id=115769
Reviewed by Ryosuke Niwa.
* BuildSlaveSupport/build.webkit.org-config/config.json:
2013-05-08 Brent Fulgham <bfulgham@webkit.org>
Unreviewed. Update to show my apple.com address.
* Scripts/webkitpy/common/config/contributors.json: Added
my apple.com e-mail address.
2013-05-08 David Kilzer <ddkilzer@apple.com>
BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(concatenateAttributeAndValue): Switch to appendVector().
2013-05-08 Andras Becsi <andras.becsi@digia.com>
[Qt][WTR] Fix the build on Mac after r149692
Unreviewed build fix.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2013-05-08 Mario Sanchez Prada <mario.prada@samsung.com>
Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.
* Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
* Scripts/webkitpy/common/config/watchlist: Added myself.
2013-05-08 Andras Becsi <andras.becsi@digia.com>
[Qt] Build fails with clang
https://bugs.webkit.org/show_bug.cgi?id=115741
Reviewed by Benjamin Poulain.
Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.
* qmake/mkspecs/features/unix/default_pre.prf:
2013-05-08 Darin Adler <darin@apple.com>
Fix one more place that needed to use adoptCF/NS
https://bugs.webkit.org/show_bug.cgi?id=115778
Reviewed by Benjamin Poulain.
Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.
* WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.
* WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
2013-05-08 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r149271.
http://trac.webkit.org/changeset/149271
https://bugs.webkit.org/show_bug.cgi?id=115780
The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).
* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2013-05-08 Zan Dobersek <zdobersek@igalia.com>
[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
https://bugs.webkit.org/show_bug.cgi?id=115636
Reviewed by Ryosuke Niwa.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.
2013-05-06 Darin Adler <darin@apple.com>
Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):
* DumpRenderTree/cg/ImageDiffCG.cpp:
(createImageFromStdin):
(createDifferenceImage):
(main):
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(printPNG):
(dumpBitmap):
* DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::BitmapContext):
* DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider init]):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContext):
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
* DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData):
* DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):
* DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):
* DumpRenderTree/win/ImageDiffCairo.cpp:
(createImageFromStdin):
(main):
* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):
* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
* TestWebKitAPI/Tests/mac/AttributedString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/BackForwardList.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
* TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
* TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
(WTR::testPathFromURL):
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.
2013-05-07 Alex Christensen <achristensen@apple.com>
Fix a memory leak introduced in r149692
https://bugs.webkit.org/show_bug.cgi?id=115766
Reviewed by Mark Rowe.
In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
2013-05-07 Darin Adler <darin@apple.com>
[Win] Fix storage leak in Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115651
Reviewed by Sam Weinig.
* DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent): Added a missing call to adoptCF.
2013-05-07 Alex Christensen <achristensen@apple.com>
fixed a memory leak introduced by bug 42324 by using a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=115760
Reviewed by Tim Horton.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros
2013-05-07 Alex Christensen <achristensen@apple.com>
WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>
Reviewed by Tim Horton.
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive code that is called when dumping.
(WTR::InjectedBundlePage::dump):
Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
Added dumpDOMAsWebArchive declaration.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
* Tools/WebKitTestRunner/cf: Added.
* Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
(convertMIMEType):
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):
* Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
Copied from Tools/DumpRenderTree/cf for used symbol declarations.
* Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
Copied from Tools/DumpRenderTree/mac for used functions.
(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):
2013-05-07 Alex Christensen <achristensen@apple.com>
Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=115745
Reviewed by Tim Horton.
* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(compareResourceURLs):
Updated style.
2013-05-06 Ryosuke Niwa <rniwa@webkit.org>
Add an 'isReadOnly' member to IDL parse tree structure
https://bugs.webkit.org/show_bug.cgi?id=115704
Reviewed by Kentaro Hara.
Use newly added isReadOnly attribute.
* WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_generateHeaderFile):
(_generateImplementationFile):
(_staticValuesGetterImplementation):
2013-05-07 Anders Carlsson <andersca@apple.com>
Remove AlwaysInline.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=115727
Reviewed by Brent Fulgham.
The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
to keep AlwaysInline.h around anymore.
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2013-05-07 Andras Becsi <andras.becsi@digia.com>
[Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
https://bugs.webkit.org/show_bug.cgi?id=114808
Reviewed by Jocelyn Turcotte.
QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
(https://codereview.qt-project.org/#change,54234)
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
2013-05-06 Christophe Dumez <ch.dumez@sisa.samsung.com>
Unreviewed. Add my email to EFL and BindingsScripts watchlists.
* Scripts/webkitpy/common/config/watchlist:
2013-05-06 Kangil Han <kangil.han@samsung.com>
[EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115645
Reviewed by Gyuyoung Kim.
To run performance tests in wk1, we need --no-timeout option implementation.
So adopt it from gtk+ port.
* DumpRenderTree/efl/DumpRenderTree.cpp:
(shouldSetWaitToDumpWatchdog):
(parseCommandLineOptions):
* DumpRenderTree/efl/DumpRenderTreeEfl.h:
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setWaitToDump):
2013-05-06 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r149547.
http://trac.webkit.org/changeset/149547
https://bugs.webkit.org/show_bug.cgi?id=115682
Added unittests that fail on bots and spits out text into
stdout (Requested by rniwa on #webkit).
* Scripts/import-w3c-tests: Removed.
* Scripts/webkitpy/w3c/__init__.py: Removed.
* Scripts/webkitpy/w3c/test_converter.py: Removed.
* Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
* Scripts/webkitpy/w3c/test_importer.py: Removed.
* Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
* Scripts/webkitpy/w3c/test_parser.py: Removed.
* Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
2013-05-03 Gustavo Noronha Silva <gns@gnome.org>
[jhbuild] bump jhbuild version to take advantage of new improvements
https://bugs.webkit.org/show_bug.cgi?id=115558
Reviewed by Martin Robinson.
One of the important improvements is jhbuild no longer fetches git
repositories if they are already at the expected revision, which should
make the EWS bots more robust to git servers unavailability.
* jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
2013-05-06 Manuel Rego Casasnovas <rego@igalia.com>
[GTK] Add webkit_uri_scheme_request_finish_error
https://bugs.webkit.org/show_bug.cgi?id=94316
Reviewed by Anders Carlsson.
* MiniBrowser/gtk/main.c:
(miniBrowserErrorQuark): Add function to create a global quark for
MiniBrowser.
(aboutURISchemeRequestCallback): Update MiniBrowser to use the new
function webkit_uri_scheme_request_finish_error().
2013-05-06 Mike Lattanzio <mlattanzio@blackberry.com>
[BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
https://bugs.webkit.org/show_bug.cgi?id=113808
Reviewed by Rob Buis.
Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
to true for BlackBerry.
* Scripts/webkitperl/FeatureList.pm:
2013-05-06 Jessie Berlin <jberlin@apple.com>
check-webkit-style should complain about a layering violation if platform-specific guards are
used in WebCore outside of the platform directory
https://bugs.webkit.org/show_bug.cgi?id=115567
Reviewed by Benjamin Poulain.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_for_webcore_platform_layering_violation):
If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
(process_line):
Add the check_for_webcore_platform_layering_violation.
(CppChecker):
List the new check.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_webcore_platform_layering_violation):
Add tests.
2013-05-06 David Kilzer <ddkilzer@apple.com>
webkit-patch: fix 'upload' command with Bugzilla 4.2.5
<http://webkit.org/b/115667>
Reviewed by Dirk Pranke.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._check_create_bug_response): Update regex to work with
Bugzilla 3.2.3 and 4.2.5.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test__check_create_bug_response): Add new test that covers both
old and new <title> variations.
2013-05-06 Zan Dobersek <zdobersek@igalia.com>
[Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
https://bugs.webkit.org/show_bug.cgi?id=115661
Reviewed by Ryosuke Niwa.
The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2013-05-06 Zan Dobersek <zdobersek@igalia.com>
[Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
https://bugs.webkit.org/show_bug.cgi?id=114603
Reviewed by Ryosuke Niwa.
* TestResultServer/generate_builders_json.py:
(insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
to represent these to be 'layout-test', for backwards compatibility.
(main): Remove all the build.chromium.org masters.
* TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_generate_json_data):
* TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
test-running builders from the webkit.org master.
2013-05-06 Zan Dobersek <zdobersek@igalia.com>
[Flakiness Dashboard] Update expected outcome in a couple of unit tests after r148778
https://bugs.webkit.org/show_bug.cgi?id=114988
Reviewed by Ryosuke Niwa.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Update the expected platforms list, the Chromium
and Apple Mac Snow Leopard platforms were removed with the Apple Mac Mountain Lion platform being added.
* TestResultServer/static-dashboards/loader_unittests.js: Update the list of the expected loaded expectations platforms,
mac-snowleopard isn't loaded anymore due to the support for the platform being removed, while the mac-wk2 is loaded twice,
once for the Apple Mac Lion and once for the Apple Mac Mountain Lion platform.
2013-05-06 Zan Dobersek <zdobersek@igalia.com>
[Flakiness Dashboard] Remove the remaining traces of platform modifier unions
https://bugs.webkit.org/show_bug.cgi?id=114954
Reviewed by Ryosuke Niwa.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processExpectationsForPlatform): Remove the platform tree traversal that checked for presence of the platform
modifier unions in the list of modifiers.
(generatePageForExpectationsUpdate): Only filter through the modifiers that do not represent build types or bug references.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Adjust the test cases for the realModifiers unit test.
2013-05-06 Zan Dobersek <zdobersek@igalia.com>
[Flakiness Dashboard] Simplify builder-name-based platform recognition
https://bugs.webkit.org/show_bug.cgi?id=114957
Reviewed by Ryosuke Niwa.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(determineBuilderPlatform): Renamed from nonChromiumPlatform.
(chromiumPlatform): Removed, unnecessary.
(platformAndBuildType): With Chromium builders are gone, meaning determineBuilderPlatform can be called by default
to determine the platform of the builder. No need to check for 'DBG' substring in the builder name to determine whether
the builder operates with debug builds, no webkit.org builders are named this way.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(platformAndBuildTypes): Remove Chromium-specific test cases, reducing the number of expected assertions this test will make.
2013-05-06 Andy Estes <aestes@apple.com>
Added two files I neglected to commit in r149589.
* TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
* TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2013-05-04 Andy Estes <aestes@apple.com>
REGRESSION (r125592): Reproducible crash in DOMWindow::open when a delegate closes the new window in decidePolicyForNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=115609
Reviewed by Oliver Hunt.
Added an API test.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/CloseNewWindowInNavigationPolicyDelegate.mm: Added.
(+[TestDelegate shared]):
(-[TestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[TestDelegate webView:createWebViewWithRequest:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/OpenNewWindow.html: Added.
2013-05-06 Antoine Quint <graouts@apple.com>
Manage the presentation of the snapshotted plug-in using JavaScript
https://bugs.webkit.org/show_bug.cgi?id=115548
Reviewed by Dean Jackson.
Take into account the new plugInExtraScript method added to support
the injection of a JS file from the chrome client to customize the
rendering of a snapshotted plug-in's shadow tree.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
2013-05-05 Anders Carlsson <andersca@apple.com>
Remove the Vector::append overload that takes a Vector
https://bugs.webkit.org/show_bug.cgi?id=115535
Reviewed by Andreas Kling.
Use Vector::appendVector instead.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(concatenateAttributeAndValue):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::concatenateAttributeAndValue):
2013-05-04 Sam Weinig <sam@webkit.org>
REGRESSION(r148312): Crash when calling WKPageClose(page) followed by WKPageTerminate(page)
<rdar://problem/13702008>
https://bugs.webkit.org/show_bug.cgi?id=115607
Reviewed by Benjamin Poulain.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
Add test that calls WKPageClose, follow by WKPageTerminate. If it crashes, its not working.
2013-05-04 Zan Dobersek <zdobersek@igalia.com>
Unreviewed.
* Scripts/webkitpy/common/config/contributors.json: Correcting my igalia.com email address.
2013-05-04 Mihnea Ovidenie <mihnea@adobe.com>
Unreviewed. Adding Radu Stavila as an Adobe contributor, working on CSSRegions.
* Scripts/webkitpy/common/config/contributors.json:
2013-05-04 Zan Dobersek <zdobersek@igalia.com>
[GTK] Catch select.error exceptions in parse_output_lines
https://bugs.webkit.org/show_bug.cgi?id=115253
Reviewed by Gustavo Noronha Silva.
Catch any select.error exceptions when waiting for the file descriptor to become readable when parsing the
output lines in common.parse_output_lines. These are currently being thrown when running the GTK unit tests on
builders, but are not fatal. Because of that they are at the moment only logged (writing out the file descriptor,
error code and the error message) and the loop is re-entered.
* gtk/common.py:
(parse_output_lines):
2013-05-04 Zan Dobersek <zdobersek@igalia.com>
[GTK] Set up the TestWebCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115237
Reviewed by Gustavo Noronha Silva.
Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
a workaround for the layer violations and circular dependencies between various static libraries. Linking against
either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
* TestWebKitAPI/GNUmakefile.am:
2013-05-03 Rebecca Hauck <rhauck@adobe.com>
Create a script to import W3C tests
https://bugs.webkit.org/show_bug.cgi?id=111513
Reviewed by Dirk Pranke.
Script to automate the import of W3C tests into WebKit.
For the full description of how it works, see the comments
at the top of test_importer.py.
* Scripts/import-w3c-tests: Added.
* Scripts/webkitpy/w3c/__init__.py: Added.
* Scripts/webkitpy/w3c/test_converter.py: Added.
(TestConverter):
(TestConverter.__init__):
(TestConverter.load_prefixed_prop_list):
(TestConverter.load_file):
(TestConverter.convert_for_webkit):
(TestConverter.convert_testharness_paths):
(TestConverter.convert_prefixed_properties):
(TestConverter.scrub_unprefixed_props):
(TestConverter.replace_tag):
* Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
(TestConverterTest):
(TestConverterTest.testLoadPrefixedPropList):
(TestConverterTest.test_convertForWebkitNothingToConvert):
(test_convertForWebkitHarnessOnly):
(test_convertForWebkitPropsOnly):
(test_convertForWebkitHarnessAndProps):
(test_convertTestHarnessPaths):
(test_convertPrefixedProperties):
(verifyTestHarnessPaths):
(verifyPrefixedProperties):
(generateTestContent):
* Scripts/webkitpy/w3c/test_importer.py: Added.
(main):
(parse_args):
(validate_import_directory):
(TestImporter):
(TestImporter.__init__):
(TestImporter.do_import):
(TestImporter.get_changeset):
(TestImporter.scan_source_directory):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.get_test_status):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):
* Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
(TestImporterTest):
(TestImporterTest.test_ImportDirWithNoTests):
* Scripts/webkitpy/w3c/test_parser.py: Added.
(TestParser):
(TestParser.__init__):
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.get_reftests):
(TestParser.is_jstest):
(TestParser.get_support_files):
* Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
(TestParserTest):
(TestParserTest.test_analyzeTestReftestOneMatch):
(test_analyzeTestReftestMultipleMatches):
(test_analyzeTestReftestMatchAndMismatch):
(test_analyzeTestReftestWithRefSupportFiles):
(test_analyzeJSTest):
(test_analyzePixelTestAllTrue):
(test_analyzePixelTestAllFalse):
(test_analyzeNonHTMLFile):
2013-05-03 Christophe Dumez <ch.dumez@sisa.samsung.com>
Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.
* Scripts/webkitpy/common/config/contributors.json:
2013-05-02 Nico Weber <thakis@chromium.org>
Remove a stale script file.
https://bugs.webkit.org/show_bug.cgi?id=115521
Reviewed by Anders Carlsson.
This script was added in
https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
Bakefile system that was removed in
https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
script just asserts when it's run and is useless.
* Scripts/update-sources-list.py: Removed.
2013-05-01 Glenn Adams <glenn@skynav.com>
[webkitpy] Need abstract base class for commands that analyze commit logs
https://bugs.webkit.org/show_bug.cgi?id=115391
Reviewed by Benjamin Poulain.
Move commit log parsing functions into new abstract base class AbstractCommitLogCommand
in preparation for adding two new commands that will reuse this functionality along with
suggest-nominations. See https://bugs.webkit.org/show_bug.cgi?id=115387 and
https://bugs.webkit.org/show_bug.cgi?id=115388.
No new tests as this patch does not change existing functionality or behavior.
* Scripts/webkitpy/tool/commands/suggestnominations.py:
(AbstractCommitLogCommand): Add abstract base class for commands that analyze commit logs.
(AbstractCommitLogCommand.__init__):
(AbstractCommitLogCommand._init_options):
(AbstractCommitLogCommand._parse_commit_message):
(SuggestNominations): Move generic commit log parsing into new base class. Use new base class.
(SuggestNominations.__init__):
(SuggestNominations._init_options):
2013-05-01 Seokju Kwon <seokju.kwon@gmail.com>
Web Inspector: Fix check-inspector-strings script and fix localized strings
https://bugs.webkit.org/show_bug.cgi?id=115495
Reviewed by Joseph Pecoraro.
* Scripts/check-inspector-strings:
2013-05-01 Zan Dobersek <zdobersek@igalia.com>
[TestWebKitAPI] <WebKit2/WebKit2_C.h> being included in GTK WK1-only builds
https://bugs.webkit.org/show_bug.cgi?id=115470
Reviewed by Martin Robinson.
In the TestWebKitAPI's config.h header, only include the <WebKit2/WebKit2_C.h> header when
not building either of the IOS, Windows or GTK-WK1 platforms.
Up until now the header was included for everything but the IOS and Windows platforms due to
an incorrectly stated condition regarding the GTK platform.
* TestWebKitAPI/config.h:
2013-05-01 Zan Dobersek <zdobersek@igalia.com>
[GTK] Split the forwarding headers stamp in the TestWebKitAPI GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=115469
Reviewed by Martin Robinson.
Split the stamp-testwebkitapi-forwarding-headers into two stamps, one covering forwarding headers
for the WebCore tests (under the Tests/WebCore directory) and the other covering forwarding headers
for the WebKit2 tests and the injected bundle required by them.
This makes it possible for the WebCore tests to compile when the WebKit2 build is disabled, i.e. the WebCore
tests shouldn't depend on the WebKit2 build (though the forwarding headers generation script is stored
under the WebKit2 code).
The WebCore forwarding headers are generated by scanning only the files under the Tests/WebCore directory,
while the WebKit2 forwarding headers generation should keep on scanning the complete root directory of the
TestWebKitAPI subproject, though the target directory should be narrowed down if at all possible.
* TestWebKitAPI/GNUmakefile.am:
2013-04-30 Glenn Adams <glenn@skynav.com>
Unreviewed. Add myself to watchlist entries.
* Scripts/webkitpy/common/config/watchlist:
2013-04-30 Glenn Adams <glenn@skynav.com>
[webkitpy] suggest-nominations doesn't count all qualified patches
https://bugs.webkit.org/show_bug.cgi?id=115285
Reviewed by Benjamin Poulain.
Fix commit analysis so that patches made by an existing committer are counted towards reviewer
nomination. Improve commit log parsing.
* Scripts/webkitpy/tool/commands/suggestnominations.py:
(CommitLogError):
(CommitLogError.__init__):
(CommitLogMissingReviewer):
(CommitLogMissingReviewer.__init__):
(SuggestNominations):
(SuggestNominations.__init__):
(SuggestNominations._recent_commit_messages):
(SuggestNominations._author_name_from_email):
(SuggestNominations._contributor_from_email):
(SuggestNominations._parse_commit_message):
(SuggestNominations._count_commit):
(SuggestNominations._count_recent_patches):
(SuggestNominations._collect_nominations):
(SuggestNominations._print_nominations):
(SuggestNominations.execute):
* Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
(_make_options):
(test_recent_commit_messages):
(test_basic):
2013-04-30 Commit Queue <rniwa@webkit.org>
Unreviewed, rolling out r149309.
http://trac.webkit.org/changeset/149309
https://bugs.webkit.org/show_bug.cgi?id=115430
The patch does not build on WK1-only builds of the GTK port
(Requested by zdobersek on #webkit).
* TestWebKitAPI/GNUmakefile.am:
2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
Stop using "in" keyword in IDL files
https://bugs.webkit.org/show_bug.cgi?id=115418
Reviewed by Kentaro Hara.
Remove "in" keyword from IDL files as this is no longer part of the Web
IDL specification.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/Bindings/GCController.idl:
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
[EFL] Enable scaled cursors
https://bugs.webkit.org/show_bug.cgi?id=106242
Reviewed by Gyuyoung Kim.
Enable ENABLE_MOUSE_CURSOR_SCALE for EFL port.
* Scripts/webkitperl/FeatureList.pm:
2013-04-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
Replace "Optional" extended attribute by proper Web IDL "optional" keyword
https://bugs.webkit.org/show_bug.cgi?id=115380
Reviewed by Kentaro Hara.
Replace WebKit-specific [Optional] extended attribute by Web IDL "optional"
keyword.
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2013-04-30 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Fix the USE(3D_GRAPHICS) build with the standard OpenGL on Windows
https://bugs.webkit.org/show_bug.cgi?id=114684
Reviewed by Simon Hausmann.
Remove the ANGLE requirement for USE(3D_GRAPHICS).
This enables WebKit2 in the build when using a "-opengl desktop" configured Qt.
* qmake/mkspecs/features/features.prf:
2013-04-29 Zan Dobersek <zdobersek@igalia.com>
[GTK] Disable Shadow DOM feature
https://bugs.webkit.org/show_bug.cgi?id=115374
Reviewed by Martin Robinson.
Disable the Shadow DOM feature on the GTK port, the feature is planned for removal.
* Scripts/webkitperl/FeatureList.pm:
2013-04-29 Glenn Adams <glenn@skynav.com>
[webkitpy] Add missing contributor email addresses
https://bugs.webkit.org/show_bug.cgi?id=115394
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/common/config/contributors.json:
2013-04-29 Alberto Garcia <agarcia@igalia.com>
Remove all remaining Skia code
https://bugs.webkit.org/show_bug.cgi?id=115263
Reviewed by Benjamin Poulain.
Remove all remaining references to Skia.
* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
* Scripts/webkitpy/common/config/contributionareas.py:
* Scripts/webkitpy/common/config/watchlist:
2013-04-29 Seokju Kwon <seokju.kwon@gmail.com>
Get rid of unused options in Tools/Scripts/webkit-build-directory
https://bugs.webkit.org/show_bug.cgi?id=115383
Reviewed by Darin Adler.
* Scripts/webkit-build-directory:
2013-04-29 Alexey Proskuryakov <ap@apple.com>
[WK2][Mac] Test with NetworkProcess enabled.
Fix the build for non-Mac.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
2013-04-29 Alexey Proskuryakov <ap@apple.com>
[WK2][Mac] Test with NetworkProcess enabled.
Reviewed by Sam Weinig.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
2013-04-29 Zan Dobersek <zdobersek@igalia.com>
[GTK] Set up the TestWebCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115237
Reviewed by Gustavo Noronha Silva.
Set up the WebCore unit test program, consisting of the unit tests under the TestWebKitAPI/Tests/WebCore directory.
Again the approach of specifying libtool libraries multiple times in the TestWebCore program's LDFLAGS is used as
a workaround for the layer violations and circular dependencies between various static libraries. Linking against
either libwebkitgtk or libwebkit2gtk shared libraries is avoided due to the unit tests covering WebCore, which
shouldn't rely on neither of the two distributable libraries (hence the dirty workaround).
* TestWebKitAPI/GNUmakefile.am:
2013-04-29 Zan Dobersek <zdobersek@igalia.com>
[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115236
Reviewed by Gustavo Noronha Silva.
Set up the TestJavaScriptCore unit test program, consisting of the unit tests
under the TestWebKitAPI/Tests/JavaScriptCore directory.
* TestWebKitAPI/GNUmakefile.am:
2013-04-29 Zan Dobersek <zdobersek@igalia.com>
[GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
https://bugs.webkit.org/show_bug.cgi?id=115323
Reviewed by Philippe Normand.
Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
Its presence enforces linkers to output mangled symbols when reporting linking failures
due to unresolved references. People trying to fix the build can then simply copy
the printed mangled symbol into the symbols.filter file instead of doing a manual build
or connecting to the builders to discover the mangled version of the missing symbol.
* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2013-04-28 Zan Dobersek <zdobersek@igalia.com>
Remove Chromium code from Tools/BuildSlaveSupport
https://bugs.webkit.org/show_bug.cgi?id=115325
Reviewed by Benjamin Poulain.
Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
covering archiving test results and built products.
* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
* BuildSlaveSupport/chromium/output-android-device-status: Removed.
* BuildSlaveSupport/chromium/remove-crash-logs: Removed.
* BuildSlaveSupport/test-result-archive:
(archiveTestResults):
2013-04-28 Seokju Kwon <seokju.kwon@gmail.com>
Remove support for Chromium from webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=115338
Reviewed by Darin Adler.
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):
2013-04-28 Zan Dobersek <zdobersek@igalia.com>
Rename TestRunner's setAudioData to setAudioResult
https://bugs.webkit.org/show_bug.cgi?id=115326
Reviewed by Darin Adler.
Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
than the previous one. The change is a simple rename, there's no change in the method's functionality. The
affected tests are adjusted accordingly.
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::setAudioResult):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioResult):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
2013-04-28 Zan Dobersek <zdobersek@igalia.com>
[WKTR] Tests dumping audio data shouldn't dump pixels
https://bugs.webkit.org/show_bug.cgi?id=115270
Reviewed by Benjamin Poulain.
Prevent dumping the pixel output when Web Audio tests are dumping output data
as the testing output. Pixel output in these tests has no real meaning and is
as such unnecessary.
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioData):
2013-04-27 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
[EFL] Unreviewed Intel bots fix after r149231.
* efl/jhbuild.modules: Disable the libxml Python bindings since the
bots don't have Python's development files installed. libxml should
detect this kind of thing better.
2013-04-26 Ryuan Choi <ryuan.choi@samsung.com>
[EFL] Build break using jhbuild on ubuntu 13.04
https://bugs.webkit.org/show_bug.cgi?id=115225
Reviewed by Gyuyoung Kim.
libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
libxml 2.9.0 has a bug to make regression which r138422 mentioned.
So this patch bumped libxml version to 2.9.1.
* efl/jhbuild.modules:
2013-04-26 Jeffrey Pfau <jpfau@apple.com>
delete-stale-build-files does not clear .d files
http://bugs.webkit.org/show_bug.cgi?id=115293
Reviewed by Ryosuke Niwa.
* BuildSlaveSupport/delete-stale-build-files:
(main): Add .d to the file type list
2013-04-26 Roger Fong <roger_fong@apple.com>
Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
Make the DebugSuffix configuration use _debug dependencies.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed.
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
* WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
* win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
* win/AssembleBuildLogs/AssembleLogs.cmd:
* win/record-memory/record-memory.vcxproj:
* win/record-memory/record-memoryDebug.props:
* win/record-memory/record-memoryDebugWinCairo.props:
* win/record-memory/record-memoryProduction.props:
* win/record-memory/record-memoryRelease.props:
* win/record-memory/record-memoryReleaseWinCairo.props:
2013-04-26 Zan Dobersek <zdobersek@igalia.com>
[GTK] Clean up the TestWebKitAPI GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=115233
Reviewed by Martin Robinson.
Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.
* TestWebKitAPI/GNUmakefile.am:
2013-04-25 Andy Estes <aestes@apple.com>
[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
https://bugs.webkit.org/show_bug.cgi?id=115223
Reviewed by Darin Adler.
Added an API test.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
(TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
when it loads a request with a custom protocol.
* TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
NSURLProtocol subclass to TestProtocol.{h, mm} and did some
miscellaneous cleanup.
* TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
* TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(+[TestProtocol scheme]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):
2013-04-26 Martin Robinson <mrobinson@igalia.com>
Remove the remaining Skia #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=114886
Reviewed by Benjamin Poulain.
* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView): Remove Skia #ifdef references.
2013-04-26 Mary Wu <mary.wu@torchmobile.com.cn>
[BlackBerry] Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=113267
Reviewed by Rob Buis.
Update DumpRenderTree with change of load() interface in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::runTest):
2013-04-26 Zan Dobersek <zdobersek@igalia.com>
Remove the HeapGraphSerializer unit test
https://bugs.webkit.org/show_bug.cgi?id=115231
Reviewed by Andreas Kling.
Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.
* TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
Remove support for Chromium from build/update scripts
https://bugs.webkit.org/show_bug.cgi?id=115218
Reviewed by Darin Adler.
* Scripts/build-webkit:
(writeCongrats):
* Scripts/update-webkit:
2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
Remove support for Chromium from api-test
https://bugs.webkit.org/show_bug.cgi?id=115211
Reviewed by Dirk Pranke.
* Scripts/build-api-tests:
* Scripts/run-api-tests:
(isSupportedPlatform):
2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
Get rid of Chromium in build-dumprendertree
https://bugs.webkit.org/show_bug.cgi?id=115212
Reviewed by Dirk Pranke.
* Scripts/build-dumprendertree:
2013-04-25 Alexey Proskuryakov <ap@apple.com>
Pass relatedPage when creating a page in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=115206
Reviewed by Geoffrey Garen.
To make sure that window.open() opens in the same process even when using multiple processes.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView):
2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
Fix autocompletion for Benjamin. The Bugzilla email address must come first.
* Scripts/webkitpy/common/config/contributors.json:
2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
Build fix. Forgot to merge args.
* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
2013-04-25 Ryosuke Niwa <rniwa@webkit.org>
webkitbot should recognize its own nickname in greetings.
https://bugs.webkit.org/show_bug.cgi?id=115196
Reviewed by Andreas Kling.
Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.
* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
2013-04-25 Xavier Castano <xcastanho@igalia.com>
[GTK] Tools/gtk/install-dependencies added ragel dependency
https://bugs.webkit.org/show_bug.cgi?id=115163
Reviewed by Xan Lopez.
The install-dependencies script was missing a dependency on ragel
which is expected when building HarfBuzz.
* gtk/install-dependencies: Added a dependency on ragel for both
apt and yum.
2013-04-25 Eduardo Lima Mitev <elima@igalia.com>
[GTK] Remove pango from optional jhbuild dependencies
https://bugs.webkit.org/show_bug.cgi?id=115162
Reviewed by Martin Robinson.
Pango is not needed since revision r148293 that lowers the pango
dependency to 1.30, which is available in most distributions.
* gtk/jhbuild-optional.modules: Removes description of pango module.
2013-04-25 Seokju Kwon <seokju.kwon@gmail.com>
Remove Chromium-specific cases from FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=115169
Reviewed by Andreas Kling.
* Scripts/webkitperl/FeatureList.pm:
2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
Remove checking chromium from run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=115139
Reviewed by Benjamin Poulain.
* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
2013-04-24 Simon Fraser <simon.fraser@apple.com>
Pixel tests in SVG are all broken in WK2
https://bugs.webkit.org/show_bug.cgi?id=114218
Reviewed by Darin Adler.
Window snapshots in WebKitTestRunner on Mac are window-sized
(800x600), which is wrong for the W3C SVG tests that require a
480x360 snapshot.
Fix by resizing the window, as well as the web view in
PlatformWebView::resizeTo() so that window snapshots are correctly
sized.
Also do some drive-by cleanup of the window size constants in both
DRT and WTR to remove magic numbers, and make the code more similar.
* DumpRenderTree/TestRunner.cpp:
(TestRunner::setShouldPaintBrokenImage):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webInspectorShowWindow):
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(sizeWebViewForCurrentTest):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::open):
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
* DumpRenderTree/win/DumpRenderTree.cpp:
(sizeWebViewForCurrentTest):
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):
2013-04-24 Byungwoo Lee <bw80.lee@samsung.com>
[EFL] Fix build error after r148963.
https://bugs.webkit.org/show_bug.cgi?id=115126
Reviewed by Laszlo Gombos.
Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
* TestWebKitAPI/PlatformEfl.cmake:
2013-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Use stamp files for generate-forwarding-headers makefile rules
https://bugs.webkit.org/show_bug.cgi?id=115118
Reviewed by Martin Robinson.
Use a stamp file for the TestWebKitAPI and WebKitTestRunner
forwarding generator rules and don't call it for soup since there
aren't soup directories in TestWebKitAPI and WebKitTestRunner.
* TestWebKitAPI/GNUmakefile.am:
* WebKitTestRunner/GNUmakefile.am:
2013-04-24 Simon Pena <simon.pena@samsung.com>
[GTK] Update build dependencies
https://bugs.webkit.org/show_bug.cgi?id=115111
Reviewed by Martin Robinson.
The install-dependencies script was missing a dependency on EGL,
which is expected when building Cairo.
* gtk/install-dependencies: Added a dependency on libegl1-mesa
for both apt and yum.
2013-04-24 Seokju Kwon <seokju.kwon@gmail.com>
Remove the Chromium-specific helper from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=114996
Reviewed by Dirk Pranke.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
2013-04-24 Sergio Correia <sergio.correia@openbossa.org>
[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
https://bugs.webkit.org/show_bug.cgi?id=114850
Reviewed by Andreas Kling.
Revision r148312 fixed WebPageProxy cleanup and also changed the process
termination semantics when requested by the user so that a client is not
notified of a crash anymore, since there was no crash anyway.
That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
relied on being notified of a crash after calling WKPageTerminate(). As
a result of not being notified of such non-existent crash, the test would
timeout right after making the terminate call.
This patch adds an InjectedBundle to be used for simulating a crash, by
calling abort() upon receiving a "Crash" message, and thus we are able to
keep testing the crash callback.
This patch also re-enables the WKViewClientWebProcessCallbacks test, which
had been disabled in revisions r148858 and r148855, since it was failing.
* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
(TestWebKitAPI):
(WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
2013-04-24 Christophe Dumez <ch.dumez@sisa.samsung.com>
[EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
https://bugs.webkit.org/show_bug.cgi?id=115095
Reviewed by Antonio Gomes.
Use different subfolders under DumpRenderTree Temp folder for every
functionality (icon database, cache, localstorage, ...). This makes
sure there is no conflict between the functionalities.
In EFL's case, libsoup cache was causing problems for the icon
database if sharing the same folder.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
== Rolled over to ChangeLog-2013-04-24 ==