Google Git
Sign in
chromium / external / coreboot.org / flashrom / 4eef651ff503f81b778e5af0ed78354e0dec0dd7
commit4eef651ff503f81b778e5af0ed78354e0dec0dd7[log] [tgz]
authorEdward O'Callaghan <quasisec@google.com>Wed Feb 03 00:19:41 2021
committerEdward O'Callaghan <quasisec@chromium.org>Fri May 07 02:10:48 2021
treea27e5569e594843a4cfea135d557ca4a880adf02
parent1a9441f7487aea5b2a03e6aa88157261c5c2ba9b [diff]
programmer.h: Convert anon union to anon struct

Convert the anon union of registered masters in the mst
field of the flashctx to a anon struct. If we are going
to dereference a pointer there in an undefined way we
should crash and not plow ahead with invalid memory.

The user of the registered_masters type is therefore
responsible for querying the buses_supported field before
attempting to dereference a ptr field in the anon struct.

BUG=b:175849641
TEST=`flashrom -p internal --flash-name`

Change-Id: I576967a8599b923c902e39f177f39146291cc242
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/50246
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Sam McNally <sammc@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
4 files changed
tree: a27e5569e594843a4cfea135d557ca4a880adf02
  1. Documentation/
  2. subprojects/
  3. tests/
  4. util/
  5. .gitattributes
  6. .gitignore
  7. 82802ab.c
  8. amd_imc.c
  9. archtest.c
  10. at45db.c
  11. atahpt.c
  12. atapromise.c
  13. atavia.c
  14. bitbang_spi.c
  15. board_enable.c
  16. buspirate_spi.c
  17. cbtable.c
  18. ch341a_spi.c
  19. chipdrivers.h
  20. chipset_enable.c
  21. cli_classic.c
  22. cli_common.c
  23. cli_output.c
  24. COPYING
  25. coreboot_tables.h
  26. custom_baud.c
  27. custom_baud.h
  28. dediprog.c
  29. developerbox_spi.c
  30. digilent_spi.c
  31. dmi.c
  32. Doxyfile
  33. drkaiser.c
  34. dummyflasher.c
  35. edi.c
  36. edi.h
  37. en29lv640b.c
  38. endiantest.c
  39. ene.h
  40. ene_lpc.c
  41. flash.h
  42. flashchips.c
  43. flashchips.h
  44. flashrom.8.tmpl
  45. flashrom.c
  46. fmap.c
  47. fmap.h
  48. ft2232_spi.c
  49. gfxnvidia.c
  50. helpers.c
  51. hwaccess.c
  52. hwaccess.h
  53. hwaccess_x86_io.h
  54. i2c_helper.h
  55. i2c_helper_linux.c
  56. ich_descriptors.c
  57. ich_descriptors.h
  58. ichspi.c
  59. internal.c
  60. it8212.c
  61. it85spi.c
  62. it87spi.c
  63. jedec.c
  64. jlink_spi.c
  65. layout.c
  66. layout.h
  67. libflashrom.c
  68. libflashrom.h
  69. libflashrom.map
  70. linux_mtd.c
  71. linux_spi.c
  72. lspcon_i2c_spi.c
  73. Makefile
  74. mcp6x_spi.c
  75. mec1308.c
  76. meson.build
  77. meson_options.txt
  78. mstarddc_spi.c
  79. ni845x_spi.c
  80. nic3com.c
  81. nicintel.c
  82. nicintel_eeprom.c
  83. nicintel_spi.c
  84. nicnatsemi.c
  85. nicrealtek.c
  86. ogp_spi.c
  87. opaque.c
  88. os.h
  89. pcidev.c
  90. physmap.c
  91. pickit2_spi.c
  92. platform.h
  93. pony_spi.c
  94. print.c
  95. print_wiki.c
  96. processor_enable.c
  97. programmer.c
  98. programmer.h
  99. raiden_debug_spi.c
  100. rayer_spi.c
  101. README
  102. realtek_mst_i2c_spi.c
  103. s25f.c
  104. satamv.c
  105. satasii.c
  106. sb600spi.c
  107. serial.c
  108. serprog.c
  109. serprog.h
  110. sfdp.c
  111. spi.c
  112. spi.h
  113. spi25.c
  114. spi25_statusreg.c
  115. spi95.c
  116. sst28sf040.c
  117. sst49lfxxxc.c
  118. sst_fwhub.c
  119. stlinkv3_spi.c
  120. stm50.c
  121. test_build.sh
  122. udelay.c
  123. unittest_env.h
  124. usb_device.c
  125. usb_device.h
  126. usbblaster_spi.c
  127. usbdev.c
  128. w29ee011.c
  129. w39.c
  130. wbsio_spi.c
  131. writeprotect.c
  132. writeprotect.h