| 2016-09-28 Carlos Garcia Campos <cgarcia@igalia.com> |
| |
| [GTK] Switch to use GMenu internally in the context menu implementation |
| https://bugs.webkit.org/show_bug.cgi?id=162603 |
| |
| Reviewed by Michael Catanzaro. |
| |
| Switch to use GAction instead of GtkAction internally, but still keeping a GtkAction associated to the GAction, |
| because our API depends on GtkAction. |
| |
| * Shared/gtk/WebContextMenuItemGtk.cpp: |
| (WebKit::WebContextMenuItemGtk::WebContextMenuItemGtk): |
| (WebKit::WebContextMenuItemGtk::createActionIfNeeded): Create the GAction and the associated GtkAction. Ensure a |
| unique name for the GAction, since the name now matters. |
| * Shared/gtk/WebContextMenuItemGtk.h: |
| (WebKit::WebContextMenuItemGtk::gtkAction): |
| (WebKit::WebContextMenuItemGtk::gAction): |
| (WebKit::WebContextMenuItemGtk::submenuItems): Deleted. |
| * UIProcess/gtk/WebContextMenuProxyGtk.cpp: |
| (WebKit::contextMenuItemActivatedCallback): Use the GAction. |
| (WebKit::WebContextMenuProxyGtk::append): Create a new GMenuItem for the GAction. |
| (WebKit::WebContextMenuProxyGtk::buildMenu): Build a GMenu for the given items. |
| (WebKit::WebContextMenuProxyGtk::populate): Create a GMenu and bind it ot the GtkMenu. |
| (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Create the GActionGroup for the menu. |
| (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Remove the action group from the GtkMenu. |
| * UIProcess/gtk/WebContextMenuProxyGtk.h: |
| |
| 2016-09-27 Daniel Bates <dabates@apple.com> |
| |
| NetworkLoad and PingLoad should use private inheritance |
| https://bugs.webkit.org/show_bug.cgi?id=162649 |
| |
| Reviewed by Alex Christensen. |
| |
| Make NetworkLoad privately inherit from NetworkDataTaskClient and ResourceHandleClient, |
| and make the client callbacks from these interfaces private as this class implements |
| these interfaces. |
| |
| Similarly, make PingLoad privately inherit from ResourceHandleClient. |
| |
| * NetworkProcess/NetworkLoad.h: |
| * NetworkProcess/PingLoad.h: |
| |
| 2016-09-20 Anders Carlsson <andersca@apple.com> |
| |
| PlatformEvent::m_modifiers should be an OptionSet |
| https://bugs.webkit.org/show_bug.cgi?id=162326 |
| |
| Reviewed by Daniel Bates. |
| |
| * Shared/WebEventConversion.cpp: |
| (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): |
| (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): |
| (WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): |
| (WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent): |
| |
| 2016-09-27 Dan Bernstein <mitz@apple.com> |
| |
| [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter |
| https://bugs.webkit.org/show_bug.cgi?id=162577 |
| <rdar://problem/28481984> |
| |
| Reviewed by Simon Fraser. |
| |
| * UIProcess/API/Cocoa/WKWebView.mm: |
| (-[WKWebView _uiTextSelectionRectViews]): Added this method in the WKTesting category, which |
| uses UIKit internals to get the views used for the selection highlight. |
| * UIProcess/API/Cocoa/WKWebViewPrivate.h: |
| |
| * UIProcess/ios/WKContentViewInteraction.mm: |
| (-[WKContentView _selectionClipRect]): When selection is not confined to a form control or |
| content-editable element, return the null rect to indicate no clipping, rather than |
| clipping to the empty rect at the origin. |
| |
| 2016-09-27 Jer Noble <jer.noble@apple.com> |
| |
| Remove deprecated ENCRYPTED_MEDIA implementation. |
| https://bugs.webkit.org/show_bug.cgi?id=161010 |
| |
| Reviewed by Eric Carlson. |
| |
| Remove ENABLE_ENCRYPTED_MEDIA. |
| |
| * Configurations/FeatureDefines.xcconfig: |
| |
| 2016-09-27 Chris Dumez <cdumez@apple.com> |
| |
| [WK2] Navigating to a Blob URL does not trigger a download |
| https://bugs.webkit.org/show_bug.cgi?id=162574 |
| |
| Reviewed by Darin Adler. |
| |
| Add support for converting Blob URL loads into downloads. |
| |
| * NetworkProcess/Downloads/BlobDownloadClient.cpp: |
| (WebKit::BlobDownloadClient::didReceiveResponseAsync): |
| Make sure we return a valid suggested filename because the client side (Safari) |
| does not deal with empty suggested filenames. Use "unknown" by default to |
| match the default suggested filename of non-Blob downloads. |
| |
| * NetworkProcess/Downloads/Download.cpp: |
| (WebKit::Download::startWithHandle): |
| * NetworkProcess/Downloads/Download.h: |
| * NetworkProcess/Downloads/DownloadManager.cpp: |
| (WebKit::DownloadManager::convertHandleToDownload): |
| * NetworkProcess/Downloads/DownloadManager.h: |
| * NetworkProcess/Downloads/ios/DownloadIOS.mm: |
| (WebKit::Download::startNetworkLoadWithHandle): |
| * NetworkProcess/Downloads/mac/DownloadMac.mm: |
| (WebKit::Download::startNetworkLoadWithHandle): |
| * NetworkProcess/Downloads/soup/DownloadSoup.cpp: |
| (WebKit::Download::startNetworkLoadWithHandle): |
| * NetworkProcess/NetworkConnectionToWebProcess.cpp: |
| (WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): |
| * NetworkProcess/NetworkLoad.h: |
| (WebKit::NetworkLoad::handle): |
| |
| 2016-09-27 Michael Catanzaro <mcatanzaro@igalia.com> |
| |
| [GTK] Unreviewed typo fix |
| |
| * UIProcess/API/gtk/WebKitWebInspector.cpp: |
| (webkit_web_inspector_class_init): |
| |
| 2016-09-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> |
| |
| [GTK] Should check whether GDK can use GL before asking it to |
| https://bugs.webkit.org/show_bug.cgi?id=162598 |
| |
| Reviewed by Michael Catanzaro. |
| |
| gdk_cairo_draw_from_gl can fail even when WebKit itself has been able to use GL (its |
| context creation code might be buggy, GL may have been disabled using GDK_GL=disable, …). |
| Unfortunately it does not have any error reporting other than a warning printed to |
| stderr, so we cannot fallback from it. We have to first check if GL can be used by GDK |
| by trying to create a context. |
| |
| See https://bugzilla.redhat.com/show_bug.cgi?id=1378987 |
| |
| * UIProcess/gtk/AcceleratedBackingStoreWayland.cpp: |
| (WebKit::AcceleratedBackingStoreWayland::canGdkUseGL): decide whether GDK can use GL by |
| trying to create a context for a GdkWindow. |
| (WebKit::AcceleratedBackingStoreWayland::paint): fallback to glReadPixels if GDK cannot |
| use GL. |
| * UIProcess/gtk/AcceleratedBackingStoreWayland.h: |
| |
| 2016-09-26 Tim Horton <timothy_horton@apple.com> |
| |
| Delete some unused code from r202695 |
| https://bugs.webkit.org/show_bug.cgi?id=162595 |
| <rdar://problem/28343784> |
| |
| Reviewed by Dan Bernstein. |
| |
| * UIProcess/API/Cocoa/WKWebView.mm: |
| (-[WKWebView _initializeWithConfiguration:]): |
| (-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]): Deleted. |
| (-[WKWebView _didFirstVisuallyNonEmptyLayoutForMainFrame]): Deleted. |
| * UIProcess/API/Cocoa/WKWebViewInternal.h: |
| * UIProcess/ios/PageClientImplIOS.mm: |
| (WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame): |
| We didn't end up needing this mechanism. |
| |
| 2016-09-26 Dan Bernstein <mitz@apple.com> |
| |
| -_webViewWebProcessDidBecomeUnresponsive: gets called when the Web process is stopped in the debugger |
| https://bugs.webkit.org/show_bug.cgi?id=162234 |
| |
| Reviewed by Sam Weinig. |
| |
| * UIProcess/Cocoa/WebProcessProxyCocoa.mm: |
| (WebKit::WebProcessProxy::platformIsBeingDebugged): Use the KERN_PROC sysctl to get the |
| process flags and check for P_TRACED. |
| |
| * UIProcess/ResponsivenessTimer.cpp: |
| (WebKit::ResponsivenessTimer::timerFired): Call the new client function |
| mayBecomeUnresponsive. If it returns false, restart the timer and bail out without |
| changing the responsiveness state. |
| |
| * UIProcess/ResponsivenessTimer.h: Declared new client function mayBecomeUnresponsive. |
| |
| * UIProcess/WebProcessProxy.cpp: |
| (WebKit::WebProcessProxy::platformIsBeingDebugged): A generic implementation that always |
| returns false. |
| (WebKit::WebProcessProxy::mayBecomeUnresponsive): Implement this new |
| ResponsivenessTimer::Client function to return true unless the process is being debugged. |
| * UIProcess/WebProcessProxy.h: |
| |
| 2016-09-26 Chris Dumez <cdumez@apple.com> |
| |
| [WK2] BlobDownloadClient should use asynchronous IPC to decide destination path |
| https://bugs.webkit.org/show_bug.cgi?id=162568 |
| |
| Reviewed by Alex Christensen. |
| |
| Use DecideDestinationWithSuggestedFilenameAsync IPC to decide the destination |
| path in the case of Blob downloads, instead of the synchronous alternative. |
| To achieve this, BlobResourceHandle was updated in WebCore to properly support |
| asynchronous callback and BlobDownloadClient was updated to use asynchronous |
| callbacks. When BlobDownloadClient::didReceiveResponseAsync() is called, we |
| now ask the WebContent process asynchronously to decide what the destination |
| path should be. Then, when we later get the destination path back from the |
| WebContent process, we create the file on disk and call |
| continueDidReceiveResponse() on the BlobResourceHandle so we start getting the |
| blob data to write. |
| |
| * NetworkProcess/Downloads/BlobDownloadClient.cpp: |
| (WebKit::BlobDownloadClient::didReceiveResponseAsync): |
| (WebKit::BlobDownloadClient::didDecideDownloadDestination): |
| * NetworkProcess/Downloads/BlobDownloadClient.h: |
| * NetworkProcess/Downloads/Download.cpp: |
| (WebKit::Download::decideDestinationWithSuggestedFilenameAsync): |
| (WebKit::Download::didDecideDownloadDestination): |
| (WebKit::Download::continueDidReceiveResponse): |
| (WebKit::Download::decideDestinationWithSuggestedFilename): Deleted. |
| * NetworkProcess/Downloads/Download.h: |
| * NetworkProcess/Downloads/DownloadManager.cpp: |
| (WebKit::DownloadManager::willDecidePendingDownloadDestination): |
| (WebKit::DownloadManager::continueDecidePendingDownloadDestination): |
| (WebKit::DownloadManager::convertHandleToDownload): Deleted. |
| * NetworkProcess/Downloads/DownloadManager.h: |
| * NetworkProcess/NetworkLoad.cpp: |
| (WebKit::NetworkLoad::continueDidReceiveResponse): |
| * NetworkProcess/NetworkProcess.cpp: |
| (WebKit::NetworkProcess::continueDecidePendingDownloadDestination): |
| * NetworkProcess/NetworkProcess.h: |
| * NetworkProcess/NetworkProcess.messages.in: |
| * UIProcess/Downloads/DownloadProxy.cpp: |
| (WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync): Deleted. |
| * UIProcess/Downloads/DownloadProxy.h: |
| * UIProcess/Downloads/DownloadProxy.messages.in: |
| |
| 2016-09-26 Daniel Bates <dabates@apple.com> |
| |
| Mark Ping{Handle, Load} as final |
| https://bugs.webkit.org/show_bug.cgi?id=162576 |
| |
| Reviewed by Alex Christensen. |
| |
| We should not support subclassing of a ping handle or overriding its NetworkDataTaskClient |
| callbacks because there are security/privacy implications with a ping request. We should |
| not encourage subclassing without careful consideration. |
| |
| * NetworkProcess/PingLoad.h: |
| |
| 2016-09-26 Daniel Bates <dabates@apple.com> |
| |
| Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING |
| https://bugs.webkit.org/show_bug.cgi?id=162365 |
| |
| Reviewed by Simon Fraser. |
| |
| * Configurations/FeatureDefines.xcconfig: |
| * WebProcess/WebPage/WebPage.cpp: |
| (WebKit::WebPage::updatePreferences): |
| |
| 2016-09-26 Michael Catanzaro <mcatanzaro@igalia.com> |
| |
| Fix -Wformat warnings in WebLoaderStrategy |
| https://bugs.webkit.org/show_bug.cgi?id=162553 |
| |
| Reviewed by Alex Christensen. |
| |
| Consistently use PRIu64 to print uint64_t |
| |
| * NetworkProcess/Downloads/Download.cpp: |
| (WebKit::Download::didReceiveResponse): |
| (WebKit::Download::didReceiveData): |
| (WebKit::Download::didFinish): |
| (WebKit::Download::didFail): |
| (WebKit::Download::didCancel): |
| * NetworkProcess/NetworkResourceLoader.cpp: |
| (WebKit::NetworkResourceLoader::start): |
| (WebKit::NetworkResourceLoader::startNetworkLoad): |
| (WebKit::NetworkResourceLoader::setDefersLoading): |
| (WebKit::NetworkResourceLoader::abort): |
| (WebKit::NetworkResourceLoader::didReceiveBuffer): |
| (WebKit::NetworkResourceLoader::didFinishLoading): |
| (WebKit::NetworkResourceLoader::didFailLoading): |
| (WebKit::NetworkResourceLoader::continueWillSendRequest): |
| * WebProcess/Network/WebLoaderStrategy.cpp: |
| (WebKit::WebLoaderStrategy::scheduleLoad): |
| * WebProcess/Network/WebResourceLoader.cpp: |
| (WebKit::WebResourceLoader::willSendRequest): |
| (WebKit::WebResourceLoader::didReceiveResponse): |
| (WebKit::WebResourceLoader::didReceiveData): |
| (WebKit::WebResourceLoader::didFinishResourceLoad): |
| (WebKit::WebResourceLoader::didFailResourceLoad): |
| (WebKit::WebResourceLoader::didReceiveResource): |
| |
| == Rolled over to ChangeLog-2016-09-26 == |
