commit 74f3d07ab0bcfd63f42f62b26eeb6ce68efd4f21
author Charles Harris <charlesr.harris@gmail.com> Mon Jan 21 00:23:47 2019
committer GitHub <noreply@github.com> Mon Jan 21 00:23:47 2019
tree 7e935ff2140ef91c08148a1d3d1d5e5a9eb5ba93
parent 70b773e4015b4fbb61bc1f7bdffc9cc789d58e94
parent 8cecce5514b9e290bd65a3c51463e03b7702760a

Merge pull request #12814 from mattip/resolve-writeback

BUG: resolve writeback in arr_insert failure paths

numpy/core/src/multiarray/compiled_base.c

diff --git a/numpy/core/src/multiarray/compiled_base.c b/numpy/core/src/multiarray/compiled_base.c
index 88924a8..625028b 100644
--- a/numpy/core/src/multiarray/compiled_base.c
+++ b/numpy/core/src/multiarray/compiled_base.c
@@ -328,6 +328,7 @@
         } else {
             Py_XDECREF(values);
             Py_XDECREF(mask);
+            PyArray_ResolveWritebackIfCopy(array);
             Py_XDECREF(array);
             Py_RETURN_NONE;
         }
@@ -358,6 +359,7 @@
 
  fail:
     Py_XDECREF(mask);
+    PyArray_ResolveWritebackIfCopy(array);
     Py_XDECREF(array);
     Py_XDECREF(values);
     return NULL;

numpy/core/tests/test_multiarray.py

diff --git a/numpy/core/tests/test_multiarray.py b/numpy/core/tests/test_multiarray.py
index 77534c1..241f8e4 100644
--- a/numpy/core/tests/test_multiarray.py
+++ b/numpy/core/tests/test_multiarray.py
@@ -7729,6 +7729,8 @@
         # uses arr_insert
         np.place(a, a>2, [44, 55])
         assert_equal(a, np.array([[0, 44], [1, 55], [2, 44]]))
+        # hit one of the failing paths
+        assert_raises(ValueError, np.place, a, a>20, [])
 
     def test_put_noncontiguous(self):
         a = np.arange(6).reshape(2,3).T # force non-c-contiguous