Fix steps and update for 6.8
diff --git a/Getting-Started-with-Embedding.md b/Getting-Started-with-Embedding.md
index 0698a8a..3995ab2 100644
--- a/Getting-Started-with-Embedding.md
+++ b/Getting-Started-with-Embedding.md
@@ -6,10 +6,11 @@
# Hello World
-Let's look at a [Hello World example](https://chromium.googlesource.com/v8/v8/+/branch-heads/5.8/samples/hello-world.cc) that takes a JavaScript statement as a string argument, executes it as JavaScript code, and prints the result to standard out.
+Let's look at a [Hello World example](https://chromium.googlesource.com/v8/v8/+/branch-heads/6.8/samples/hello-world.cc) that takes a JavaScript statement as a string argument, executes it as JavaScript code, and prints the result to standard out.
+First, some key concepts you will need:
- An isolate is a VM instance with its own heap.
-- A local handle is a pointer to an object. All V8 objects are accessed using handles, they are necessary because of the way the V8 garbage collector works.
+- A local handle is a pointer to an object. All V8 objects are accessed using handles. They are necessary because of the way the V8 garbage collector works.
- A handle scope can be thought of as a container for any number of handles. When you've finished with your handles, instead of deleting each one individually you can simply delete their scope.
- A context is an execution environment that allows separate, unrelated, JavaScript code to run in a single instance of V8. You must explicitly specify the context in which you want any JavaScript code to be run.
@@ -20,9 +21,16 @@
Follow the steps below to run the example yourself:
1. Download the V8 source code by following the [[git|Using-Git]] instructions.
-1. This hello world example is compatible with version 5.8. You can check out this branch with `git checkout -b 5.8 -t branch-heads/5.8`
+1. This hello world example is compatible with version 6.8. You can check out this branch with `git checkout -b 6.8 -t branch-heads/6.8`
1. Create a build configuration using the helper script: `tools/dev/v8gen.py x64.release`
-1. Edit the default build configuration by running `gn args out.gn/x64.release`. Add two lines to your configuration: `is_component_build = false` and `v8_static_library = true`.
+1. Edit the default build configuration by running `gn args out.gn/x64.release`. Add these lines to your configuration:
+
+ ```
+ is_component_build = false
+ v8_static_library = true
+ use_custom_libcxx = false
+ use_custom_libcxx_for_host = false
+ ```
1. Build via `ninja -C out.gn/x64.release` on a Linux x64 system to generate the correct binaries.
1. Compile `hello-world.cc`, linking to the static libraries created in the build process. For example, on 64bit Linux using the GNU compiler:
@@ -36,7 +44,7 @@
`cp out.gn/x64.release/*.bin .`
1. For more complex code, V8 will fail without an ICU data file. Copy this file as well: `cp out.gn/x64.release/icudtl.dat .`
1. Run the `hello_world` executable file at the command line.
-For example, on Linux, still in the V8 directory, type the following at the command line:
+e.g. On Linux, in the V8 directory, run:
`./hello_world`
1. You will see `Hello, World!`.
