commit f055ce7eb893cd0d17ebcfd4125018f46f983aff
author Stephane Sezer <sas@cd80.net> Mon Aug 06 22:04:08 2018
committer Stephane Sezer <sas@cd80.net> Mon Aug 06 22:04:08 2018
tree a6419ef626733ea167a2ed7b2bd5f2e8b0c409a8
parent dfaba774eb65efcfc9c1d32d2b64447b29104fe3

Add a relocation for R_AARCH64_ABS32 in ObjectFileELF

Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently, the switch case
that iterates over the relocation type is only implemented for a few
different types and `assert(false)`es over the rest.

Implement the relocation for R_AARCH64_ABS32 in ApplyRelocations

Reviewers: sas, xiaobai, peter.smith, clayborg, javed.absar, espindola

Differential Revision: https://reviews.llvm.org/D49407

Change by Nathan Lanza <lanza@fb.com>

git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@339068 91177308-0d34-0410-b5e6-96231b3b80d8

source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

diff --git a/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
index 8701908..1ec003a 100644
--- a/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ b/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -2697,15 +2697,20 @@
         break;
       }
       case R_X86_64_32:
-      case R_X86_64_32S: {
+      case R_X86_64_32S:
+      case R_AARCH64_ABS32: {
         symbol = symtab->FindSymbolByID(reloc_symbol(rel));
         if (symbol) {
           addr_t value = symbol->GetAddressRef().GetFileAddress();
           value += ELFRelocation::RelocAddend32(rel);
-          assert(
-              (reloc_type(rel) == R_X86_64_32 && (value <= UINT32_MAX)) ||
-              (reloc_type(rel) == R_X86_64_32S &&
-               ((int64_t)value <= INT32_MAX && (int64_t)value >= INT32_MIN)));
+          if (!((IsRelocABS32(rel) && value <= UINT32_MAX) ||
+                (reloc_type(rel) == R_X86_64_32S &&
+                 ((int64_t)value <= INT32_MAX &&
+                  (int64_t)value >= INT32_MIN)))) {
+            Log *log =
+                lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_MODULES);
+            log->Printf("Failed to apply debug info relocations");
+          }
           uint32_t truncated_addr = (value & 0xFFFFFFFF);
           DataBufferSP &data_buffer_sp = debug_data.GetSharedDataBuffer();
           uint32_t *dst = reinterpret_cast<uint32_t *>(