[BreakoutBox] Remove control signals
The MediaStreamTrackSignal WebIDL dictionary should be removed in a
follow-up CL.
Not removed in this CL to avoid crbug.com/1231462 which lead to a
revert of a previous version of this CL (https://crrev.com/c/3039183).
Bug: 1231028,1231462
Change-Id: I9cb13798602b6a8440d84031d31da512d64a4b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041455
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Tony Herre <toprice@chromium.org>
Cr-Commit-Position: refs/heads/master@{#904207}
diff --git a/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html b/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html
index df83e7e..43d8cb2 100644
--- a/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html
+++ b/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html
@@ -52,23 +52,6 @@
}, "Tests that creating a Audio MediaStreamTrackGenerator works as expected");
promise_test(async t => {
- const capturedStream = await navigator.mediaDevices.getUserMedia({ audio: true });
- assert_equals(capturedStream.getAudioTracks().length, 1);
- const upstreamTrack = capturedStream.getAudioTracks()[0];
- t.add_cleanup(() => upstreamTrack.stop());
-
- const generator = new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "audio" });
- t.add_cleanup(() => generator.stop());
-
- const writer = generator.writable.getWriter();
- const data = makeAudioData(1);
- await writer.write(data);
-
- assert_equals(generator.kind, "audio");
- assert_equals(generator.readyState, "live");
- }, "Tests that creating an Audio MediaStreamTrackGenerator with a signal target works as expected");
-
- promise_test(async t => {
assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ kind: "invalid kind" }) });
}, "Creating Generator with an invalid kind throws");
@@ -78,23 +61,10 @@
const upstreamTrack = capturedStream.getAudioTracks()[0];
t.add_cleanup(() => upstreamTrack.stop());
- assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: upstreamTrack }) });
+ assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator() });
}, "Creating Generator with a missing kind throws");
promise_test(async t => {
- const capturedStream = await navigator.mediaDevices.getUserMedia({ audio: true });
- assert_equals(capturedStream.getAudioTracks().length, 1);
- const upstreamTrack = capturedStream.getAudioTracks()[0];
- t.add_cleanup(() => upstreamTrack.stop());
-
- assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "video" }) });
- }, "Creating Generator with mismatched kinds throws");
-
- promise_test(async t => {
- assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: "IamNotATrack" }) });
- }, "Creating Generator with invalid signalTarget throws");
-
- promise_test(async t => {
const generator = new MediaStreamTrackGenerator({ kind: "video" });
t.add_cleanup(() => generator.stop());
diff --git a/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html b/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html
index 1185630..becf008 100644
--- a/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html
+++ b/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html
@@ -198,24 +198,6 @@
}, "Tests that VideoFrames are destroyed on write.");
promise_test(async t => {
- const capturedStream = await navigator.mediaDevices.getUserMedia({ video: true });
- assert_equals(capturedStream.getVideoTracks().length, 1);
- const upstreamTrack = capturedStream.getVideoTracks()[0];
- t.add_cleanup(() => upstreamTrack.stop());
-
- const generator = new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "video" });
- t.add_cleanup(() => generator.stop());
-
- const writer = generator.writable.getWriter();
- const frame = makeVideoFrame(1);
- await writer.write(frame);
-
- assert_equals(generator.kind, "video");
- assert_equals(generator.readyState, "live");
- }, "Tests that creating a Video MediaStreamTrackGenerator with a signal target works as expected");
-
-
- promise_test(async t => {
const generator = new MediaStreamTrackGenerator("audio");
t.add_cleanup(() => generator.stop());
