| commit | 7915bc605347950da0a0af3707a788048a08ff3c | [log] [tgz] |
|---|---|---|
| author | Joey Arhar <jarhar@chromium.org> | Wed Jan 12 19:27:31 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jan 12 19:39:01 2022 |
| tree | e5bf2be897bf76f14896542869b78fb63b0950d6 | |
| parent | e4dbb9113928274d8f5ad7cac8c80893b5e9433c [diff] |
Fix modal-dialog-scroll-height.html This test is failing in all browsers on wpt.fyi due to the hard coded height: https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html I'm not sure why it passes in the chromium test infrastructure, but people want to remove it: https://github.com/web-platform-tests/interop-2022/issues/12#issuecomment-1009154280 This patch replaces the hard coded height with window.innerHeight. Change-Id: If27a4b07ca235190d19cbe2f52bbfe6dd2594225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379191 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/main@{#958207}
diff --git a/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html b/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html index 2169e5d..638217f 100644 --- a/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html +++ b/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html
@@ -27,6 +27,6 @@ <script> test(() => { document.querySelector('dialog').showModal(); - assert_equals(document.scrollingElement.scrollHeight, 600); + assert_equals(document.scrollingElement.scrollHeight, window.innerHeight); }, 'dialogs should be centered before computing overflow.'); </script>