Avoid overflowing snap areas in scrollTo wpt tests
Some tests in scrollTo-scrollBy-snaps.html are failing on wpt dashboard.
This is caused by the uncertainty of the window size for testharness
tests. If the window size becomes small enough that the snap area covers
the snapport, the expected snap position is ignored because any scroll
position is considered a valid snap position. This patch changes the
landing position of scrollTo and scrollBy for failing cases so that the
snap area does not cover ths snapport regardless of the window size.
More specifically, the snap area's vertical and horizontal dimensions
are 600px each thus covering the [1000, 1600] range with expected snap
position at 1000. Previously if the test vertically scrolled to 1200 and
the window's size is smaller than 400, the snap area will cover the
window. Now the test scrolls to 900 (100px before the snap position),
ensuring that the target snap area won't cover the window regardless of
the size.
Bug: 876052
Change-Id: I448ecb1e3cc2cc458d467472ca38d49bf01d2901
Reviewed-on: https://chromium-review.googlesource.com/1182299
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585926}
diff --git a/css/css-scroll-snap/scrollTo-scrollBy-snaps.html b/css/css-scroll-snap/scrollTo-scrollBy-snaps.html
index 58807a6..3e022f0 100644
--- a/css/css-scroll-snap/scrollTo-scrollBy-snaps.html
+++ b/css/css-scroll-snap/scrollTo-scrollBy-snaps.html
@@ -73,8 +73,8 @@
var viewport = document.scrollingElement;
[
[{left: 800}, 1000, 0],
- [{top: 1200}, 0, 1000],
- [{left: 1200, top: 800}, 1000, 1000]
+ [{top: 900}, 0, 1000],
+ [{left: 900, top: 800}, 1000, 1000]
].forEach(([input, expectedX, expectedY]) => {
test(() => {
divScroller.scrollTo(0, 0);
