Fixing web platform tests for PeerConnection.setRemoteDescription().
Tests for PeerConnection.setRemoteDescription() did not call
setLocalDescription() on the caller object after creating the offer.
When the local description is not set, the PeerConnection can generate new MIDs
for the existing media sections. This caused tests to fail because the offer
was set on the callee causing the MIDs (and therefore media sections) not to
match.
Bug: None.
Change-Id: I67e98e5abf76a97ab57fc0427672313b44f9c258
Reviewed-on: https://chromium-review.googlesource.com/c/1396854
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Amit Hilbuch <amithi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620378}
diff --git a/webrtc/RTCPeerConnection-setRemoteDescription.html b/webrtc/RTCPeerConnection-setRemoteDescription.html
index 182abea..464e16d 100644
--- a/webrtc/RTCPeerConnection-setRemoteDescription.html
+++ b/webrtc/RTCPeerConnection-setRemoteDescription.html
@@ -96,10 +96,9 @@
await pc.setLocalDescription(offer);
assert_state('have-local-offer');
await pc2.setRemoteDescription(offer);
- await pc2.setLocalDescription(await pc2.createAnswer());
- await pc.setRemoteDescription(pc2.localDescription);
+ await exchangeAnswer(pc, pc2);
assert_state('stable');
- await pc.setRemoteDescription(await pc2.createOffer());
+ await exchangeOffer(pc2, pc);
assert_state('have-remote-offer');
}, 'Negotiation should fire signalingsstate events');
@@ -112,9 +111,11 @@
t.add_cleanup(() => pc2.close());
const offer1 = await generateAudioReceiveOnlyOffer(pc2);
+ await pc2.setLocalDescription(offer1);
await pc.setRemoteDescription(offer1);
- await pc.setLocalDescription(await pc.createAnswer());
+ await exchangeAnswer(pc2, pc);
const offer2 = await generateVideoReceiveOnlyOffer(pc2);
+ await pc2.setLocalDescription(offer2);
await pc.setRemoteDescription(offer2);
assert_session_desc_not_similar(offer1, offer2);
assert_session_desc_similar(pc.remoteDescription, offer2);
@@ -134,7 +135,7 @@
const answer = await pc2.createAnswer();
await pc2.setLocalDescription(answer);
await pc.setRemoteDescription(answer);
- await pc.setRemoteDescription(await pc2.createOffer());
+ await exchangeOffer(pc2, pc);
assert_equals(pc.remoteDescription.sdp, pc.pendingRemoteDescription.sdp);
assert_session_desc_similar(pc.remoteDescription, offer);
assert_session_desc_similar(pc.currentRemoteDescription, answer);
