Do not clamp computed width and height by min-/max- values.
The spec says that when there's no box or the property doesn't apply, the
computed value should be returned.
That's not what we're doing right now, we're clamping by min-/max- values, which
is wrong.
This patch makes us match other engines and the spec, and it's an attempt to get
interop on resolved values in:
https://github.com/w3c/csswg-drafts/issues/3678
WebKit fails the WPT test, but due to a different reason:
https://bugs.webkit.org/show_bug.cgi?id=197814
Differential Revision: https://phabricator.services.mozilla.com/D30780
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1527392
gecko-commit: d51f3432e142ef24333b125087f5fccc2fbc366a
gecko-integration-branch: central
gecko-reviewers: mats
diff --git a/css/cssom/getComputedStyle-resolved-min-max-clamping.html b/css/cssom/getComputedStyle-resolved-min-max-clamping.html
new file mode 100644
index 0000000..e630377
--- /dev/null
+++ b/css/cssom/getComputedStyle-resolved-min-max-clamping.html
@@ -0,0 +1,38 @@
+<!doctype html>
+<meta charset="utf-8">
+<title>CSSOM: resolved values of the width and height when the element generates no box or are a non-replaced inline aren't clamped by min-width / max-width</title>
+<link rel="help" href="https://drafts.csswg.org/cssom/#resolved-value">
+<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
+<link rel="author" title="Mozilla" href="https://mozilla.org">
+<script src=/resources/testharness.js></script>
+<script src=/resources/testharnessreport.js></script>
+<span id="non-replaced-inline"></span>
+<div id="display-none" style="display: none"></div>
+<div id="display-contents" style="display: contents"></div>
+<script>
+test(function() {
+ for (const e of document.querySelectorAll("[id]")) {
+ const cs = getComputedStyle(e);
+ for (const prop of ["width", "height"]) {
+ e.style.setProperty("min-" + prop, "10px");
+ e.style.setProperty("max-" + prop, "50px");
+
+ e.style.setProperty(prop, "10%");
+ assert_equals(cs[prop], "10%", `${e.id}: ${prop} with percentages returns percentages`);
+
+ e.style.setProperty(prop, "15px");
+ assert_equals(cs[prop], "15px", `${e.id}: ${prop} with value in range returns computed value`);
+
+ e.style.setProperty(prop, "1px");
+ assert_equals(cs[prop], "1px", `${e.id}: ${prop} with value out of range isn't clamped by min-${prop}`);
+
+ e.style.setProperty(prop, "60px");
+ assert_equals(cs[prop], "60px", `${e.id}: ${prop} with value out of range isn't clamped by max-${prop}`);
+
+ e.style.removeProperty(prop);
+ e.style.removeProperty("min-" + prop);
+ e.style.removeProperty("max-" + prop);
+ }
+ }
+}, "Resolved value of width / height when there's no used value isn't clamped by min/max properties");
+</script>
