Fix document.all test to pass even when run directly in a browser.
The test has a <div id="log"> that comes _after_ the <script> that runs the
tests. That means that when logging is enabled (e.g. loading the test
directly) testharness doesn't find the log container, since it hasn't been
parsed yet when the test runs. It then creates a new <div id="log"> and
inserts it into the DOM, which changes the contents of document.all and the
test fails. On the other hand, when running in a harness logging is typically
turned off so none of this happens.
The solution is to move the log container to before the test script and modify
the test expectations accordingly. Then the test passes in both modes.
diff --git a/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html b/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
index d425996..e3e0778 100644
--- a/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
+++ b/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
@@ -23,6 +23,7 @@
<div id="null"></div>
<div name="divwithname"></div>
<div id="-0"></div>
+<div id="log"></div>
<script>
var anchors = document.querySelectorAll("a");
var divs = document.querySelectorAll("div");
@@ -34,7 +35,7 @@
}, "document.all is an HTMLAllCollection");
test(function() {
- assert_equals(document.all.length, 24);
+ assert_equals(document.all.length, 25);
}, "length attribute");
// indexed property getter
@@ -42,12 +43,12 @@
test(function() {
assert_equals(document.all[0], document.documentElement);
assert_equals(document.all[-0], document.documentElement);
- assert_equals(document.all[23], scripts[2]);
+ assert_equals(document.all[24], scripts[2]);
}, "indexed property getter");
test(function() {
assert_equals(document.all[-1], undefined);
- assert_equals(document.all[24], undefined);
+ assert_equals(document.all[25], undefined);
assert_equals(document.all[42], undefined);
assert_equals(document.all[43], undefined);
assert_equals(document.all[4294967294], undefined);
@@ -86,8 +87,8 @@
test(function() {
assert_equals(document.all["0"], document.documentElement);
- assert_equals(document.all["23"], document.scripts[2]);
- assert_equals(document.all["24"], undefined);
+ assert_equals(document.all["24"], document.scripts[2]);
+ assert_equals(document.all["25"], undefined);
assert_equals(document.all["42"], undefined);
assert_equals(document.all["43"], undefined);
}, "named property getter with \"array index property name\"");
@@ -187,16 +188,16 @@
test(function() {
assert_equals(document.all("0"), document.documentElement);
- assert_equals(document.all("23"), document.scripts[2]);
- assert_equals(document.all("24"), null);
+ assert_equals(document.all("24"), document.scripts[2]);
+ assert_equals(document.all("25"), null);
assert_equals(document.all("42"), null);
assert_equals(document.all("43"), null);
}, "legacy caller with \"array index property name\"");
test(function() {
assert_equals(document.all(0), document.documentElement);
- assert_equals(document.all(23), document.scripts[2]);
- assert_equals(document.all(24), null);
+ assert_equals(document.all(24), document.scripts[2]);
+ assert_equals(document.all(25), null);
assert_equals(document.all(42), null);
assert_equals(document.all(43), null);
}, "legacy caller with \"array index property name\" as number");
@@ -267,16 +268,16 @@
test(function() {
assert_equals(document.all.item("0"), document.documentElement);
- assert_equals(document.all.item("23"), document.scripts[2]);
- assert_equals(document.all.item("24"), null);
+ assert_equals(document.all.item("24"), document.scripts[2]);
+ assert_equals(document.all.item("25"), null);
assert_equals(document.all.item("42"), null);
assert_equals(document.all.item("43"), null);
}, "item method with \"array index property name\"");
test(function() {
assert_equals(document.all.item(0), document.documentElement);
- assert_equals(document.all.item(23), document.scripts[2]);
- assert_equals(document.all.item(24), null);
+ assert_equals(document.all.item(24), document.scripts[2]);
+ assert_equals(document.all.item(25), null);
assert_equals(document.all.item(42), null);
assert_equals(document.all.item(43), null);
}, "item method with \"array index property name\" as number");
@@ -329,6 +330,5 @@
}
}, "collections are new live HTMLCollection instances");
</script>
-<div id="log"></div>
</body>
</html>
