| commit | 66689b5c50fa635f64ef48cff2498b7d17937dae | [log] [tgz] |
|---|---|---|
| author | Xiaocheng Hu <xiaochengh@chromium.org> | Thu Sep 26 08:18:49 2019 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Sep 26 08:25:44 2019 |
| tree | f903013acba2ada81503379260c67a3e3214e3f4 | |
| parent | 0053aa9ffad975a5748a52f61e955e5286019045 [diff] |
Do not simplify calculation across math functions The existing code is too aggressive in simplifying calc() expressions that, math functions (min/max etc) can be simplified away when they can be directly resolved. This doesn't match the spec (*), and is fixed in this patch. (*) https://drafts.csswg.org/css-values-4/#math-function-simplify-a-calculation Bug: 825895 Change-Id: Id5796299da50e40b09bc38bf0271c8f5cd7897de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825325 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700132}
diff --git a/css/css-values/minmax-angle-serialize.html b/css/css-values/minmax-angle-serialize.html index 3f42458..18c4b46 100644 --- a/css/css-values/minmax-angle-serialize.html +++ b/css/css-values/minmax-angle-serialize.html
@@ -20,6 +20,9 @@ test_valid_angle('max(1turn)', 'max(1turn)'); test_valid_angle('max(1grad)', 'max(1grad)'); +test_valid_angle('calc(min(1deg) + min(2deg))', 'calc(min(1deg) + min(2deg))'); +test_valid_angle('calc(max(1deg) + max(2deg))', 'calc(max(1deg) + max(2deg))'); + // TODO(crbug.com/978682): Complete this test suite </script>