commit ca9c14143725ef54ffa4d0b8da46b6488d772649
author Marina Sakai <marinasakai@google.com> Wed Oct 16 04:56:54 2019
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Wed Oct 16 05:12:33 2019
tree f65b5592c8770826d3c4e026472f6ed6a017d8c3
parent 0e1bcae7f14564f0946484c9e8021b0a6fdcb68d

Stop using private properties for data properties of cross-origin properties

Since Blink properly supports the incumbent realm now, there is no more need to use OriginSafeMethodSetter, which sets value via V8PrivateProperty.
So there is no need to use V8PrivateProperty also in OriginSafeMethodGetter.

This CL makes it possible to handle "data properties" of cross-origin properties as the proper data properties.

Bug: 715418
Change-Id: I336a8459b80bc63d08a248f3ed7a34dc0806e5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844520
Commit-Queue: Marina Sakai <marinasakai@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706304}

html/browsers/origin/cross-origin-objects/cross-origin-objects.html

diff --git a/html/browsers/origin/cross-origin-objects/cross-origin-objects.html b/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
index 72aec0b..f16a18d 100644
--- a/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
+++ b/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
@@ -148,6 +148,9 @@
   assert_throws("SecurityError", function() { win.location.pathname; }, "location.pathname throws cross-origin");
   assert_equals(B.frames, 'override', "Overrides visible in the same-origin case");
   assert_equals(win.frames, win, "Overrides invisible in the cross-origin case");
+  assert_equals(B.focus, 'override', "Overrides visible in the same-origin case");
+  checkFunction(win.focus, Function.prototype);
+  assert_not_equals(win.focus, focus, "Overrides invisible in the cross-origin case");
 }, "Basic sanity-checking");
 
 /*

html/browsers/origin/cross-origin-objects/frame.html

diff --git a/html/browsers/origin/cross-origin-objects/frame.html b/html/browsers/origin/cross-origin-objects/frame.html
index 3226c87..ca2dd8e 100644
--- a/html/browsers/origin/cross-origin-objects/frame.html
+++ b/html/browsers/origin/cross-origin-objects/frame.html
@@ -6,9 +6,10 @@
     document.domain = document.domain;
   }
 
-  // Override the |frames| property to test that such overrides are
+  // Override the |frames| and |focus| property to test that such overrides are
   // properly ignored cross-origin.
   window.frames = "override";
+  window.focus = "override";
 
   // Also add a |then| property to test that it doesn't get exposed.
   window.then = "something";