CookieStore: Remove secure from modification API
This change removes `secure` option from modification API per
discussion [1].
[1] https://github.com/WICG/cookie-store/issues/121
Bug: 1069670
Change-Id: I1f32016b05df4b750ccbf237e1c5de10a6ed85de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196805
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768043}
diff --git a/cookie-store/cookieListItem_attributes.tentative.https.any.js b/cookie-store/cookieListItem_attributes.tentative.https.any.js
index 5d46b2d..3442773 100644
--- a/cookie-store/cookieListItem_attributes.tentative.https.any.js
+++ b/cookie-store/cookieListItem_attributes.tentative.https.any.js
@@ -191,24 +191,6 @@
assert_array_equals(Object.keys(cookie).sort(), kCookieListItemKeys);
}, 'CookieListItem - cookieStore.set adds / to path if it does not end with /');
-promise_test(async testCase => {
- await cookieStore.delete('cookie-name');
-
- await cookieStore.set('cookie-name', 'cookie-value', { secure: false });
- testCase.add_cleanup(async () => {
- await cookieStore.delete('cookie-name');
- });
- const cookie = await cookieStore.get('cookie-name');
- assert_equals(cookie.name, 'cookie-name');
- assert_equals(cookie.value, 'cookie-value');
- assert_equals(cookie.domain, null);
- assert_equals(cookie.path, '/');
- assert_equals(cookie.expires, null);
- assert_equals(cookie.secure, false);
- assert_equals(cookie.sameSite, 'strict');
- assert_array_equals(Object.keys(cookie).sort(), kCookieListItemKeys);
-}, 'CookieListItem - cookieStore.set with secure set to false');
-
['strict', 'lax', 'none'].forEach(sameSiteValue => {
promise_test(async testCase => {
await cookieStore.delete('cookie-name');
diff --git a/cookie-store/cookieStore_delete_insecure.tentative.https.any.js b/cookie-store/cookieStore_delete_insecure.tentative.https.any.js
deleted file mode 100644
index aec0e28..0000000
--- a/cookie-store/cookieStore_delete_insecure.tentative.https.any.js
+++ /dev/null
@@ -1,22 +0,0 @@
-// META: title=Cookie Store API: cookieStore.delete() with insecure cookies
-// META: global=window,serviceworker
-
-'use strict';
-
-promise_test(async t => {
- await cookieStore.set('cookie-name', 'cookie-value', { secure: false });
- t.add_cleanup(async () => { await cookieStore.delete('cookie-name'); });
-
- await cookieStore.delete('cookie-name');
- const cookie = await cookieStore.get('cookie-name');
- assert_equals(cookie, null);
-}, 'cookieStore.delete(name) can delete an insecure cookie');
-
-promise_test(async t => {
- await cookieStore.set('cookie-name', 'cookie-value', { secure: false });
- t.add_cleanup(async () => { await cookieStore.delete('cookie-name'); });
-
- await cookieStore.delete({ name: 'cookie-name' });
- const cookie = await cookieStore.get('cookie-name');
- assert_equals(cookie, null);
-}, 'cookieStore.delete(options) can delete an insecure cookie');
