Revert "[client-hints] Viewport-Width correct value for navigation requests"
This reverts commit 66c9faff0a6c6add634ca9239426886ad30752b5.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 826750 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjZjOWZhZmYwYTZjNmFkZDYzNGNhOTIzOTQyNjg4NmFkMzA3NTJiNQw
Sample Failed Build: https://ci.chromium.org/b/8863818632966090416
Sample Failed Step: blink_web_tests on Mac-10.15
Sample Flaky Test: virtual/disable-user-agent-client-hint-feature/external/wpt/client-hints/viewport-width-window.https.html
Original change's description:
> [client-hints] Viewport-Width correct value for navigation requests
>
> Currently, Viewport-Width hints send the display width for navigation
> requests, rather than the actual viewport width.
> This CL fixes that for iframes and for new windows that have the same
> viewport as their opener.
>
> Bug: 825892
> Change-Id: Ib01f394325ed3753b9a89dbdbcada1db0d3b029c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494876
> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826750}
Change-Id: I6a36b74e8791409b90fd84a81bb2ef2f29d29eea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 825892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535873
Cr-Commit-Position: refs/heads/master@{#826951}
diff --git a/client-hints/resources/viewport-frame.py b/client-hints/resources/viewport-frame.py
deleted file mode 100644
index 52250bf..0000000
--- a/client-hints/resources/viewport-frame.py
+++ /dev/null
@@ -1,19 +0,0 @@
-def main(request, response):
- """
- postMessage Viewport-Width headers
- """
-
- if b"viewport-width" in request.headers:
- result = request.headers["viewport-width"]
- else:
- result = u"FAIL"
-
- headers = [(b"Content-Type", b"text/html"),
- (b"Access-Control-Allow-Origin", b"*")]
- content = b'''
-<script>
- let parentOrOpener = window.opener || window.parent;
- parentOrOpener.postMessage({ viewport: '%s' }, "*");
-</script>
-''' % (result)
- return 200, headers, content
diff --git a/client-hints/resources/viewport-measurement.html b/client-hints/resources/viewport-measurement.html
deleted file mode 100644
index c9c26f4..0000000
--- a/client-hints/resources/viewport-measurement.html
+++ /dev/null
@@ -1,8 +0,0 @@
-<script>
-(async () => {
- const response = await fetch("viewport.py");
- const body = await response.text();
- parent.postMessage(body, "*");
-})();
-</script>
-
diff --git a/client-hints/resources/viewport.py b/client-hints/resources/viewport.py
deleted file mode 100644
index c9fb642..0000000
--- a/client-hints/resources/viewport.py
+++ /dev/null
@@ -1,13 +0,0 @@
-def main(request, response):
- """
- Reflect Viewport-Width headers
- """
-
- if b"viewport-width" in request.headers:
- result = request.headers["viewport-width"]
- else:
- result = u"FAIL"
-
- headers = [(b"Content-Type", b"text/html"),
- (b"Access-Control-Allow-Origin", b"*")]
- return 200, headers, result
diff --git a/client-hints/viewport-width-iframe.https.html b/client-hints/viewport-width-iframe.https.html
deleted file mode 100644
index b6c03f0..0000000
--- a/client-hints/viewport-width-iframe.https.html
+++ /dev/null
@@ -1,15 +0,0 @@
-<html>
-<body>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script>
-promise_test(t => {
- return new Promise(resolve => {
- window.addEventListener("message", t.step_func(e => {
- assert_equals(e.data.viewport, window.innerWidth.toString());
- resolve();
- }));
- });
-});
-</script>
-<iframe src="resources/viewport-frame.py" width=503></iframe>
diff --git a/client-hints/viewport-width-iframe.https.html.headers b/client-hints/viewport-width-iframe.https.html.headers
deleted file mode 100644
index 8ba9a39..0000000
--- a/client-hints/viewport-width-iframe.https.html.headers
+++ /dev/null
@@ -1,2 +0,0 @@
-Accept-CH: Viewport-Width
-
diff --git a/client-hints/viewport-width-subresource.https.html b/client-hints/viewport-width-subresource.https.html
deleted file mode 100644
index 870da94..0000000
--- a/client-hints/viewport-width-subresource.https.html
+++ /dev/null
@@ -1,15 +0,0 @@
-<html>
-<body>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script>
-promise_test(t => {
- return new Promise(resolve => {
- window.addEventListener("message", t.step_func(e => {
- assert_equals(e.data, "503");
- resolve();
- }));
- });
-});
-</script>
-<iframe src="resources/viewport-measurement.html" width=503>
diff --git a/client-hints/viewport-width-subresource.https.html.headers b/client-hints/viewport-width-subresource.https.html.headers
deleted file mode 100644
index 8ba9a39..0000000
--- a/client-hints/viewport-width-subresource.https.html.headers
+++ /dev/null
@@ -1,2 +0,0 @@
-Accept-CH: Viewport-Width
-
diff --git a/client-hints/viewport-width-window-different-dimensions.https.html b/client-hints/viewport-width-window-different-dimensions.https.html
deleted file mode 100644
index 27d8198..0000000
--- a/client-hints/viewport-width-window-different-dimensions.https.html
+++ /dev/null
@@ -1,15 +0,0 @@
-<html>
-<body>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script>
-promise_test(t => {
- return new Promise(resolve => {
- window.addEventListener("message", t.step_func(e => {
- assert_equals(e.data.viewport, "503");
- resolve();
- }));
- });
-});
-window.open("resources/viewport-frame.py", "", "width=503");
-</script>
diff --git a/client-hints/viewport-width-window-different-dimensions.https.html.headers b/client-hints/viewport-width-window-different-dimensions.https.html.headers
deleted file mode 100644
index 8ba9a39..0000000
--- a/client-hints/viewport-width-window-different-dimensions.https.html.headers
+++ /dev/null
@@ -1,2 +0,0 @@
-Accept-CH: Viewport-Width
-
diff --git a/client-hints/viewport-width-window.https.html b/client-hints/viewport-width-window.https.html
deleted file mode 100644
index 1ed6357..0000000
--- a/client-hints/viewport-width-window.https.html
+++ /dev/null
@@ -1,15 +0,0 @@
-<html>
-<body>
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script>
-promise_test(t => {
- return new Promise(resolve => {
- window.addEventListener("message", t.step_func(e => {
- assert_equals(e.data.viewport, window.innerWidth.toString());
- resolve();
- }));
- });
-});
-window.open("resources/viewport-frame.py", "");
-</script>
diff --git a/client-hints/viewport-width-window.https.html.headers b/client-hints/viewport-width-window.https.html.headers
deleted file mode 100644
index 8ba9a39..0000000
--- a/client-hints/viewport-width-window.https.html.headers
+++ /dev/null
@@ -1,2 +0,0 @@
-Accept-CH: Viewport-Width
-
