commit 660198faec664d849d4d64320720df9d228ee2c4
author Adrienne Walker <enne@chromium.org> Sat Oct 30 00:52:02 2021
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Sat Oct 30 01:07:27 2021
tree 68a21851010737964f3b516218b8a83aa1b052f1
parent ef9899c9503c50c675ba1c374a04a82600d23aaf

Window Placement: rename getScreens to getScreenDetails

See: https://github.com/webscreens/window-placement/issues/50

Bug: 1264160
Change-Id: Ia55719ef4f62939e30f39f4a3ae0348aa6ce2fb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252527
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936625}

screen_enumeration/getScreenDetails.tentative.https.window.js

diff --git a/screen_enumeration/getScreens.tentative.https.window.js b/screen_enumeration/getScreenDetails.tentative.https.window.js
similarity index 81%
rename from screen_enumeration/getScreens.tentative.https.window.js
rename to screen_enumeration/getScreenDetails.tentative.https.window.js
index a4d6ec0..40c1041 100644
--- a/screen_enumeration/getScreens.tentative.https.window.js
+++ b/screen_enumeration/getScreenDetails.tentative.https.window.js
@@ -4,12 +4,12 @@
 'use strict';
 
 promise_test(async t => {
-  assert_equals(typeof self.getScreens, 'function');
-}, 'getScreens() is present');
+  assert_equals(typeof self.getScreenDetails, 'function');
+}, 'getScreenDetails() is present');
 
 promise_test(async t => {
   await test_driver.set_permission({name: 'window-placement'}, 'granted');
-  const screensInterface = await self.getScreens();
+  const screensInterface = await self.getScreenDetails();
   const screens = screensInterface.screens;
   assert_greater_than(screens.length, 0);
   assert_true(screens.includes(screensInterface.currentScreen));
@@ -34,26 +34,26 @@
   assert_equals(typeof screens[0].id, 'string');
   assert_equals(typeof screens[0].pointerTypes, 'object');
   assert_equals(typeof screens[0].label, 'string');
-}, 'getScreens() returns at least 1 Screen with permission granted');
+}, 'getScreenDetails() returns at least 1 Screen with permission granted');
 
 promise_test(async t => {
   await test_driver.set_permission({name: 'window-placement'}, 'granted');
-  assert_greater_than((await self.getScreens()).screens.length, 0);
+  assert_greater_than((await self.getScreenDetails()).screens.length, 0);
   await test_driver.set_permission({name: 'window-placement'}, 'denied');
-  await promise_rejects_dom(t, 'NotAllowedError', self.getScreens());
-}, 'getScreens() rejects the promise with permission denied');
+  await promise_rejects_dom(t, 'NotAllowedError', self.getScreenDetails());
+}, 'getScreenDetails() rejects the promise with permission denied');
 
 promise_test(async t => {
   await test_driver.set_permission({name: 'window-placement'}, 'granted');
   let iframe = document.body.appendChild(document.createElement('iframe'));
-  assert_greater_than((await iframe.contentWindow.getScreens()).screens.length, 0);
+  assert_greater_than((await iframe.contentWindow.getScreenDetails()).screens.length, 0);
 
   let iframeGetScreens;
   let constructor;
   await new Promise(resolve => {
     iframe.contentWindow.onunload = () => {
       // Grab these before the contentWindow is removed.
-      iframeGetScreens = iframe.contentWindow.getScreens;
+      iframeGetScreens = iframe.contentWindow.getScreenDetails;
       constructor = iframe.contentWindow.DOMException;
       resolve();
     };
@@ -65,12 +65,12 @@
   await t.step_wait(() => !iframe.contentWindow, "execution context invalid");
   assert_equals(iframe.contentWindow, null);
   await promise_rejects_dom(t, 'InvalidStateError', constructor, iframeGetScreens());
-}, "getScreens() resolves for attached iframe; rejects for detached iframe");
+}, "getScreenDetails() resolves for attached iframe; rejects for detached iframe");
 
 promise_test(async t => {
   await test_driver.set_permission({name: 'window-placement'}, 'granted');
   let iframe = document.body.appendChild(document.createElement('iframe'));
-  const screensInterface = await iframe.contentWindow.getScreens();
+  const screensInterface = await iframe.contentWindow.getScreenDetails();
   assert_greater_than(screensInterface.screens.length, 0);
   assert_equals(screensInterface.currentScreen, screensInterface.screens[0]);
   iframe.remove();