commit eb6d89344cf1c62f4cb1465191721700798e329d
author Philipp Hancke <phancke@microsoft.com> Mon Jan 08 11:56:38 2024
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Mon Jan 08 12:13:56 2024
tree e7fe0bccdf7ec0c440cdd783e52bfeb58a56bf68
parent ecbab417501c89bca2265314e35719a950b07e02

webrtc wpt: add legacy msid-semantic line to hardcoded sdp

which avoids an odd test failure from
  https://webrtc-review.googlesource.com/c/src/+/331800

BUG=webrtc:10421

Change-Id: I144c5b6e90aa0e68be58518596839970743171ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5139143
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1243981}

webrtc/simulcast/simulcast.js

diff --git a/webrtc/simulcast/simulcast.js b/webrtc/simulcast/simulcast.js
index 1886531..e0b90d8 100644
--- a/webrtc/simulcast/simulcast.js
+++ b/webrtc/simulcast/simulcast.js
@@ -24,7 +24,7 @@
 
   // Skip mid extension; we are replacing it with the rid extmap
   rtpParameters.headerExtensions = rtpParameters.headerExtensions.filter(
-    ext => ext.uri != 'urn:ietf:params:rtp-hdrext:sdes:mid'
+    ext => ext.uri !== 'urn:ietf:params:rtp-hdrext:sdes:mid'
   );
 
   for (const ext of rtpParameters.headerExtensions) {
@@ -45,7 +45,8 @@
   let sdp = SDPUtils.writeSessionBoilerplate() +
     SDPUtils.writeDtlsParameters(dtls, setupValue) +
     SDPUtils.writeIceParameters(ice) +
-    'a=group:BUNDLE ' + rids.join(' ') + '\r\n';
+    'a=group:BUNDLE ' + rids.join(' ') + '\r\n' +
+    'a=msid-semantic: WMS *\r\n';
   const baseRtpDescription = SDPUtils.writeRtpDescription(mline.kind, rtpParameters);
   for (const rid of rids) {
     sdp += baseRtpDescription +
@@ -107,7 +108,8 @@
   let sdp = SDPUtils.writeSessionBoilerplate() +
     SDPUtils.writeDtlsParameters(dtls, setupValue) +
     SDPUtils.writeIceParameters(ice) +
-    'a=group:BUNDLE ' + localMid + '\r\n';
+    'a=group:BUNDLE ' + localMid + '\r\n' +
+    'a=msid-semantic: WMS *\r\n';
   sdp += SDPUtils.writeRtpDescription(mline.kind, rtpParameters);
   // Although we are converting mids to rids, we still need a mid.
   // The first one will be consistent with trickle ICE candidates.