[IntersectionOptimization] Improve and fix cached rect invalidation
- Move invalidation from
ObjectPaintInvalidator::InvalidateDisplayItemClient to
PaintInvalidator::InvalidatePaint because the former doesn't
invalidate LayoutObjects that don't paint while these LayoutObjects
can still observe intersection based on layout.
- Rename InvalidateCachedRectsIfNeeded to
InvalidateCachedRectsIfPaintPropertiesChange() because it only
handles paint property changes but not local layout changes.
- Skip scroll optimization if the cached rect is invalidated for other
reasons.
Bug: 1400495, 1515283
Change-Id: Ib3015f13ac4280fc7a50e686982703eef3128812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5154140
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246582}
diff --git a/intersection-observer/visibility-hidden.html b/intersection-observer/visibility-hidden.html
new file mode 100644
index 0000000..588a42e
--- /dev/null
+++ b/intersection-observer/visibility-hidden.html
@@ -0,0 +1,59 @@
+<!DOCTYPE html>
+<meta name="viewport" content="width=device-width,initial-scale=1">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="./resources/intersection-observer-test-utils.js"></script>
+
+<style>
+body {
+ margin: 0;
+}
+pre, #log {
+ position: absolute;
+ top: 0;
+ left: 200px;
+}
+.spacer {
+ height: calc(100vh + 100px);
+}
+#target {
+ width: 100px;
+ height: 100px;
+ visibility: hidden;
+}
+</style>
+
+<div class="spacer"></div>
+<div id="target"></div>
+<div class="spacer"></div>
+
+<script>
+var vw = document.documentElement.clientWidth;
+var vh = document.documentElement.clientHeight;
+var entries = [];
+
+runTestCycle(function() {
+ target = document.getElementById("target");
+ assert_true(!!target, "target exists");
+ var observer = new IntersectionObserver(function(changes) {
+ entries = entries.concat(changes)
+ });
+ observer.observe(target);
+ entries = entries.concat(observer.takeRecords());
+ assert_equals(entries.length, 0, "No initial notifications.");
+ runTestCycle(step0, "First rAF.");
+}, "IntersectionObserver observing a visibility:hidden element.");
+
+function step0() {
+ document.scrollingElement.scrollTop = 300;
+ runTestCycle(step1, "document.scrollingElement.scrollTop = 300");
+ // The numbers in brackets are target client rect; intersection rect;
+ // and root bounds.
+ checkLastEntry(entries, 0, [0, 100, vh + 100, vh + 200, 0, 0, 0, 0, 0, vw, 0, vh, false]);
+}
+
+function step1() {
+ document.scrollingElement.scrollTop = 0;
+ checkLastEntry(entries, 1, [0, 100, vh - 200, vh - 100, 0, 100, vh - 200, vh - 100, 0, vw, 0, vh, true]);
+}
+</script>
