Shared Storage: Add web tests to verify entry limit no longer enforced
We add web tests for `set()` and `append()` to verify that the
previous entry limit of 10000 is no longer being enforced.
Bug: 325352528,1218540
Change-Id: I0d39185755fe1b8a07761ad96a56f62b56bf31a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318315
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1265558}
diff --git a/shared-storage/append-exceed-former-entry-limit.tentative.https.html b/shared-storage/append-exceed-former-entry-limit.tentative.https.html
new file mode 100644
index 0000000..921b9d4
--- /dev/null
+++ b/shared-storage/append-exceed-former-entry-limit.tentative.https.html
@@ -0,0 +1,52 @@
+<!doctype html>
+<meta name="timeout" content="long">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/common/utils.js"></script>
+<script src="/shared-storage/resources/util.js"></script>
+<script src="/fenced-frame/resources/utils.js"></script>
+
+<body>
+<script>
+'use strict';
+const PREV_ENTRY_LIMIT = 10000;
+
+promise_test(async () => {
+ const ancestor_key = token();
+ let url0 = generateURL("/shared-storage/resources/frame0.html",
+ [ancestor_key]);
+ let url1 = generateURL("/shared-storage/resources/frame1.html",
+ [ancestor_key]);
+ let url2 = generateURL("/shared-storage/resources/frame2.html",
+ [ancestor_key]);
+
+ const numEntriesToAppend = PREV_ENTRY_LIMIT + 1;
+
+ // Create an array of promises.
+ const append_promises = [];
+ for (let i = 0; i < numEntriesToAppend; i++) {
+ append_promises.push(sharedStorage.append(i.toString(), 'x'));
+ }
+
+ // Wait for all promises to resolve in parallel.
+ await Promise.all(append_promises);
+
+ await addModuleOnce("/shared-storage/resources/verify-length-module.js");
+ let select_url_result = await sharedStorage.selectURL(
+ "verify-length", [{url: url0}, {url: url1}, {url: url2}],
+ {data: {'expectedLength': numEntriesToAppend},
+ resolveToConfig: true, keepAlive: true});
+ assert_true(validateSelectURLResult(select_url_result, true));
+ attachFencedFrame(select_url_result, 'opaque-ads');
+
+ // frame1_loaded implies that the legnth is as expected and so the calls to
+ // append() were all successful.
+ assert_equals(await nextValueFromServer(ancestor_key), "frame1_loaded");
+
+ // Clean up.
+ await sharedStorage.clear();
+}, 'sharedStorage.append() is not constrained by the former entry limit of '
+ + PREV_ENTRY_LIMIT.toString());
+
+</script>
+</body>
diff --git a/shared-storage/resources/verify-length-module.js b/shared-storage/resources/verify-length-module.js
new file mode 100644
index 0000000..8ba10fb
--- /dev/null
+++ b/shared-storage/resources/verify-length-module.js
@@ -0,0 +1,18 @@
+// Copyright 2024 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+class VerifyLength {
+ async run(urls, data) {
+ if (data && data.hasOwnProperty('expectedLength')) {
+ const expectedLength = data['expectedLength'];
+ const actualLength = await sharedStorage.length();
+ if (actualLength === expectedLength) {
+ return 1;
+ }
+ }
+ return -1;
+ }
+}
+
+register('verify-length', VerifyLength);
diff --git a/shared-storage/set-exceed-former-entry-limit.tentative.https.html b/shared-storage/set-exceed-former-entry-limit.tentative.https.html
new file mode 100644
index 0000000..b78abbf
--- /dev/null
+++ b/shared-storage/set-exceed-former-entry-limit.tentative.https.html
@@ -0,0 +1,52 @@
+<!doctype html>
+<meta name="timeout" content="long">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/common/utils.js"></script>
+<script src="/shared-storage/resources/util.js"></script>
+<script src="/fenced-frame/resources/utils.js"></script>
+
+<body>
+<script>
+'use strict';
+const PREV_ENTRY_LIMIT = 10000;
+
+promise_test(async () => {
+ const ancestor_key = token();
+ let url0 = generateURL("/shared-storage/resources/frame0.html",
+ [ancestor_key]);
+ let url1 = generateURL("/shared-storage/resources/frame1.html",
+ [ancestor_key]);
+ let url2 = generateURL("/shared-storage/resources/frame2.html",
+ [ancestor_key]);
+
+ const numEntriesToSet = PREV_ENTRY_LIMIT + 1;
+
+ // Create an array of promises.
+ const set_promises = [];
+ for (let i = 0; i < numEntriesToSet; i++) {
+ set_promises.push(sharedStorage.set(i.toString(), 'x'));
+ }
+
+ // Wait for all promises to resolve in parallel.
+ await Promise.all(set_promises);
+
+ await addModuleOnce("/shared-storage/resources/verify-length-module.js");
+ let select_url_result = await sharedStorage.selectURL(
+ "verify-length", [{url: url0}, {url: url1}, {url: url2}],
+ {data: {'expectedLength': numEntriesToSet},
+ resolveToConfig: true, keepAlive: true});
+ assert_true(validateSelectURLResult(select_url_result, true));
+ attachFencedFrame(select_url_result, 'opaque-ads');
+
+ // frame1_loaded implies that the legnth is as expected and so the calls to
+ // set() were all successful.
+ assert_equals(await nextValueFromServer(ancestor_key), "frame1_loaded");
+
+ // Clean up.
+ await sharedStorage.clear();
+}, 'sharedStorage.set() is not constrained by the former entry limit of '
+ + PREV_ENTRY_LIMIT.toString());
+
+</script>
+</body>
