Apply standard parsing of pseudo-elements for web animations
Note that for web-animations, using no-colons or single-colon already
works as specified, and the difference here is in making the argument
parser more forgiving (as per spec).
This is behind a flag, together with full parsing for getComputedStyle.
See I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/p-7KuUD_p20/m/fe8Iwb-IAAAJ
The following test already asserts the behavior with single/no colon, which doesn't change with this CL:
TEST=external/wpt/web-animations/interfaces/Animatable/animate.html
The newly added test (third_party/blink/web_tests/external/wpt/css/css-view-transitions/web-animations-api-parse-pseudo-argument.html) asserts
the new observable behavior, which only applies to pseudos with
arguments.
Bug: 328681375
Change-Id: I3a259dbcddd85d2c0a050ab0e2bef55e02973d32
Validate-Test-Flakiness: skip
Change-Id: I3a259dbcddd85d2c0a050ab0e2bef55e02973d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5358740
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1272463}
diff --git a/css/css-view-transitions/web-animations-api-parse-pseudo-argument.html b/css/css-view-transitions/web-animations-api-parse-pseudo-argument.html
new file mode 100644
index 0000000..40c9a0d
--- /dev/null
+++ b/css/css-view-transitions/web-animations-api-parse-pseudo-argument.html
@@ -0,0 +1,63 @@
+<!DOCTYPE html>
+<html class=reftest-wait>
+<title>View transitions with web-animation API: full parsing of argument</title>
+<link rel="help" href="https://www.w3.org/TR/css-view-transitions-1/">
+<link rel="match" href="web-animations-api-ref.html">
+<meta name="fuzzy" content="web-animations-api-ref.html:0-2;0-500">
+<meta name="variant" content="?first-pseudo=::view-transition-group( first)">
+<meta name="variant" content="?first-pseudo=::view-transition-group(first)">
+<meta name="variant" content="?first-pseudo=::view-transition-group( first">
+<meta name="variant" content="?first-pseudo=::view-transition-group( first )">
+<meta name="variant" content="?first-pseudo=::view-transition-group(first )">
+<meta name="variant" content="?first-pseudo=::view-transition-group(first">
+<script src="/common/reftest-wait.js">
+</script>
+<style>
+ #first {
+ background: blue;
+ width: 100px;
+ height: 100px;
+ contain: paint;
+ }
+
+ #second {
+ background: green;
+ width: 100px;
+ height: 100px;
+ contain: paint;
+ }
+
+ /* Unset all animations since the test drives it using WA-API */
+ html::view-transition-group(*),
+ html::view-transition-image-pair(*),
+ html::view-transition-new(*),
+ html::view-transition-old(*) {
+ animation: unset;
+ }
+
+ html::view-transition-group(root) {
+ opacity: 0;
+ }
+</style>
+<div id=first></div>
+<div id=second></div>
+<script>
+ failIfNot(document.startViewTransition, "Missing document.startViewTransition");
+ const firstPseudo = new URL(location.href).searchParams.get("first-pseudo") ?? "::view-transition-group(first)";
+
+ function setAnimation() {
+ document.documentElement.animate({ transform: ['translate(100px)', 'translate(100px)'] }, { duration: 10000, pseudoElement: firstPseudo });
+ document.documentElement.animate({ transform: ['translate(150px)', 'translate(150px)'] }, { duration: 10000, pseudoElement: '::view-transition-group(second)' });
+ requestAnimationFrame(takeScreenshot);
+ }
+
+ async function runTest() {
+ first.style.viewTransitionName = "first";
+ document.startViewTransition(() => {
+ first.style.viewTransitionName = "";
+ second.style.viewTransitionName = "second";
+ requestAnimationFrame(setAnimation);
+ });
+ }
+ onload = () => requestAnimationFrame(() => requestAnimationFrame(runTest));
+</script>
