commit 6198caed57c0568e28fa914c0850b00c9cad0b3e
author Philipp Hancke <philipp.hancke@googlemail.com> Mon May 06 14:19:08 2024
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Mon May 06 14:57:42 2024
tree 7e5cb624793ff688c0b28a088a7025e2a7774e3b
parent 724ac3ecb5052cd18d1122144007378c851b09e0

webrtc wpt: rename tests that check createOffer/createAnswer return value

and modernize one of them

BUG=chromium:337071657

Change-Id: Id02b570639cee026727771545899f020f3e858a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512699
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#1296825}

webrtc/RTCPeerConnection-createAnswer.html

diff --git a/webrtc/RTCPeerConnection-createAnswer.html b/webrtc/RTCPeerConnection-createAnswer.html
index 1970db0..7e31dda 100644
--- a/webrtc/RTCPeerConnection-createAnswer.html
+++ b/webrtc/RTCPeerConnection-createAnswer.html
@@ -18,14 +18,14 @@
   const pc = new RTCPeerConnection();
   t.add_cleanup(() => pc.close());
 
-  const offer = await generateVideoReceiveOnlyOffer(pc);
+  const offer = await pc.createOffer();
   await pc.setRemoteDescription(offer);
   const answer = await pc.createAnswer();
   assert_equals(typeof answer, 'object',
-    'Expect answer to be plain object dictionary RTCSessionDescriptionInit');
+    'Expect answer to be plain object (dictionary RTCSessionDescriptionInit)');
   assert_false(answer instanceof RTCSessionDescription,
     'Expect answer to not be instance of RTCSessionDescription');
-}, 'createAnswer() after setting remote description should succeed');
+}, 'createAnswer() returns RTCSessionDescriptionInit');
 
 promise_test(async t => {
   const pc = new RTCPeerConnection();

webrtc/RTCPeerConnection-createOffer.html

diff --git a/webrtc/RTCPeerConnection-createOffer.html b/webrtc/RTCPeerConnection-createOffer.html
index 7287980..4eabdff 100644
--- a/webrtc/RTCPeerConnection-createOffer.html
+++ b/webrtc/RTCPeerConnection-createOffer.html
@@ -25,20 +25,17 @@
    *        with its type member initialized to the string "offer" and its sdp member
    *        initialized to sdpString.
    */
-  promise_test(t => {
+  promise_test(async t => {
     const pc = new RTCPeerConnection()
-
     t.add_cleanup(() => pc.close());
 
-    return pc.createOffer()
-    .then(offer => {
-      assert_equals(typeof offer, 'object',
-        'Expect offer to be plain object dictionary RTCSessionDescriptionInit');
+    const offer = await pc.createOffer()
+    assert_equals(typeof offer, 'object',
+      'Expect offer to be plain object (dictionary RTCSessionDescriptionInit)');
 
-      assert_false(offer instanceof RTCSessionDescription,
-        'Expect offer to not be instance of RTCSessionDescription')
-    });
-  }, 'createOffer() with no argument from newly created RTCPeerConnection should succeed');
+    assert_false(offer instanceof RTCSessionDescription,
+      'Expect offer to not be instance of RTCSessionDescription')
+  }, 'createOffer() returns RTCSessionDescriptionInit');
 
   promise_test(t => {
     const pc = new RTCPeerConnection();