| commit | b9ab25d42550f950598505d9f7cf148cbba7a3a8 | [log] [tgz] |
|---|---|---|
| author | Yuki Shiino <yukishiino@chromium.org> | Tue May 07 01:50:46 2024 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue May 07 06:07:59 2024 |
| tree | c89d347ba0551024a75b6a47c61236520fb288fb | |
| parent | d3cfe06062b56e75ea71ca223ac4cb2686eb59c3 [diff] |
Revert "Update focus-navigation WPT forward to use test_driver.Actions" This reverts commit 5ca29ac8df39fb902b44a9f4e1d3118feea544cf. Reason for revert: Suspicious about causing WPTs failing or flakily failing. https://ci.chromium.org/ui/p/chromium/builders/ci/Mac11%20Tests/27459/overview https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/19475/overview Original change's description: > Update focus-navigation WPT forward to use test_driver.Actions > > Previous patch changed navigateFocusForward() in focus-utils.js > to send keyboard event on the document.documentElement. > This change was not interoperable [1]. We update to send the keyboard > event using test_driver.Actions() and without specifying an element > to send keys to. > > [1] https://github.com/web-platform-tests/wpt/pull/45772#discussion_r1591235292 > > Change-Id: I3b2a4a38ea4edb4d05d8c4a34505f0f8083f6460 > Bug: 40542192 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5519292 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Di Zhang <dizhangg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1297032} Bug: 40542192 Change-Id: I147968c0f75c59f92a5b5406ab20ba1f23f01455 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513895 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Yuki Shiino <yukishiino@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1297215}
diff --git a/shadow-dom/focus-navigation/resources/focus-utils.js b/shadow-dom/focus-navigation/resources/focus-utils.js index ef517c5..f4056dc 100644 --- a/shadow-dom/focus-navigation/resources/focus-utils.js +++ b/shadow-dom/focus-navigation/resources/focus-utils.js
@@ -7,10 +7,7 @@ async function navigateFocusForward() { await waitForRender(); const kTab = '\uE004'; - await new test_driver.Actions() - .keyDown(kTab) - .keyUp(kTab) - .send(); + await new test_driver.send_keys(document.documentElement,kTab); await waitForRender(); }