Google Git
Sign in
chromium / infra / gerrit-plugins / buildbucket / c38b6edee96ac5c6ded559a5f01f6c0289f08a22
commitc38b6edee96ac5c6ded559a5f01f6c0289f08a22[log] [tgz]
authorGavin Mak <gavinmak@google.com>Thu Mar 04 01:06:19 2021
committerGavin Mak <gavinmak@google.com>Thu Mar 04 01:06:19 2021
tree397580db1961311c44e4273a44d7377944e42459
parent300f58c9b5b374681026ec77313331209cedb91e [diff]
Fix openTryjobPicker

When opening the tryjob picker using the top-level action, the popup is
not centered until the window is resized. Also, the second time the
picker is opened, (from opening, closing, then opening), the popup
cannot be closed and no buckets or builders are present.

This change addresses both issues and adds an openTryjobPicker test.

Bug:1174869
Change-Id: Idf40f6d72b8af06e10fb510c11a4277a7da7fa48
Reviewed-on: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/2730309
Reviewed-by: Weiwei Lin <weiweilin@google.com>
2 files changed
tree: 397580db1961311c44e4273a44d7377944e42459
  1. src/
  2. test/
  3. .eslintrc.json
  4. .gitignore
  5. bower.json
  6. BUILD
  7. codereview.settings
  8. LICENSE
  9. package-lock.json
  10. package.json
  11. README.md
  12. run-with-prod-data.sh
  13. run-with-testsite.sh
  14. wct.conf.json
README.md

Buildbucket Plugin for Gerrit

Usage

This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).

An example buildbucket.config is below:

[host]
  git = "chromium.googlesource.com"
  gerrit = "chromium-review.googlesource.com"

[bucket "luci.chromium.try"]
[bucket "luci.chrome.try"]

In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.

All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.

If your project doesn't want the “retry failed” button to show, you can disable it:

[option]
  hide-retry-button = true

Development

To use with the local testsite

Use the script run-with-testsite.sh; this rebuilds the plugin with bazel, copies it over and restarts the local testsite. Example invocation:

GERRIT_DIR=~/gerrit GERRIT_TESTSITE_DIR=~/testsite ./run-with-testsite.sh

To use with the polygerrit-ui server against live data

Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh. Example invocation:

GERRIT_DIR=~/gerrit ./run-with-prod-data.sh

Testing

npm run wct-test

Note: Testing is disabled for Safari due to this issue.