appengine/findit/waterfall/build_failure_analysis.py - infra/infra - Git at Google

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.

 import collections
 import os
 import re

 from common.diff import ChangeType
 from waterfall.failure_signal import FailureSignal


 def _IsSameFile(changed_src_file_path, file_path_in_log):
   """Guesses if the two files are the same.

   Args:
     changed_src_file_path (str): Full path of a file committed to git repo.
     file_path_in_log (str): Path of a file appearing in a failure log. It might
         not be a full path.

   Returns:
     True if the two files are likely the same, otherwise False. Eg.:
       True: (chrome/test/base/chrome_process_util.h, base/chrome_process_util.h)
       True: (a/b/x.cc, a/b/x.cc)
       False: (c/x.cc, a/b/c/x.cc)
   """
   if changed_src_file_path == file_path_in_log:
     return True
   return changed_src_file_path.endswith('/%s' % file_path_in_log)


 def _NormalizeObjectFilePath(file_path):
   """Normalize the file path to an c/c++ object file.

   During compile, a/b/c/file.cc in TARGET will be compiled into object file
   obj/a/b/c/TARGET.file.o, thus 'obj/' and TARGET need to be removed from path.

   Args:
     file_path (str): A path to an object file (.o or .obj) after compile.
   Returns:
     A normalized file path.
   """
   if file_path.startswith('obj/'):
     file_path = file_path[4:]
   file_dir = os.path.dirname(file_path)
   file_name = os.path.basename(file_path)
   parts = file_name.split('.', 1)
   if len(parts) == 2 and (parts[1].endswith('.o') or parts[1].endswith('.obj')):
     file_name = parts[1]

   if file_dir:
     return '%s/%s' % (file_dir, file_name)
   else:
     return file_name


 _COMMON_SUFFIXES = [
     'impl',
     'browser_tests', 'browser_test', 'browsertest', 'browsertests',
     'unittests', 'unittest', 'tests', 'test',
     'gcc', 'msvc',
     'arm', 'arm64', 'mips', 'portable', 'x86',
     'android', 'ios', 'linux', 'mac', 'ozone', 'posix', 'win',
     'aura', 'x', 'x11',
 ]

 _COMMON_SUFFIX_PATTERNS = [
     re.compile('.*(_%s)$' % suffix) for suffix in _COMMON_SUFFIXES
 ]


 def _StripExtensionAndCommonSuffix(file_path):
   """Strips extension and common suffixes from file name to guess relation.

   Examples:
     file_impl.cc, file_unittest.cc, file_impl_mac.h -> file
   """
   file_dir = os.path.dirname(file_path)
   file_name = os.path.splitext(os.path.basename(file_path))[0]
   while True:
     match = None
     for suffix_patten in _COMMON_SUFFIX_PATTERNS:
       match = suffix_patten.match(file_name)
       if match:
         file_name = file_name[:-len(match.group(1))]
         break

     if not match:
       break

   return os.path.join(file_dir, file_name).replace(os.sep, '/')


 def _IsRelated(changed_src_file_path, file_path):
   """Checks if two files are related.

   Example of related files:
     1. file.h <-> file_impl.cc
     2. file_impl.cc <-> file_unittest.cc
     3. file_win.cc <-> file_mac.cc
     4. x.h <-> x.cc
   """
   if file_path.endswith('.o') or file_path.endswith('.obj'):
     file_path = _NormalizeObjectFilePath(file_path)

   if _IsSameFile(_StripExtensionAndCommonSuffix(changed_src_file_path),
                  _StripExtensionAndCommonSuffix(file_path)):
     return True

   return False


 class _Justification(object):
   """Justification for why a CL might be suspected for a build failure.

   A justification includes:
   1. score:
      1) If a hint shows that a CL is highly-suspected, the hint is given 5
         score points. Eg. a CL is highly suspected if it deleted a .cc file
         appearing in the compile failure.
      2) If a hint shows that a CL is likely-suspected, the hint is given 1
         score point. Eg. a CL is just likely suspected if it only changed a
         related file (x_impl.cc vs. x.h) appearing in a failure.
   2. hints: each hint is a string describing a reason for suspecting a CL and
      could be shown to the user (eg., "added x_impl.cc (and it was in log)").
   """

   def __init__(self):
     self._score = 0
     self._hints = collections.defaultdict(int)

   @property
   def score(self):
     return self._score

   def AddFileChange(self, change_action, changed_src_file_path,
                     file_path_in_log, score, num_file_name_occurrences):
     """Adds a suspected file change.

     Args:
       change_action (str): How file was changed: added, deleted, or modified.
       changed_src_file_path (str): Changed file path in a CL.
       file_path_in_log (str): File path appearing in the failure log.
       score (int): Score number for the file change.
       num_file_name_occurrences (int): Number of occurrences of this file base
           name (not including directory part) in the commit.
     """
     if num_file_name_occurrences == 1:
       changed_src_file_path = os.path.basename(changed_src_file_path)
       file_path_in_log = os.path.basename(file_path_in_log)

     if changed_src_file_path != file_path_in_log:
       hint = '%s %s (%s was in log)' % (
           change_action, changed_src_file_path, file_path_in_log)
     else:
       hint = '%s %s (and it was in log)' % (
           change_action, changed_src_file_path)

     self._hints[hint] += score
     self._score += score

   def AddDEPSRoll(self, dep_path, dep_repo_url, dep_new_revision,
                   dep_old_revision, file_path_in_log, score):
     url_to_changes_in_roll = '%s/+log/%s..%s?pretty=fuller' % (
         dep_repo_url, dep_old_revision[:12], dep_new_revision[:12])
     hint = ('Rolled %s with changes %s (and %s was in log)' % (
         dep_path, url_to_changes_in_roll, file_path_in_log))
     self._hints[hint] = score
     self._score += score

   def ToDict(self):
     return {
         'score': self._score,
         'hints': self._hints,
     }


 def _CheckFile(touched_file,
                file_path_in_log,
                justification,
                file_name_occurrences):
   """Checks if the given files are related and updates the justification.

   Args:
     touched_file (dict): The touched file found in the change log.
     file_path_in_log (str): File path appearing in the failure log.
     justification (_Justification): An instance of _Justification.
     file_name_occurrences (dict): A dict mapping file names to
         number of occurrences.
   """
   change_type = touched_file['change_type']

   if change_type == ChangeType.MODIFY:
     # TODO(stgao): Use Git Blame if a modified file in the failure message
     # is with a line number.
     changed_src_file_path = touched_file['new_path']
     file_name = os.path.basename(changed_src_file_path)

     score = 0
     if _IsSameFile(changed_src_file_path, file_path_in_log):
       score = 2
     elif _IsRelated(changed_src_file_path, file_path_in_log):
       score = 1

     if score:
       justification.AddFileChange('modified',
                                   changed_src_file_path,
                                   file_path_in_log,
                                   score,
                                   file_name_occurrences.get(file_name))

   if change_type in (ChangeType.ADD, ChangeType.COPY, ChangeType.RENAME):
     changed_src_file_path = touched_file['new_path']
     file_name = os.path.basename(changed_src_file_path)

     score = 0
     if _IsSameFile(changed_src_file_path, file_path_in_log):
       score = 5
     elif _IsRelated(changed_src_file_path, file_path_in_log):
       score = 1

     if score:
       justification.AddFileChange('added',
                                   changed_src_file_path,
                                   file_path_in_log,
                                   score,
                                   file_name_occurrences.get(file_name))

   if change_type in (ChangeType.DELETE, ChangeType.RENAME):
     changed_src_file_path = touched_file['old_path']
     file_name = os.path.basename(changed_src_file_path)

     score = 0
     if _IsSameFile(changed_src_file_path, file_path_in_log):
       score = 5
     elif _IsRelated(changed_src_file_path, file_path_in_log):
       score = 1

     if score:
       justification.AddFileChange('deleted',
                                   changed_src_file_path,
                                   file_path_in_log,
                                   score,
                                   file_name_occurrences.get(file_name))


 def _CheckFiles(failure_signal, change_log, deps_info):
   """Check files in the given change log of a CL against the failure signal.

   Args:
     failure_signal (FailureSignal): The failure signal of a failed step or test.
     change_log (dict): The change log of a CL as returned by
         common.change_log.ChangeLog.ToDict().
     deps_info (dict): Output of pipeline ExtractDEPSInfoPipeline.

   Returns:
     A dict as returned by _Justification.ToDict() if the CL is suspected for the
     failure; otherwise None.
   """
   # Use a dict to map each file name of the touched files to their occurrences.
   file_name_occurrences = collections.defaultdict(int)
   for touched_file in change_log['touched_files']:
     change_type = touched_file['change_type']
     if (change_type in (ChangeType.ADD, ChangeType.COPY,
         ChangeType.RENAME, ChangeType.MODIFY)):
       file_name = os.path.basename(touched_file['new_path'])
       file_name_occurrences[file_name] += 1

     if change_type in (ChangeType.DELETE, ChangeType.RENAME):
       file_name = os.path.basename(touched_file['old_path'])
       file_name_occurrences[file_name] += 1

   justification = _Justification()

   for file_path_in_log, _ in failure_signal.files.iteritems():
     # Strip src/ from file path to make all files relative to the chromium root
     # directory.
     file_path_in_log = file_path_in_log.lstrip('src/')

     for touched_file in change_log['touched_files']:
       _CheckFile(
           touched_file, file_path_in_log, justification, file_name_occurrences)

     for roll in deps_info.get('deps_rolls', {}).get(change_log['revision'], []):
       dep_path = roll['path'].lstrip('src/')
       if file_path_in_log.startswith(dep_path):
         justification.AddDEPSRoll(
             dep_path, roll['repo_url'], roll['new_revision'],
             roll['old_revision'], file_path_in_log[len(dep_path):], 2)

   if not justification.score:
     return None
   else:
     return justification.ToDict()


 def AnalyzeBuildFailure(
     failure_info, change_logs, deps_info, failure_signals):
   """Analyze the given failure signals, and figure out culprit CLs.

   Args:
     failure_info (dict): Output of pipeline DetectFirstFailurePipeline.
     change_logs (dict): Output of pipeline PullChangelogPipeline.
     deps_info (dict): Output of pipeline ExtractDEPSInfoPipeline.
     failure_signals (dict): Output of pipeline ExtractSignalPipeline.

   Returns:
     A dict with the following form:
     {
       'failures': [
         {
           'step_name': 'compile',
           'first_failure': 230,
           'last_pass': 229,
           'suspected_cls': [
             {
               'build_number': 230,
               'repo_name': 'chromium',
               'revision': 'a_git_hash',
               'commit_position': 56789,
               'score': 11,
               'hints': {
                 'add a/b/x.cc': 5,
                 'delete a/b/y.cc': 5,
                 'modify e/f/z.cc': 1,
                 ...
               }
             },
             ...
           ],
         },
         ...
       ]
     }
   """
   analysis_result = {
       'failures': []
   }

   if not failure_info['failed']:
     return analysis_result

   def CreateCLInfoDict(justification_dict, build_number, change_log):
     # TODO(stgao): remove hard-coded 'chromium' when DEPS file parsing is
     # supported.
     cl_info = {
         'build_number': build_number,
         'repo_name': 'chromium',
         'revision': change_log['revision'],
         'commit_position': change_log.get('commit_position'),
         'url':
             change_log.get('code_review_url') or change_log.get('commit_url'),
     }

     cl_info.update(justification_dict)
     return cl_info

   failed_steps = failure_info['failed_steps']
   builds = failure_info['builds']
   for step_name, step_failure_info in failed_steps.iteritems():
     failure_signal = FailureSignal.FromDict(failure_signals[step_name])
     failed_build_number = step_failure_info['current_failure']

     if step_failure_info.get('last_pass') != None:
       build_number = step_failure_info.get('last_pass') + 1
     else:
       build_number = step_failure_info['first_failure']

     step_analysis_result = {
         'step_name': step_name,
         'first_failure': step_failure_info['first_failure'],
         'last_pass': step_failure_info.get('last_pass'),
         'suspected_cls': [],
     }

     while build_number <= failed_build_number:
       for revision in builds[str(build_number)]['blame_list']:
         justification_dict = _CheckFiles(
             failure_signal, change_logs[revision], deps_info)

         if not justification_dict:
           continue

         step_analysis_result['suspected_cls'].append(
             CreateCLInfoDict(justification_dict, build_number,
                              change_logs[revision]))

       build_number += 1

     # TODO(stgao): sort CLs by score.
     analysis_result['failures'].append(step_analysis_result)

   return analysis_result
	# Copyright 2015 The Chromium Authors. All rights reserved.
	# Use of this source code is governed by a BSD-style license that can be
	# found in the LICENSE file.

	import collections
	import os
	import re

	from common.diff import ChangeType
	from waterfall.failure_signal import FailureSignal


	def _IsSameFile(changed_src_file_path, file_path_in_log):
	"""Guesses if the two files are the same.

	Args:
	changed_src_file_path (str): Full path of a file committed to git repo.
	file_path_in_log (str): Path of a file appearing in a failure log. It might
	not be a full path.

	Returns:
	True if the two files are likely the same, otherwise False. Eg.:
	True: (chrome/test/base/chrome_process_util.h, base/chrome_process_util.h)
	True: (a/b/x.cc, a/b/x.cc)
	False: (c/x.cc, a/b/c/x.cc)
	"""
	if changed_src_file_path == file_path_in_log:
	return True
	return changed_src_file_path.endswith('/%s' % file_path_in_log)


	def _NormalizeObjectFilePath(file_path):
	"""Normalize the file path to an c/c++ object file.

	During compile, a/b/c/file.cc in TARGET will be compiled into object file
	obj/a/b/c/TARGET.file.o, thus 'obj/' and TARGET need to be removed from path.

	Args:
	file_path (str): A path to an object file (.o or .obj) after compile.
	Returns:
	A normalized file path.
	"""
	if file_path.startswith('obj/'):
	file_path = file_path[4:]
	file_dir = os.path.dirname(file_path)
	file_name = os.path.basename(file_path)
	parts = file_name.split('.', 1)
	if len(parts) == 2 and (parts[1].endswith('.o') or parts[1].endswith('.obj')):
	file_name = parts[1]

	if file_dir:
	return '%s/%s' % (file_dir, file_name)
	else:
	return file_name


	_COMMON_SUFFIXES = [
	'impl',
	'browser_tests', 'browser_test', 'browsertest', 'browsertests',
	'unittests', 'unittest', 'tests', 'test',
	'gcc', 'msvc',
	'arm', 'arm64', 'mips', 'portable', 'x86',
	'android', 'ios', 'linux', 'mac', 'ozone', 'posix', 'win',
	'aura', 'x', 'x11',
	]

	_COMMON_SUFFIX_PATTERNS = [
	re.compile('.*(_%s)$' % suffix) for suffix in _COMMON_SUFFIXES
	]


	def _StripExtensionAndCommonSuffix(file_path):
	"""Strips extension and common suffixes from file name to guess relation.

	Examples:
	file_impl.cc, file_unittest.cc, file_impl_mac.h -> file
	"""
	file_dir = os.path.dirname(file_path)
	file_name = os.path.splitext(os.path.basename(file_path))[0]
	while True:
	match = None
	for suffix_patten in _COMMON_SUFFIX_PATTERNS:
	match = suffix_patten.match(file_name)
	if match:
	file_name = file_name[:-len(match.group(1))]
	break

	if not match:
	break

	return os.path.join(file_dir, file_name).replace(os.sep, '/')


	def _IsRelated(changed_src_file_path, file_path):
	"""Checks if two files are related.

	Example of related files:
	1. file.h <-> file_impl.cc
	2. file_impl.cc <-> file_unittest.cc
	3. file_win.cc <-> file_mac.cc
	4. x.h <-> x.cc
	"""
	if file_path.endswith('.o') or file_path.endswith('.obj'):
	file_path = _NormalizeObjectFilePath(file_path)

	if _IsSameFile(_StripExtensionAndCommonSuffix(changed_src_file_path),
	_StripExtensionAndCommonSuffix(file_path)):
	return True

	return False


	class _Justification(object):
	"""Justification for why a CL might be suspected for a build failure.

	A justification includes:
	1. score:
	1) If a hint shows that a CL is highly-suspected, the hint is given 5
	score points. Eg. a CL is highly suspected if it deleted a .cc file
	appearing in the compile failure.
	2) If a hint shows that a CL is likely-suspected, the hint is given 1
	score point. Eg. a CL is just likely suspected if it only changed a
	related file (x_impl.cc vs. x.h) appearing in a failure.
	2. hints: each hint is a string describing a reason for suspecting a CL and
	could be shown to the user (eg., "added x_impl.cc (and it was in log)").
	"""

	def __init__(self):
	self._score = 0
	self._hints = collections.defaultdict(int)

	@property
	def score(self):
	return self._score

	def AddFileChange(self, change_action, changed_src_file_path,
	file_path_in_log, score, num_file_name_occurrences):
	"""Adds a suspected file change.

	Args:
	change_action (str): How file was changed: added, deleted, or modified.
	changed_src_file_path (str): Changed file path in a CL.
	file_path_in_log (str): File path appearing in the failure log.
	score (int): Score number for the file change.
	num_file_name_occurrences (int): Number of occurrences of this file base
	name (not including directory part) in the commit.
	"""
	if num_file_name_occurrences == 1:
	changed_src_file_path = os.path.basename(changed_src_file_path)
	file_path_in_log = os.path.basename(file_path_in_log)

	if changed_src_file_path != file_path_in_log:
	hint = '%s %s (%s was in log)' % (
	change_action, changed_src_file_path, file_path_in_log)
	else:
	hint = '%s %s (and it was in log)' % (
	change_action, changed_src_file_path)

	self._hints[hint] += score
	self._score += score

	def AddDEPSRoll(self, dep_path, dep_repo_url, dep_new_revision,
	dep_old_revision, file_path_in_log, score):
	url_to_changes_in_roll = '%s/+log/%s..%s?pretty=fuller' % (
	dep_repo_url, dep_old_revision[:12], dep_new_revision[:12])
	hint = ('Rolled %s with changes %s (and %s was in log)' % (
	dep_path, url_to_changes_in_roll, file_path_in_log))
	self._hints[hint] = score
	self._score += score

	def ToDict(self):
	return {
	'score': self._score,
	'hints': self._hints,
	}


	def _CheckFile(touched_file,
	file_path_in_log,
	justification,
	file_name_occurrences):
	"""Checks if the given files are related and updates the justification.

	Args:
	touched_file (dict): The touched file found in the change log.
	file_path_in_log (str): File path appearing in the failure log.
	justification (_Justification): An instance of _Justification.
	file_name_occurrences (dict): A dict mapping file names to
	number of occurrences.
	"""
	change_type = touched_file['change_type']

	if change_type == ChangeType.MODIFY:
	# TODO(stgao): Use Git Blame if a modified file in the failure message
	# is with a line number.
	changed_src_file_path = touched_file['new_path']
	file_name = os.path.basename(changed_src_file_path)

	score = 0
	if _IsSameFile(changed_src_file_path, file_path_in_log):
	score = 2
	elif _IsRelated(changed_src_file_path, file_path_in_log):
	score = 1

	if score:
	justification.AddFileChange('modified',
	changed_src_file_path,
	file_path_in_log,
	score,
	file_name_occurrences.get(file_name))

	if change_type in (ChangeType.ADD, ChangeType.COPY, ChangeType.RENAME):
	changed_src_file_path = touched_file['new_path']
	file_name = os.path.basename(changed_src_file_path)

	score = 0
	if _IsSameFile(changed_src_file_path, file_path_in_log):
	score = 5
	elif _IsRelated(changed_src_file_path, file_path_in_log):
	score = 1

	if score:
	justification.AddFileChange('added',
	changed_src_file_path,
	file_path_in_log,
	score,
	file_name_occurrences.get(file_name))

	if change_type in (ChangeType.DELETE, ChangeType.RENAME):
	changed_src_file_path = touched_file['old_path']
	file_name = os.path.basename(changed_src_file_path)

	score = 0
	if _IsSameFile(changed_src_file_path, file_path_in_log):
	score = 5
	elif _IsRelated(changed_src_file_path, file_path_in_log):
	score = 1

	if score:
	justification.AddFileChange('deleted',
	changed_src_file_path,
	file_path_in_log,
	score,
	file_name_occurrences.get(file_name))


	def _CheckFiles(failure_signal, change_log, deps_info):
	"""Check files in the given change log of a CL against the failure signal.

	Args:
	failure_signal (FailureSignal): The failure signal of a failed step or test.
	change_log (dict): The change log of a CL as returned by
	common.change_log.ChangeLog.ToDict().
	deps_info (dict): Output of pipeline ExtractDEPSInfoPipeline.

	Returns:
	A dict as returned by _Justification.ToDict() if the CL is suspected for the
	failure; otherwise None.
	"""
	# Use a dict to map each file name of the touched files to their occurrences.
	file_name_occurrences = collections.defaultdict(int)
	for touched_file in change_log['touched_files']:
	change_type = touched_file['change_type']
	if (change_type in (ChangeType.ADD, ChangeType.COPY,
	ChangeType.RENAME, ChangeType.MODIFY)):
	file_name = os.path.basename(touched_file['new_path'])
	file_name_occurrences[file_name] += 1

	if change_type in (ChangeType.DELETE, ChangeType.RENAME):
	file_name = os.path.basename(touched_file['old_path'])
	file_name_occurrences[file_name] += 1

	justification = _Justification()

	for file_path_in_log, _ in failure_signal.files.iteritems():
	# Strip src/ from file path to make all files relative to the chromium root
	# directory.
	file_path_in_log = file_path_in_log.lstrip('src/')

	for touched_file in change_log['touched_files']:
	_CheckFile(
	touched_file, file_path_in_log, justification, file_name_occurrences)

	for roll in deps_info.get('deps_rolls', {}).get(change_log['revision'], []):
	dep_path = roll['path'].lstrip('src/')
	if file_path_in_log.startswith(dep_path):
	justification.AddDEPSRoll(
	dep_path, roll['repo_url'], roll['new_revision'],
	roll['old_revision'], file_path_in_log[len(dep_path):], 2)

	if not justification.score:
	return None
	else:
	return justification.ToDict()


	def AnalyzeBuildFailure(
	failure_info, change_logs, deps_info, failure_signals):
	"""Analyze the given failure signals, and figure out culprit CLs.

	Args:
	failure_info (dict): Output of pipeline DetectFirstFailurePipeline.
	change_logs (dict): Output of pipeline PullChangelogPipeline.
	deps_info (dict): Output of pipeline ExtractDEPSInfoPipeline.
	failure_signals (dict): Output of pipeline ExtractSignalPipeline.

	Returns:
	A dict with the following form:
	{
	'failures': [
	{
	'step_name': 'compile',
	'first_failure': 230,
	'last_pass': 229,
	'suspected_cls': [
	{
	'build_number': 230,
	'repo_name': 'chromium',
	'revision': 'a_git_hash',
	'commit_position': 56789,
	'score': 11,
	'hints': {
	'add a/b/x.cc': 5,
	'delete a/b/y.cc': 5,
	'modify e/f/z.cc': 1,
	...
	}
	},
	...
	],
	},
	...
	]
	}
	"""
	analysis_result = {
	'failures': []
	}

	if not failure_info['failed']:
	return analysis_result

	def CreateCLInfoDict(justification_dict, build_number, change_log):
	# TODO(stgao): remove hard-coded 'chromium' when DEPS file parsing is
	# supported.
	cl_info = {
	'build_number': build_number,
	'repo_name': 'chromium',
	'revision': change_log['revision'],
	'commit_position': change_log.get('commit_position'),
	'url':
	change_log.get('code_review_url') or change_log.get('commit_url'),
	}

	cl_info.update(justification_dict)
	return cl_info

	failed_steps = failure_info['failed_steps']
	builds = failure_info['builds']
	for step_name, step_failure_info in failed_steps.iteritems():
	failure_signal = FailureSignal.FromDict(failure_signals[step_name])
	failed_build_number = step_failure_info['current_failure']

	if step_failure_info.get('last_pass') != None:
	build_number = step_failure_info.get('last_pass') + 1
	else:
	build_number = step_failure_info['first_failure']

	step_analysis_result = {
	'step_name': step_name,
	'first_failure': step_failure_info['first_failure'],
	'last_pass': step_failure_info.get('last_pass'),
	'suspected_cls': [],
	}

	while build_number <= failed_build_number:
	for revision in builds[str(build_number)]['blame_list']:
	justification_dict = _CheckFiles(
	failure_signal, change_logs[revision], deps_info)

	if not justification_dict:
	continue

	step_analysis_result['suspected_cls'].append(
	CreateCLInfoDict(justification_dict, build_number,
	change_logs[revision]))

	build_number += 1

	# TODO(stgao): sort CLs by score.
	analysis_result['failures'].append(step_analysis_result)

	return analysis_result