[file] Fix bug in read_proto.

Due to a copy/paste error, read_proto took 'encoding_kwargs', which
makes very little sense. The typical use for this is to pass things
like 'ignore_unknown_fields' to the json_format decoder.

However, in the previous implementation, it took 'encoding_kwargs'
and passed this to the decoder AND an encoder (for the log report).

There's not a strong need to control the encoded output (especially
since this encoded output can vary from the selected encoder in
order to avoid dumping binary proto to a text log), so this fixes
the API to just have decoding_kwargs instead.

R=fancl, mohrr

Change-Id: I4d15a8c7030c8bf06a825bc12d1eaf785819f750
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5552112
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
2 files changed
tree: c64b2a2b456beecf0fe2f4ecf03a936f88ea95d3
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  17. codereview.settings
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py


Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.


  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.