commit 349059c0123b8558f097e0dd598512adfac87782
author Jihad Hanna <jihadghanna@google.com> Tue Mar 12 11:38:17 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Mar 12 11:38:17 2024
tree 4ec34bd413b3c64b2252094da9b92c4c3f75a13c
parent ce4d39c7efd9e7c36a477b1179b86e08e1e5c72f

Update FormTracker using blink form mutation signal.

Previously Autofill used to use a WebFormElementObserver in order to
track elements disappearing for submission detection purposes.

E.g. When XHR happens, if the tracked element had disappeared by then,
we infer form submission, but if the element disappears later we would
need another mechanism to check that. This observer was the needed mechanism.

Given that this was not strong enough as a signal to detect hidden
elements (only detects display: none) a signal was introduced in a prior
CL from blink to Autofill for when elements are added, removed or
hidden.

In this CL, we use the kRemoved and kHide signals to inform FormTracker
that maybe the tracked element disappeared, and in that case,
FormTracker can maybe infer form submission.

The observer was used for 3 cases:
- XHR, then tracked element disappeared.
- Same document navigation, then tracked element disappeared.
- (PWM only) Autofilled element then tracked element disappeared.

This CL therefore introduces 4 booleans representing each one of those
cases + a boolean that tracks if the tracked element disappeared or not.
This way we only infer submission for event X if both event_x_happened
and tracked_element_disappeared booleans are set to true.

This CL also disables the use of the observer.

Lastly, the CL drops the form extraction done in GetSubmittedForm, as
this would cause problems when called from within a style recalc in
blink. Instead, it uses `provisionally_saved_form_` unconditionally
and so the submitted form would be the version of the form last edited
by the user.

When the introduced feature is disabled, this CL is a no-op. All changes described previously are gated by the added feature flag.

Bug: 1483242
Change-Id: Ib1793841a8a0dbf8bc3dff3244cce82809e00853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5041251
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Auto-Submit: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1271468}