commit 716e539c2ea588ec7151ac8411c16aad28a30059
author Karl Schimpf <kschimpf@google.com> Fri Jan 05 15:35:21 2018
committer Commit Bot <commit-bot@chromium.org> Fri Jan 05 19:17:26 2018
tree 5600955ede3bb462c7e0fb451b65f6e14f02dc73
parent da72b856e303417f729414213f49564622351f56

[wasm] Use static_assert instead of assert

Fixes nits found by @clemensh after
CL https://chromium-review.googlesource.com/c/v8/v8/+/834670
was committed. That is, the code uses static asserts instead of
assert.

Bug: v8:7226
Change-Id: I5488ec4609d1bee3aafa61a3ff2505f71b06d80d
Reviewed-on: https://chromium-review.googlesource.com/847687
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Karl Schimpf <kschimpf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50388}

test/cctest/wasm/test-run-wasm.cc

diff --git a/test/cctest/wasm/test-run-wasm.cc b/test/cctest/wasm/test-run-wasm.cc
index 132a103..ec9585a 100644
--- a/test/cctest/wasm/test-run-wasm.cc
+++ b/test/cctest/wasm/test-run-wasm.cc
@@ -2876,16 +2876,16 @@
   WasmRunner<int32_t, float> r(execution_mode);
   BUILD(r, WASM_I32_SCONVERT_SAT_F32(WASM_GET_LOCAL(0)));
 
-  constexpr float kLowerBound =
-      static_cast<float>(std::numeric_limits<int32_t>::min());
-  constexpr float kUpperBound =
-      static_cast<float>(std::numeric_limits<int32_t>::max());
-  assert(static_cast<int64_t>(kUpperBound) >
-         static_cast<int64_t>(std::numeric_limits<int32_t>::max()));
-  assert(static_cast<int32_t>(kLowerBound) ==
-         std::numeric_limits<int32_t>::min());
+  constexpr float kLowerBound = std::numeric_limits<int32_t>::min();
+  constexpr float kUpperBound = std::numeric_limits<int32_t>::max();
 
   FOR_FLOAT32_INPUTS(i) {
+    static_assert(static_cast<int64_t>(kUpperBound) >
+                      static_cast<int64_t>(std::numeric_limits<int32_t>::max()),
+                  "kUpperBound invalidates the following bounds check.");
+    static_assert(static_cast<int32_t>(kLowerBound) ==
+                      std::numeric_limits<int32_t>::min(),
+                  "kLowerBounds invalidates the following bounds check.");
     if (*i < kUpperBound && *i >= kLowerBound) {
       CHECK_EQ(static_cast<int32_t>(*i), r.Call(*i));
     } else if (std::isnan(*i)) {