| commit | c393df2f3139e77820ce7fe719b90b4588d2f6be | [log] [tgz] |
|---|---|---|
| author | brucedawson <brucedawson@chromium.org> | Fri May 26 16:00:53 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Fri May 26 16:00:53 2017 |
| tree | a774647a9c269837f050daba80b57ff16727e422 | |
| parent | 1a81ce2d3d097aed40f5f97cab10de2ae5634364 [diff] |
Disable tests on VS 2017 Preview, code-gen bug VS 2017 has a code-gen bug, discussed and reported here: https://developercommunity.visualstudio.com/content/problem/40904/bad-code-gen-in-chromes-mojo-public-bindings-unitt.html As of VS 2017 Update 3 Preview 1 the bug is still not fixed, so this CL adjusts the checks to continue disabling the failing tests to allow testing with this VC version. The next preview should have the fix - probably. crrev.com/2826713003 disabled the tests for VS 2017 RTM. R=jam@chromium.org BUG=723893 Review-Url: https://codereview.chromium.org/2909593002 Cr-Original-Commit-Position: refs/heads/master@{#475017} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 6d1398efad86b7c862e83719602aed55c35d0e28
diff --git a/public/cpp/bindings/tests/pickle_unittest.cc b/public/cpp/bindings/tests/pickle_unittest.cc index e5cc267..39f0572 100644 --- a/public/cpp/bindings/tests/pickle_unittest.cc +++ b/public/cpp/bindings/tests/pickle_unittest.cc
@@ -182,8 +182,9 @@ } // namespace -#if _MSC_FULL_VER == 191025017 -// Disabled due to this VS 2017 RTM code-gen bug: +#if _MSC_FULL_VER == 191025017 || _MSC_FULL_VER == 191125303 +// Disabled due to this VS 2017 RTM code-gen bug, still present in Update 3 +// Preview 1: // https://developercommunity.visualstudio.com/content/problem/40904/bad-code-gen-in-chromes-mojo-public-bindings-unitt.html #define MAYBE_ChromiumProxyToChromiumService \ DISABLED_ChromiumProxyToChromiumService