Google Git
Sign in
chromium / chromium / src / tools / grit / refs/heads/main
commit2bc29446f0e9ecc91841d116e7d55a8f872c62a3[log] [tgz]
authorKhalid Peer <khalidpeer@chromium.org>Tue May 14 23:53:12 2024
committerCopybara-Service <copybara-worker@google.com>Wed May 15 00:00:53 2024
tree88654e1b5f93da327c722a373008958131d2963c
parent80bd86bca2ac10d08d2e197952ec94e9b2917638 [diff]
[omnibox] Replace deprecated `assert` with `with` in JS imports.

The chrome://omnibox UI is currently broken due to an error caused by
usage of the deprecated `assert` keyword in the JS imports. This CL
fixes the issue by making use of the recommended `with` keyword as an
alternative.

In order to play nice with the current TS toolchain used when building
Chromium, this CL also disables JS minification across all builders for
this particular WebUI (since the `terser` minifier hasn't been updated
yet to support the new `with` keyword).

Bug: 340297713, 340278433, 339686362
Change-Id: Ifdef7bf33724154d202d9b355e0fb5f2dfbf813b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529040
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300984}
NOKEYCHECK=True
GitOrigin-RevId: 1b8b4c7317d2b30978df3bbb5ca8cd40c1128e95
1 file changed
tree: 88654e1b5f93da327c722a373008958131d2963c
  1. grit/
  2. preprocess_tests/
  3. .gitignore
  4. BUILD.gn
  5. grit.py
  6. grit_args.gni
  7. grit_info.py
  8. grit_rule.gni
  9. MANIFEST.in
  10. minify_js.py
  11. minify_js_unittest.py
  12. minimize_css.py
  13. minimize_css_unittest.py
  14. OWNERS
  15. pak_util.py
  16. pak_util_unittest.py
  17. preprocess_if_expr.gni
  18. preprocess_if_expr.py
  19. preprocess_if_expr_test.py
  20. PRESUBMIT.py
  21. README.md
  22. repack.gni
  23. setup.py
  24. stamp_grit_sources.py
README.md

GRIT (Google Resource and Internationalization Tool)

This is a tool for projects to manage resources and simplify the localization workflow.

See the user guide for more details on using this project: https://dev.chromium.org/developers/tools-we-use-in-chromium/grit/grit-users-guide

History

This code previously used to live at https://code.google.com/p/grit-i18n/source/checkout which still contains the project‘s history. https://chromium.googlesource.com/external/grit-i18n/ is a git mirror of the SVN repository that’s identical except for the last two commits. The project is now developed in the Chromium project directly.

There is a read-only mirror of just this directory at https://chromium.googlesource.com/chromium/src/tools/grit/ if you don't want to check out all of Chromium.