Google Git
Sign in
chromium / chromium / src.git / 03ffb82d2b2e2d34ae4b5ea71cc0aa9dc863dce8
commit03ffb82d2b2e2d34ae4b5ea71cc0aa9dc863dce8[log] [tgz]
authorStephen McGruer <smcgruer@chromium.org>Mon Jul 08 13:21:25 2019
committerCommit Bot <commit-bot@chromium.org>Mon Jul 08 13:21:25 2019
tree8651fcc9f0eaab85fa9d8532b4e06ed4b807e420
parent16cb7c8c4f59693bed364e9a30c467d7ac9f6482 [diff]
Properly test !CSSPaintAPIArguments in CSSPaintValueTest

Previously all the tests assumed that CSSPaintAPIArguments was on, which
was covering up a bug where OffMainThreadCSSPaint would create a
deferred image even though the generator wasn't ready (because
ParseInputArguments would pass due to !CSSPaintAPIArguments). This CL
fixes the tests to actually test all combinations, and fixes the bug by
extracting the generator-ready check outside of ParseInputArguments.

Bug: None
Change-Id: I6789cf24b7efa6035a88990082a857f24ccafbb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689953
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675214}
2 files changed
tree: 8651fcc9f0eaab85fa9d8532b4e06ed4b807e420
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. .clang-format
  52. .eslintrc.js
  53. .git-blame-ignore-revs
  54. .gitattributes
  55. .gitignore
  56. .gn
  57. .vpython
  58. AUTHORS
  59. BUILD.gn
  60. CODE_OF_CONDUCT.md
  61. codereview.settings
  62. DEPS
  63. ENG_REVIEW_OWNERS
  64. LICENSE
  65. LICENSE.chromium_os
  66. OWNERS
  67. PRESUBMIT.py
  68. PRESUBMIT_test.py
  69. PRESUBMIT_test_mocks.py
  70. README.md
  71. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .