blob: 6c04e8a491a9685a8b397c1a54edf5a75ddeffd8 [file] [log] [blame]
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chromeos/network/cellular_metrics_logger.h"
#include <memory>
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/task_environment.h"
#include "base/time/time.h"
#include "chromeos/components/feature_usage/feature_usage_metrics.h"
#include "chromeos/login/login_state/login_state.h"
#include "chromeos/network/cellular_esim_profile.h"
#include "chromeos/network/cellular_inhibitor.h"
#include "chromeos/network/network_connection_handler.h"
#include "chromeos/network/network_state_handler.h"
#include "chromeos/network/network_state_test_helper.h"
#include "chromeos/network/network_ui_data.h"
#include "chromeos/network/test_cellular_esim_profile_handler.h"
#include "dbus/object_path.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
namespace chromeos {
namespace {
const char kTestEuiccPath[] = "euicc_path";
const char kTestIccid[] = "iccid";
const char kTestProfileName[] = "test_profile_name";
const char kTestEidName[] = "eid";
const char kTestPSimGuid[] = "psim_guid";
const char kTestESimGuid[] = "esim_guid";
const char kTestESimPolicyGuid[] = "esim_policy_guid";
const char kTestCellularDevicePath[] = "/device/wwan0";
const char kTestPSimCellularServicePath[] = "/service/cellular0";
const char kTestESimCellularServicePath[] = "/service/cellular1";
const char kTestESimPolicyCellularServicePath[] = "/service/cellular2";
const char kTestEthServicePath[] = "/service/eth0";
const char kESimFeatureUsageMetric[] = "ChromeOS.FeatureUsage.ESim";
const char kESimFeatureUsageUsetimeMetric[] =
"ChromeOS.FeatureUsage.ESim.Usetime";
const char kPSimUsageCountHistogram[] = "Network.Cellular.PSim.Usage.Count";
const char kESimUsageCountHistogram[] = "Network.Cellular.ESim.Usage.Count";
const char kESimPolicyUsageCountHistogram[] =
"Network.Cellular.ESim.Policy.Usage.Count";
const char kPSimServiceAtLoginHistogram[] =
"Network.Cellular.PSim.ServiceAtLogin.Count";
const char kESimServiceAtLoginHistogram[] =
"Network.Cellular.ESim.ServiceAtLogin.Count";
const char kESimPolicyServiceAtLoginHistogram[] =
"Network.Cellular.ESim.Policy.ServiceAtLogin.Count";
const char kPSimStatusAtLoginHistogram[] =
"Network.Cellular.PSim.StatusAtLogin";
const char kESimStatusAtLoginHistogram[] =
"Network.Cellular.ESim.StatusAtLogin";
const char kPSimTimeToConnectedHistogram[] =
"Network.Cellular.PSim.TimeToConnected";
const char kESimTimeToConnectedHistogram[] =
"Network.Cellular.ESim.TimeToConnected";
const char kPSimDisconnectionsHistogram[] =
"Network.Cellular.PSim.Disconnections";
const char kESimDisconnectionsHistogram[] =
"Network.Cellular.ESim.Disconnections";
const char kESimPolicyDisconnectionsHistogram[] =
"Network.Cellular.ESim.Policy.Disconnections";
} // namespace
class CellularMetricsLoggerTest : public testing::Test {
public:
CellularMetricsLoggerTest()
: task_environment_(base::test::TaskEnvironment::TimeSource::MOCK_TIME) {}
CellularMetricsLoggerTest(const CellularMetricsLoggerTest&) = delete;
CellularMetricsLoggerTest& operator=(const CellularMetricsLoggerTest&) =
delete;
~CellularMetricsLoggerTest() override = default;
void SetUp() override {
ResetHistogramTester();
LoginState::Initialize();
cellular_inhibitor_ = std::make_unique<CellularInhibitor>();
cellular_esim_profile_handler_ =
std::make_unique<TestCellularESimProfileHandler>();
network_state_test_helper_.hermes_manager_test()->AddEuicc(
dbus::ObjectPath(kTestEuiccPath), kTestEidName, /*is_active=*/true,
/*physical_slot=*/0);
cellular_esim_profile_handler_->Init(
network_state_test_helper_.network_state_handler(),
cellular_inhibitor_.get());
base::RunLoop().RunUntilIdle();
}
void SetUpMetricsLogger() {
cellular_metrics_logger_.reset(new CellularMetricsLogger());
cellular_metrics_logger_->Init(
network_state_test_helper_.network_state_handler(),
/* network_connection_handler */ nullptr,
cellular_esim_profile_handler_.get());
histogram_tester_->ExpectTotalCount(kESimFeatureUsageMetric, 0);
task_environment_.FastForwardBy(
feature_usage::FeatureUsageMetrics::kInitialInterval);
histogram_tester_->ExpectBucketCount(
kESimFeatureUsageMetric,
static_cast<int>(feature_usage::FeatureUsageMetrics::Event::kEligible),
1);
}
void TearDown() override {
network_state_test_helper_.ClearDevices();
network_state_test_helper_.ClearServices();
cellular_metrics_logger_.reset();
LoginState::Shutdown();
}
protected:
void ResetHistogramTester() {
histogram_tester_ = std::make_unique<base::HistogramTester>();
}
void InitEthernet() {
ShillServiceClient::TestInterface* service_test =
network_state_test_helper_.service_test();
service_test->AddService(kTestEthServicePath, "test_guid1", "test_eth",
shill::kTypeEthernet, shill::kStateIdle, true);
base::RunLoop().RunUntilIdle();
}
void InitCellular() {
ShillDeviceClient::TestInterface* device_test =
network_state_test_helper_.device_test();
device_test->AddDevice(kTestCellularDevicePath, shill::kTypeCellular,
"test_cellular_device");
ShillServiceClient::TestInterface* service_test =
network_state_test_helper_.service_test();
service_test->AddService(kTestPSimCellularServicePath, kTestPSimGuid,
"test_cellular", shill::kTypeCellular,
shill::kStateIdle, true);
service_test->AddService(kTestESimCellularServicePath, kTestESimGuid,
"test_cellular_2", shill::kTypeCellular,
shill::kStateIdle, true);
service_test->AddService(kTestESimPolicyCellularServicePath,
kTestESimPolicyGuid, "test_cellular_3",
shill::kTypeCellular, shill::kStateIdle, true);
base::RunLoop().RunUntilIdle();
service_test->SetServiceProperty(
kTestPSimCellularServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateNotActivated));
service_test->SetServiceProperty(
kTestESimCellularServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateNotActivated));
service_test->SetServiceProperty(
kTestESimPolicyCellularServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateNotActivated));
service_test->SetServiceProperty(kTestESimCellularServicePath,
shill::kEidProperty,
base::Value("test_eid"));
// Emulate 'test_cellular_3' being a managed network.
service_test->SetServiceProperty(
kTestESimPolicyCellularServicePath, shill::kONCSourceProperty,
base::Value(shill::kONCSourceDevicePolicy));
std::unique_ptr<NetworkUIData> ui_data = NetworkUIData::CreateFromONC(
::onc::ONCSource::ONC_SOURCE_DEVICE_POLICY);
service_test->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kUIDataProperty,
base::Value(ui_data->GetAsJson()));
service_test->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kEidProperty,
base::Value("test_eid_2"));
base::RunLoop().RunUntilIdle();
}
void RemoveCellular() {
ShillServiceClient::TestInterface* service_test =
network_state_test_helper_.service_test();
service_test->RemoveService(kTestPSimCellularServicePath);
ShillDeviceClient::TestInterface* device_test =
network_state_test_helper_.device_test();
device_test->RemoveDevice(kTestCellularDevicePath);
base::RunLoop().RunUntilIdle();
}
void AddESimProfile(hermes::profile::State state,
const std::string& service_path) {
network_state_test_helper_.hermes_euicc_test()->AddCarrierProfile(
dbus::ObjectPath(service_path), dbus::ObjectPath(kTestEuiccPath),
kTestIccid, kTestProfileName, "service_provider", "activation_code",
service_path, state, hermes::profile::ProfileClass::kOperational,
HermesEuiccClient::TestInterface::AddCarrierProfileBehavior::
kAddProfileWithService);
base::RunLoop().RunUntilIdle();
}
void ClearEuicc() {
network_state_test_helper_.hermes_euicc_test()->ClearEuicc(
dbus::ObjectPath(kTestEuiccPath));
base::RunLoop().RunUntilIdle();
}
void ResetLogin() {
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_NONE,
LoginState::LoggedInUserType::LOGGED_IN_USER_NONE);
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_OWNER);
}
ShillServiceClient::TestInterface* service_client_test() {
return network_state_test_helper_.service_test();
}
CellularMetricsLogger* cellular_metrics_logger() const {
return cellular_metrics_logger_.get();
}
base::test::TaskEnvironment task_environment_;
std::unique_ptr<base::HistogramTester> histogram_tester_;
NetworkStateTestHelper network_state_test_helper_{
false /* use_default_devices_and_services */};
std::unique_ptr<CellularInhibitor> cellular_inhibitor_;
std::unique_ptr<TestCellularESimProfileHandler>
cellular_esim_profile_handler_;
std::unique_ptr<CellularMetricsLogger> cellular_metrics_logger_;
};
TEST_F(CellularMetricsLoggerTest, ActiveProfileExists) {
AddESimProfile(hermes::profile::State::kActive, kTestESimCellularServicePath);
SetUpMetricsLogger();
histogram_tester_->ExpectTotalCount(kESimFeatureUsageMetric, 2);
histogram_tester_->ExpectBucketCount(
kESimFeatureUsageMetric,
static_cast<int>(feature_usage::FeatureUsageMetrics::Event::kEnabled), 1);
}
TEST_F(CellularMetricsLoggerTest, CellularServiceAtLoginTest) {
SetUpMetricsLogger();
// Should defer logging when there are no cellular networks.
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_OWNER);
histogram_tester_->ExpectTotalCount(kESimServiceAtLoginHistogram, 0);
histogram_tester_->ExpectTotalCount(kPSimServiceAtLoginHistogram, 0);
histogram_tester_->ExpectTotalCount(kESimPolicyServiceAtLoginHistogram, 0);
// Should wait until initialization timeout before logging status.
InitCellular();
histogram_tester_->ExpectTotalCount(kESimServiceAtLoginHistogram, 0);
histogram_tester_->ExpectTotalCount(kPSimServiceAtLoginHistogram, 0);
histogram_tester_->ExpectTotalCount(kESimPolicyServiceAtLoginHistogram, 0);
task_environment_.FastForwardBy(
CellularMetricsLogger::kInitializationTimeout);
histogram_tester_->ExpectTotalCount(kESimServiceAtLoginHistogram, 1);
histogram_tester_->ExpectTotalCount(kPSimServiceAtLoginHistogram, 1);
histogram_tester_->ExpectTotalCount(kESimPolicyServiceAtLoginHistogram, 1);
// Should log immediately when networks are already initialized.
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_NONE,
LoginState::LoggedInUserType::LOGGED_IN_USER_NONE);
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_OWNER);
histogram_tester_->ExpectTotalCount(kESimServiceAtLoginHistogram, 2);
histogram_tester_->ExpectTotalCount(kPSimServiceAtLoginHistogram, 2);
histogram_tester_->ExpectTotalCount(kESimPolicyServiceAtLoginHistogram, 2);
// Should not log when the logged in user is neither owner nor regular.
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_KIOSK_APP);
histogram_tester_->ExpectTotalCount(kESimServiceAtLoginHistogram, 2);
histogram_tester_->ExpectTotalCount(kPSimServiceAtLoginHistogram, 2);
histogram_tester_->ExpectTotalCount(kESimPolicyServiceAtLoginHistogram, 2);
}
TEST_F(CellularMetricsLoggerTest, CellularUsageCountTest) {
SetUpMetricsLogger();
InitEthernet();
InitCellular();
static const base::Value kTestOnlineStateValue(shill::kStateOnline);
static const base::Value kTestIdleStateValue(shill::kStateIdle);
AddESimProfile(hermes::profile::State::kActive, kTestESimCellularServicePath);
// Should not log state until after timeout.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(kPSimUsageCountHistogram, 0);
task_environment_.FastForwardBy(
CellularMetricsLogger::kInitializationTimeout);
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 1);
// PSim Cellular connected with other network.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
kTestOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 0);
histogram_tester_->ExpectBucketCount(
kESimFeatureUsageMetric,
static_cast<int>(
feature_usage::FeatureUsageMetrics::Event::kUsedWithSuccess),
0);
// PSim Cellular connected as only network.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 0);
histogram_tester_->ExpectBucketCount(
kESimFeatureUsageMetric,
static_cast<int>(
feature_usage::FeatureUsageMetrics::Event::kUsedWithSuccess),
0);
// After |kTimeSpentOnlinePSim|, PSim Cellular becomes not connected.
const base::TimeDelta kTimeSpentOnlinePSim = base::Seconds(123);
task_environment_.FastForwardBy(kTimeSpentOnlinePSim);
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 2);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 1);
histogram_tester_->ExpectTimeBucketCount(
"Network.Cellular.PSim.Usage.Duration", kTimeSpentOnlinePSim, 1);
// Connect ethernet network.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestOnlineStateValue);
// ESim Cellular connected.
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
kTestOnlineStateValue);
// ESim Cellular connected with other network.
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 1);
// ESim Cellular connected as only network.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 1);
// After |kTimeSpentOnlineESim|, ESim Cellular becomes not connected.
const base::TimeDelta kTimeSpentOnlineESim = base::Seconds(123);
task_environment_.FastForwardBy(kTimeSpentOnlineESim);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 2);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 2);
histogram_tester_->ExpectTimeBucketCount(
"Network.Cellular.ESim.Usage.Duration", kTimeSpentOnlineESim, 1);
histogram_tester_->ExpectTimeBucketCount(kESimFeatureUsageUsetimeMetric,
kTimeSpentOnlineESim, 1);
// Connect ethernet network.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestOnlineStateValue);
// ESim Policy Cellular connected.
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kTestOnlineStateValue);
// ESim Policy Cellular connected with other network.
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 2);
histogram_tester_->ExpectBucketCount(
kESimPolicyUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 1);
// ESim Policy Cellular connected as only network.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 1);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 2);
histogram_tester_->ExpectBucketCount(
kESimPolicyUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 1);
// After |kTimeSpentOnlineESim|, ESim Policy Cellular becomes not connected.
task_environment_.FastForwardBy(kTimeSpentOnlineESim);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 2);
histogram_tester_->ExpectBucketCount(
kESimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 3);
histogram_tester_->ExpectBucketCount(
kESimPolicyUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 1);
histogram_tester_->ExpectTimeBucketCount(
"Network.Cellular.ESim.Usage.Duration", kTimeSpentOnlineESim, 2);
histogram_tester_->ExpectTimeBucketCount(
"Network.Cellular.ESim.Policy.Usage.Duration", kTimeSpentOnlineESim, 1);
histogram_tester_->ExpectTimeBucketCount(kESimFeatureUsageUsetimeMetric,
kTimeSpentOnlineESim, 2);
}
TEST_F(CellularMetricsLoggerTest, CellularUsageCountDongleTest) {
SetUpMetricsLogger();
InitEthernet();
static const base::Value kTestOnlineStateValue(shill::kStateOnline);
static const base::Value kTestIdleStateValue(shill::kStateIdle);
// Should not log state if no cellular devices are available.
task_environment_.FastForwardBy(
CellularMetricsLogger::kInitializationTimeout);
histogram_tester_->ExpectTotalCount(kPSimUsageCountHistogram, 0);
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(kPSimUsageCountHistogram, 0);
// Should log state if a new cellular device is plugged in.
InitCellular();
task_environment_.FastForwardBy(
CellularMetricsLogger::kInitializationTimeout);
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kNotConnected, 1);
// Should log connected state for cellular device that was plugged in.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
kTestOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedWithOtherNetwork, 1);
// Should log connected as only network state for cellular device
// that was plugged in.
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimUsageCountHistogram,
CellularMetricsLogger::CellularUsage::kConnectedAndOnlyNetwork, 1);
// Should not log state if cellular device is unplugged.
RemoveCellular();
service_client_test()->SetServiceProperty(
kTestEthServicePath, shill::kStateProperty, kTestIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(kPSimUsageCountHistogram, 3);
}
TEST_F(CellularMetricsLoggerTest, CellularESimProfileStatusAtLoginTest) {
SetUpMetricsLogger();
// Should defer logging when there are no cellular networks.
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_OWNER);
histogram_tester_->ExpectTotalCount(kESimStatusAtLoginHistogram, 0);
// Should wait until initialization timeout before logging status.
InitCellular();
histogram_tester_->ExpectTotalCount(kESimStatusAtLoginHistogram, 0);
task_environment_.FastForwardBy(
CellularMetricsLogger::kInitializationTimeout);
histogram_tester_->ExpectBucketCount(
kESimStatusAtLoginHistogram,
CellularMetricsLogger::ESimProfileStatus::kNoProfiles, 1);
ClearEuicc();
AddESimProfile(hermes::profile::State::kActive, kTestPSimCellularServicePath);
ResetLogin();
histogram_tester_->ExpectBucketCount(
kESimStatusAtLoginHistogram,
CellularMetricsLogger::ESimProfileStatus::kActive, 1);
ClearEuicc();
AddESimProfile(hermes::profile::State::kInactive,
kTestPSimCellularServicePath);
ResetLogin();
histogram_tester_->ExpectBucketCount(
kESimStatusAtLoginHistogram,
CellularMetricsLogger::ESimProfileStatus::kActive, 2);
ClearEuicc();
AddESimProfile(hermes::profile::State::kActive, kTestPSimCellularServicePath);
AddESimProfile(hermes::profile::State::kPending,
kTestESimCellularServicePath);
ResetLogin();
histogram_tester_->ExpectBucketCount(
kESimStatusAtLoginHistogram,
CellularMetricsLogger::ESimProfileStatus::kActiveWithPendingProfiles, 1);
ClearEuicc();
AddESimProfile(hermes::profile::State::kInactive,
kTestPSimCellularServicePath);
AddESimProfile(hermes::profile::State::kPending,
kTestESimCellularServicePath);
ResetLogin();
histogram_tester_->ExpectBucketCount(
kESimStatusAtLoginHistogram,
CellularMetricsLogger::ESimProfileStatus::kActiveWithPendingProfiles, 2);
ClearEuicc();
AddESimProfile(hermes::profile::State::kPending,
kTestESimCellularServicePath);
ResetLogin();
histogram_tester_->ExpectBucketCount(
kESimStatusAtLoginHistogram,
CellularMetricsLogger::ESimProfileStatus::kPendingProfilesOnly, 1);
}
TEST_F(CellularMetricsLoggerTest, CellularPSimActivationStateAtLoginTest) {
SetUpMetricsLogger();
// Should defer logging when there are no cellular networks.
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_OWNER);
histogram_tester_->ExpectTotalCount(kPSimStatusAtLoginHistogram, 0);
// Should wait until initialization timeout before logging status.
InitCellular();
histogram_tester_->ExpectTotalCount(kPSimStatusAtLoginHistogram, 0);
task_environment_.FastForwardBy(
CellularMetricsLogger::kInitializationTimeout);
histogram_tester_->ExpectBucketCount(
kPSimStatusAtLoginHistogram,
CellularMetricsLogger::PSimActivationState::kNotActivated, 1);
// Should log immediately when networks are already initialized.
ResetLogin();
histogram_tester_->ExpectBucketCount(
kPSimStatusAtLoginHistogram,
CellularMetricsLogger::PSimActivationState::kNotActivated, 2);
// Should log activated state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateActivated));
base::RunLoop().RunUntilIdle();
ResetLogin();
histogram_tester_->ExpectBucketCount(
kPSimStatusAtLoginHistogram,
CellularMetricsLogger::PSimActivationState::kActivated, 1);
// Should not log when the logged in user is neither owner nor regular.
LoginState::Get()->SetLoggedInState(
LoginState::LoggedInState::LOGGED_IN_ACTIVE,
LoginState::LoggedInUserType::LOGGED_IN_USER_KIOSK_APP);
histogram_tester_->ExpectTotalCount(kPSimStatusAtLoginHistogram, 3);
}
TEST_F(CellularMetricsLoggerTest, CellularConnectResult) {
SetUpMetricsLogger();
InitCellular();
const base::Value kFailure(shill::kStateFailure);
const base::Value kAssocStateValue(shill::kStateAssociation);
ResetHistogramTester();
AddESimProfile(hermes::profile::State::kActive, kTestESimCellularServicePath);
// Set cellular networks to connecting state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kAssocStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kAssocStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kAssocStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 0);
// Set cellular networks to failed state.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateFailure));
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateFailure));
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateFailure));
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 2);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 1);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 1);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kUnknown, 2);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kUnknown, 1);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kUnknown, 1);
histogram_tester_->ExpectBucketCount(
kESimFeatureUsageMetric,
static_cast<int>(
feature_usage::FeatureUsageMetrics::Event::kUsedWithFailure),
2);
// Set cellular networks to connecting state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kAssocStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kAssocStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kAssocStateValue);
base::RunLoop().RunUntilIdle();
// Set cellular networks to connected state.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOnline));
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOnline));
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOnline));
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 4);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 2);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 2);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kSuccess, 2);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kSuccess, 1);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kSuccess, 1);
histogram_tester_->ExpectBucketCount(
kESimFeatureUsageMetric,
static_cast<int>(
feature_usage::FeatureUsageMetrics::Event::kUsedWithSuccess),
1);
// Set cellular networks to disconnected state.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOffline));
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOffline));
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOffline));
base::RunLoop().RunUntilIdle();
// A connected to disconnected state change should not impact connection
// success.
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 4);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 2);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 2);
// Set cellular networks to connected state.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOnline));
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOnline));
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateOnline));
base::RunLoop().RunUntilIdle();
// A disconnected to connected state, skipping the connecting state change
// should emit a success.
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 6);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 3);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 3);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kSuccess, 4);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kSuccess, 2);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram,
CellularMetricsLogger::ShillConnectResult::kSuccess, 2);
// User initiated connection histograms should be 0 the entire time because
// the previous connection state changes occured from Shill.
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimUserInitiatedConnectionResultHistogram, 0);
}
TEST_F(CellularMetricsLoggerTest, CancellationDuringConnecting) {
SetUpMetricsLogger();
InitCellular();
ResetHistogramTester();
base::RunLoop().RunUntilIdle();
AddESimProfile(hermes::profile::State::kActive, kTestESimCellularServicePath);
// Set cellular networks to connecting state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty,
base::Value(shill::kStateAssociation));
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty,
base::Value(shill::kStateAssociation));
service_client_test()->SetServiceProperty(
kTestESimPolicyCellularServicePath, shill::kStateProperty,
base::Value(shill::kStateAssociation));
base::RunLoop().RunUntilIdle();
// Simulate chrome disconnect request.
cellular_metrics_logger()->DisconnectRequested(kTestESimCellularServicePath);
cellular_metrics_logger()->DisconnectRequested(
kTestESimPolicyCellularServicePath);
cellular_metrics_logger()->DisconnectRequested(kTestPSimCellularServicePath);
// Set cellular networks to failed state via shill.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateIdle));
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateIdle));
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateIdle));
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 0);
// Set cellular networks to connecting state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty,
base::Value(shill::kStateAssociation));
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty,
base::Value(shill::kStateAssociation));
service_client_test()->SetServiceProperty(
kTestESimPolicyCellularServicePath, shill::kStateProperty,
base::Value(shill::kStateAssociation));
base::RunLoop().RunUntilIdle();
// Set cellular networks to failed state via shill.
service_client_test()->SetServiceProperty(kTestPSimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateIdle));
service_client_test()->SetServiceProperty(kTestESimCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateIdle));
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
base::Value(shill::kStateIdle));
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram, 0);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimAllConnectionResultHistogram, 2);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kESimPolicyAllConnectionResultHistogram, 1);
histogram_tester_->ExpectTotalCount(
CellularMetricsLogger::kPSimAllConnectionResultHistogram, 1);
}
TEST_F(CellularMetricsLoggerTest, UserInitiatedConnectionResult) {
SetUpMetricsLogger();
InitCellular();
ResetHistogramTester();
base::RunLoop().RunUntilIdle();
// Simulate chrome connect success
cellular_metrics_logger()->ConnectSucceeded(kTestPSimCellularServicePath);
cellular_metrics_logger()->ConnectSucceeded(kTestESimCellularServicePath);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram,
CellularMetricsLogger::ConnectResult::kSuccess, 1);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kPSimUserInitiatedConnectionResultHistogram,
CellularMetricsLogger::ConnectResult::kSuccess, 1);
// Simulate chrome connect failure
cellular_metrics_logger()->ConnectFailed(
kTestESimCellularServicePath,
NetworkConnectionHandler::kErrorConnectCanceled);
cellular_metrics_logger()->ConnectFailed(
kTestPSimCellularServicePath,
NetworkConnectionHandler::kErrorConnectCanceled);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kESimUserInitiatedConnectionResultHistogram,
CellularMetricsLogger::ConnectResult::kCanceled, 1);
histogram_tester_->ExpectBucketCount(
CellularMetricsLogger::kPSimUserInitiatedConnectionResultHistogram,
CellularMetricsLogger::ConnectResult::kCanceled, 1);
}
TEST_F(CellularMetricsLoggerTest, CellularTimeToConnectedTest) {
SetUpMetricsLogger();
constexpr base::TimeDelta kTestConnectionTime = base::Milliseconds(321);
InitCellular();
const base::Value kOnlineStateValue(shill::kStateOnline);
const base::Value kAssocStateValue(shill::kStateAssociation);
AddESimProfile(hermes::profile::State::kActive, kTestESimCellularServicePath);
// Should not log connection time when not activated.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kAssocStateValue);
base::RunLoop().RunUntilIdle();
task_environment_.FastForwardBy(kTestConnectionTime);
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTotalCount(kPSimTimeToConnectedHistogram, 0);
// Set cellular networks to activated state and connecting state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateActivated));
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kActivationStateProperty,
base::Value(shill::kActivationStateActivated));
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kAssocStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kAssocStateValue);
base::RunLoop().RunUntilIdle();
// Should log first network's connection time independently.
task_environment_.FastForwardBy(kTestConnectionTime);
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTimeBucketCount(kPSimTimeToConnectedHistogram,
kTestConnectionTime, 1);
// Should log second network's connection time independently.
task_environment_.FastForwardBy(kTestConnectionTime);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectTimeBucketCount(kESimTimeToConnectedHistogram,
2 * kTestConnectionTime, 1);
}
TEST_F(CellularMetricsLoggerTest, CellularDisconnectionsTest) {
SetUpMetricsLogger();
InitCellular();
base::Value kOnlineStateValue(shill::kStateOnline);
base::Value kIdleStateValue(shill::kStateIdle);
AddESimProfile(hermes::profile::State::kActive, kTestESimCellularServicePath);
// Should log connected state.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kOnlineStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kConnected, 1);
histogram_tester_->ExpectBucketCount(
kESimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kConnected, 2);
histogram_tester_->ExpectBucketCount(
kESimPolicyDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kConnected, 1);
// Should not log user initiated disconnections.
cellular_metrics_logger()->DisconnectRequested(kTestPSimCellularServicePath);
cellular_metrics_logger()->DisconnectRequested(kTestESimCellularServicePath);
cellular_metrics_logger()->DisconnectRequested(
kTestESimPolicyCellularServicePath);
task_environment_.FastForwardBy(
CellularMetricsLogger::kDisconnectRequestTimeout / 2);
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kIdleStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kIdleStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 0);
histogram_tester_->ExpectBucketCount(
kESimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 0);
histogram_tester_->ExpectBucketCount(
kESimPolicyDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 0);
// Should log non user initiated disconnects.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kOnlineStateValue);
base::RunLoop().RunUntilIdle();
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kIdleStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kIdleStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 1);
histogram_tester_->ExpectBucketCount(
kESimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 2);
histogram_tester_->ExpectBucketCount(
kESimPolicyDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 1);
// Should log non user initiated disconnects when a previous
// disconnect request timed out.
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kOnlineStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kOnlineStateValue);
base::RunLoop().RunUntilIdle();
cellular_metrics_logger()->DisconnectRequested(kTestPSimCellularServicePath);
cellular_metrics_logger()->DisconnectRequested(kTestESimCellularServicePath);
cellular_metrics_logger()->DisconnectRequested(
kTestESimPolicyCellularServicePath);
task_environment_.FastForwardBy(
CellularMetricsLogger::kDisconnectRequestTimeout * 2);
service_client_test()->SetServiceProperty(
kTestPSimCellularServicePath, shill::kStateProperty, kIdleStateValue);
service_client_test()->SetServiceProperty(
kTestESimCellularServicePath, shill::kStateProperty, kIdleStateValue);
service_client_test()->SetServiceProperty(kTestESimPolicyCellularServicePath,
shill::kStateProperty,
kIdleStateValue);
base::RunLoop().RunUntilIdle();
histogram_tester_->ExpectBucketCount(
kPSimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 2);
histogram_tester_->ExpectBucketCount(
kESimDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 4);
histogram_tester_->ExpectBucketCount(
kESimPolicyDisconnectionsHistogram,
CellularMetricsLogger::ConnectionState::kDisconnected, 2);
}
} // namespace chromeos