commit 3402cf119541d1b9cca88fe0621d4b2c5193afdb
author Nico Weber <thakis@chromium.org> Wed Oct 28 03:57:10 2015
committer Nico Weber <thakis@chromium.org> Wed Oct 28 03:59:32 2015
tree bf799a37d04692815d9eaa9d5626b1a9716ada79
parent 7ebc49b160c2a26750a1677d207f01d93aac24a8

clang/win: Fix -Wunused-function warnings after https://codereview.chromium.org/1420003004/

Fixes:

..\..\components/leveldb_proto/proto_database_impl.h(102,6) : error: unused
function 'InitFromTaskRunner' [-Werror,-Wunused-function]
void InitFromTaskRunner(LevelDB* database, const base::FilePath& database_dir,
     ^
..\..\components/leveldb_proto/proto_database_impl.h(110,6) : error: unused
function 'DestroyFromTaskRunner' [-Werror,-Wunused-function]
void DestroyFromTaskRunner(const base::FilePath& database_dir, bool* success) {
     ^

Defining non-inline functions in a .h file generally can't work, so the
warning pointed at bad code here.

BUG=82385
TBR=jianli

Review URL: https://codereview.chromium.org/1422313003 .

Cr-Commit-Position: refs/heads/master@{#356509}

components/leveldb_proto/proto_database_impl.h

diff --git a/components/leveldb_proto/proto_database_impl.h b/components/leveldb_proto/proto_database_impl.h
index 163396c2..56ccff45 100644
--- a/components/leveldb_proto/proto_database_impl.h
+++ b/components/leveldb_proto/proto_database_impl.h
@@ -99,15 +99,17 @@
   callback.Run(*success);
 }
 
-void InitFromTaskRunner(LevelDB* database, const base::FilePath& database_dir,
-                        bool* success) {
+inline void InitFromTaskRunner(LevelDB* database,
+                               const base::FilePath& database_dir,
+                               bool* success) {
   DCHECK(success);
 
   // TODO(cjhopman): Histogram for database size.
   *success = database->Init(database_dir);
 }
 
-void DestroyFromTaskRunner(const base::FilePath& database_dir, bool* success) {
+inline void DestroyFromTaskRunner(const base::FilePath& database_dir,
+                                  bool* success) {
   CHECK(success);
 
   *success = LevelDB::Destroy(database_dir);