Do not parse caption-side: left / right as valid CSS.
We don't support it, and it's confusing to claim we do.
BUG=710734
Review-Url: https://codereview.chromium.org/2821073002
Cr-Commit-Position: refs/heads/master@{#465173}
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt b/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt
index 2394e95..f14593d 100644
--- a/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt
+++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt
@@ -25,8 +25,6 @@
PASS Changing emptyCells, an independent inherited property, propagates correctly with a single style recalc.
PASS Changing captionSide, an independent inherited property, propagates correctly with a single style recalc.
PASS Changing captionSide, an independent inherited property, propagates correctly with a single style recalc.
-PASS Changing captionSide, an independent inherited property, propagates correctly with a single style recalc.
-PASS Changing captionSide, an independent inherited property, propagates correctly with a single style recalc.
PASS Changing listStylePosition, an independent inherited property, propagates correctly with a single style recalc.
PASS Changing listStylePosition, an independent inherited property, propagates correctly with a single style recalc.
PASS Changing webkitBoxDirection, an independent inherited property, propagates correctly with a single style recalc.
diff --git a/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html b/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html
index 981f81c..3445b94 100644
--- a/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html
+++ b/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html
@@ -18,7 +18,7 @@
["whiteSpace", ["normal", "pre", "pre-wrap", "pre-line", "nowrap"]],
["borderCollapse", ["separate", "collapse"]],
["emptyCells", ["show", "hide"]],
- ["captionSide", ["top", "bottom", "left", "right"]],
+ ["captionSide", ["top", "bottom"]],
["listStylePosition", ["outside", "inside"]],
["webkitBoxDirection", ["normal", "reverse"]],
["webkitPrintColorAdjust", ["economy", "exact"]],
@@ -36,7 +36,7 @@
// style recalc.
for (i = 0; i < num_keywords; i++) {
var value1 = keywords[i];
- // Use the next keyword in the list, or if it is the last one, wrap around and
+ // Use the next keyword in the list, or if it is the last one, wrap around and
// use the first.
var value2 = keywords[(i + 1) % num_keywords];
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index eccec54..a3217e9b 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -843,7 +843,7 @@
inherited: true,
default_value: "top",
field_template: "keyword",
- keywords: ["top", "bottom", "left", "right"],
+ keywords: ["top", "bottom"],
},
{
name: "caret-color",
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
index 677a497..aa30b74 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
@@ -536,8 +536,7 @@
return value_id == CSSValueAuto || value_id == CSSValueDynamic ||
value_id == CSSValueStatic;
case CSSPropertyCaptionSide:
- return value_id == CSSValueLeft || value_id == CSSValueRight ||
- value_id == CSSValueTop || value_id == CSSValueBottom;
+ return value_id == CSSValueTop || value_id == CSSValueBottom;
case CSSPropertyClear:
return value_id == CSSValueNone || value_id == CSSValueLeft ||
value_id == CSSValueRight || value_id == CSSValueBoth;
