Google Git
Sign in
chromium / chromium / src.git / 4e1b7bc3 / . / components / omnibox / browser / omnibox_edit_model_unittest.cc
blob: aa8a4e29ec50379108eb28e0a9efa33b410ad478 [file] [log] [blame]
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/omnibox/browser/omnibox_edit_model.h"
#include <stddef.h>
#include <memory>
#include <string>
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "components/dom_distiller/core/url_constants.h"
#include "components/dom_distiller/core/url_utils.h"
#include "components/omnibox/browser/autocomplete_controller.h"
#include "components/omnibox/browser/autocomplete_match.h"
#include "components/omnibox/browser/omnibox_popup_view.h"
#include "components/omnibox/browser/omnibox_prefs.h"
#include "components/omnibox/browser/omnibox_view.h"
#include "components/omnibox/browser/search_provider.h"
#include "components/omnibox/browser/test_location_bar_model.h"
#include "components/omnibox/browser/test_omnibox_client.h"
#include "components/omnibox/browser/test_omnibox_edit_controller.h"
#include "components/omnibox/browser/test_omnibox_edit_model.h"
#include "components/omnibox/browser/test_omnibox_view.h"
#include "components/omnibox/browser/test_scheme_classifier.h"
#include "components/omnibox/common/omnibox_features.h"
#include "components/prefs/testing_pref_service.h"
#include "components/url_formatter/url_fixer.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/metrics_proto/omnibox_event.pb.h"
#include "ui/base/window_open_disposition.h"
#include "ui/gfx/geometry/rect.h"
using metrics::OmniboxEventProto;
using Selection = OmniboxPopupSelection;
namespace {
class TestOmniboxPopupView : public OmniboxPopupView {
public:
~TestOmniboxPopupView() override = default;
bool IsOpen() const override { return false; }
void InvalidateLine(size_t line) override {}
void UpdatePopupAppearance() override {}
void ProvideButtonFocusHint(size_t line) override {}
void OnMatchIconUpdated(size_t match_index) override {}
void OnDragCanceled() override {}
};
} // namespace
class OmniboxEditModelTest : public testing::Test {
public:
void SetUp() override {
// The #omnibox-site-search-starter-pack feature flag has to be enabled
// before set up in order for the OpenTabProvider to be initialized (needed
// for OpenTabMatch test).
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(omnibox::kSiteSearchStarterPack);
controller_ = std::make_unique<TestOmniboxEditController>();
view_ = std::make_unique<TestOmniboxView>(controller_.get());
view_->SetModel(std::make_unique<TestOmniboxEditModel>(
view_.get(), controller_.get(), nullptr));
}
TestOmniboxView* view() { return view_.get(); }
TestLocationBarModel* location_bar_model() {
return controller_->GetLocationBarModel();
}
TestOmniboxEditModel* model() {
return static_cast<TestOmniboxEditModel*>(view_->model());
}
protected:
base::test::TaskEnvironment task_environment_;
std::unique_ptr<TestOmniboxEditController> controller_;
std::unique_ptr<TestOmniboxView> view_;
};
// Tests various permutations of AutocompleteModel::AdjustTextForCopy.
TEST_F(OmniboxEditModelTest, AdjustTextForCopy) {
struct Data {
const char* url_for_editing;
const int sel_start;
const char* match_destination_url;
const bool is_match_selected_in_popup;
const char* input;
const char* expected_output;
const bool write_url;
const char* expected_url;
const char* url_for_display = "";
} input[] = {
// Test that http:// is inserted if all text is selected.
{"a.de/b", 0, "", false, "a.de/b", "http://a.de/b", true,
"http://a.de/b"},
// Test that http:// and https:// are inserted if the host is selected.
{"a.de/b", 0, "", false, "a.de/", "http://a.de/", true, "http://a.de/"},
{"https://a.de/b", 0, "", false, "https://a.de/", "https://a.de/", true,
"https://a.de/"},
// Tests that http:// is inserted if the path is modified.
{"a.de/b", 0, "", false, "a.de/c", "http://a.de/c", true,
"http://a.de/c"},
// Tests that http:// isn't inserted if the host is modified.
{"a.de/b", 0, "", false, "a.com/b", "a.com/b", false, ""},
// Tests that http:// isn't inserted if the start of the selection is 1.
{"a.de/b", 1, "", false, "a.de/b", "a.de/b", false, ""},
// Tests that http:// isn't inserted if a portion of the host is selected.
{"a.de/", 0, "", false, "a.d", "a.d", false, ""},
// Tests that http:// isn't inserted if the user adds to the host.
{"a.de/", 0, "", false, "a.de.com/", "a.de.com/", false, ""},
// Tests that we don't get double schemes if the user manually inserts
// a scheme.
{"a.de/", 0, "", false, "http://a.de/", "http://a.de/", true,
"http://a.de/"},
{"a.de/", 0, "", false, "HTtp://a.de/", "http://a.de/", true,
"http://a.de/"},
{"https://a.de/", 0, "", false, "https://a.de/", "https://a.de/", true,
"https://a.de/"},
// Test that we don't get double schemes or revert the change if the user
// manually changes the scheme from 'http://' to 'https://' or vice versa.
{"a.de/", 0, "", false, "https://a.de/", "https://a.de/", true,
"https://a.de/"},
{"https://a.de/", 0, "", false, "http://a.de/", "http://a.de/", true,
"http://a.de/"},
// Makes sure intranet urls get 'http://' prefixed to them.
{"b/foo", 0, "", false, "b/foo", "http://b/foo", true, "http://b/foo",
"b/foo"},
// Verifies a search term 'foo' doesn't end up with http.
{"www.google.com/search?", 0, "", false, "foo", "foo", false, ""},
// Verifies that http:// and https:// are inserted for a match in a popup.
{"a.com", 0, "http://b.com/foo", true, "b.com/foo", "http://b.com/foo",
true, "http://b.com/foo"},
{"a.com", 0, "https://b.com/foo", true, "b.com/foo", "https://b.com/foo",
true, "https://b.com/foo"},
// Even if the popup is open, if the input text doesn't correspond to the
// current match, ignore the current match.
{"a.com/foo", 0, "https://b.com/foo", true, "a.com/foo", "a.com/foo",
false, "a.com/foo"},
{"https://b.com/foo", 0, "https://b.com/foo", true, "https://b.co",
"https://b.co", false, "https://b.co"},
// Verifies that no scheme is inserted if there is no valid match.
{"a.com", 0, "", true, "b.com/foo", "b.com/foo", false, ""},
// Steady State Elisions test for re-adding an elided 'https://'.
{"https://a.de/b", 0, "", false, "a.de/b", "https://a.de/b", true,
"https://a.de/b", "a.de/b"},
// Verifies that non-ASCII characters are %-escaped for valid copied URLs,
// as long as the host has not been modified from the page URL.
{"https://ja.wikipedia.org/wiki/目次", 0, "", false,
"https://ja.wikipedia.org/wiki/目次",
"https://ja.wikipedia.org/wiki/%E7%9B%AE%E6%AC%A1", true,
"https://ja.wikipedia.org/wiki/%E7%9B%AE%E6%AC%A1"},
// Test escaping when part of the path was not copied.
{"https://ja.wikipedia.org/wiki/目次", 0, "", false,
"https://ja.wikipedia.org/wiki/ç›®",
"https://ja.wikipedia.org/wiki/%E7%9B%AE", true,
"https://ja.wikipedia.org/wiki/%E7%9B%AE"},
// Correctly handle escaping in the scheme-elided case as well.
{"https://ja.wikipedia.org/wiki/目次", 0, "", false,
"ja.wikipedia.org/wiki/目次",
"https://ja.wikipedia.org/wiki/%E7%9B%AE%E6%AC%A1", true,
"https://ja.wikipedia.org/wiki/%E7%9B%AE%E6%AC%A1",
"ja.wikipedia.org/wiki/目次"},
// Don't escape when host was modified.
{"https://ja.wikipedia.org/wiki/目次", 0, "", false,
"https://wikipedia.org/wiki/目次", "https://wikipedia.org/wiki/目次",
false, ""},
};
for (size_t i = 0; i < std::size(input); ++i) {
location_bar_model()->set_formatted_full_url(
base::UTF8ToUTF16(input[i].url_for_editing));
location_bar_model()->set_url_for_display(
base::UTF8ToUTF16(input[i].url_for_display));
// Set the location bar model's URL to be a valid GURL that would generate
// the test case's url_for_editing.
location_bar_model()->set_url(
url_formatter::FixupURL(input[i].url_for_editing, ""));
model()->ResetDisplayTexts();
model()->SetInputInProgress(input[i].is_match_selected_in_popup);
model()->SetPopupIsOpen(input[i].is_match_selected_in_popup);
AutocompleteMatch match;
match.type = AutocompleteMatchType::NAVSUGGEST;
match.destination_url = GURL(input[i].match_destination_url);
model()->SetCurrentMatchForTest(match);
std::u16string result = base::UTF8ToUTF16(input[i].input);
GURL url;
bool write_url;
model()->AdjustTextForCopy(input[i].sel_start, &result, &url, &write_url);
EXPECT_EQ(base::UTF8ToUTF16(input[i].expected_output), result)
<< "@: " << i;
EXPECT_EQ(input[i].write_url, write_url) << " @" << i;
if (write_url)
EXPECT_EQ(input[i].expected_url, url.spec()) << " @" << i;
}
}
// Tests that AdjustTextForCopy behaves properly for Reader Mode URLs.
TEST_F(OmniboxEditModelTest, AdjustTextForCopyReaderMode) {
const GURL article_url("https://www.example.com/article.html");
const GURL distiller_url =
dom_distiller::url_utils::GetDistillerViewUrlFromUrl(
dom_distiller::kDomDistillerScheme, article_url, "title");
// In ReaderMode, the URL is chrome-distiller://<hash>,
// but the user should only see the original URL minus the scheme.
location_bar_model()->set_url(distiller_url);
model()->ResetDisplayTexts();
std::u16string result = base::UTF8ToUTF16(distiller_url.spec());
GURL url;
bool write_url = false;
model()->AdjustTextForCopy(0, &result, &url, &write_url);
EXPECT_EQ(base::ASCIIToUTF16(article_url.spec()), result);
EXPECT_EQ(article_url, url);
EXPECT_TRUE(write_url);
}
TEST_F(OmniboxEditModelTest, DISABLED_InlineAutocompleteText) {
// Test if the model updates the inline autocomplete text in the view.
EXPECT_EQ(std::u16string(), view()->inline_autocompletion());
model()->SetUserText(u"he");
model()->OnPopupDataChanged(std::u16string(),
/*is_temporary_text=*/false, u"llo",
std::u16string(), std::u16string(), false,
std::u16string());
EXPECT_EQ(u"hello", view()->GetText());
EXPECT_EQ(u"llo", view()->inline_autocompletion());
std::u16string text_before = u"he";
std::u16string text_after = u"hel";
OmniboxView::StateChanges state_changes{
&text_before, &text_after, 3, 3, false, true, false, false};
model()->OnAfterPossibleChange(state_changes, true);
EXPECT_EQ(std::u16string(), view()->inline_autocompletion());
model()->OnPopupDataChanged(std::u16string(),
/*is_temporary_text=*/false, u"lo",
std::u16string(), std::u16string(), false,
std::u16string());
EXPECT_EQ(u"hello", view()->GetText());
EXPECT_EQ(u"lo", view()->inline_autocompletion());
model()->Revert();
EXPECT_EQ(std::u16string(), view()->GetText());
EXPECT_EQ(std::u16string(), view()->inline_autocompletion());
model()->SetUserText(u"he");
model()->OnPopupDataChanged(std::u16string(),
/*is_temporary_text=*/false, u"llo",
std::u16string(), std::u16string(), false,
std::u16string());
EXPECT_EQ(u"hello", view()->GetText());
EXPECT_EQ(u"llo", view()->inline_autocompletion());
model()->AcceptTemporaryTextAsUserText();
EXPECT_EQ(u"hello", view()->GetText());
EXPECT_EQ(std::u16string(), view()->inline_autocompletion());
}
// iOS doesn't use elisions in the Omnibox textfield.
#if !BUILDFLAG(IS_IOS)
TEST_F(OmniboxEditModelTest, RespectUnelisionInZeroSuggest) {
location_bar_model()->set_url(GURL("https://www.example.com/"));
location_bar_model()->set_url_for_display(u"example.com");
EXPECT_TRUE(model()->ResetDisplayTexts());
model()->Revert();
// Set up view with unelided text.
EXPECT_EQ(u"example.com", view()->GetText());
EXPECT_TRUE(model()->Unelide());
EXPECT_EQ(u"https://www.example.com/", view()->GetText());
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(view()->IsSelectAll());
// Test that we don't clobber the unelided text with inline autocomplete text.
EXPECT_EQ(std::u16string(), view()->inline_autocompletion());
model()->StartZeroSuggestRequest();
model()->OnPopupDataChanged(std::u16string(), /*is_temporary_text=*/false,
std::u16string(), std::u16string(),
std::u16string(), false, std::u16string());
EXPECT_EQ(u"https://www.example.com/", view()->GetText());
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(view()->IsSelectAll());
}
#endif // !BUILDFLAG(IS_IOS)
TEST_F(OmniboxEditModelTest, RevertZeroSuggestTemporaryText) {
location_bar_model()->set_url(GURL("https://www.example.com/"));
location_bar_model()->set_url_for_display(u"https://www.example.com/");
EXPECT_TRUE(model()->ResetDisplayTexts());
model()->Revert();
// Simulate getting ZeroSuggestions and arrowing to a different match.
view()->SelectAll(true);
model()->StartZeroSuggestRequest();
model()->OnPopupDataChanged(u"fake_temporary_text",
/*is_temporary_text=*/true, std::u16string(),
std::u16string(), std::u16string(), false,
std::u16string());
// Test that reverting brings back the original input text.
EXPECT_TRUE(model()->OnEscapeKeyPressed());
EXPECT_EQ(u"https://www.example.com/", view()->GetText());
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(view()->IsSelectAll());
}
// This verifies the fix for a bug where calling OpenMatch() with a valid
// alternate nav URL would fail a DCHECK if the input began with "http://".
// The failure was due to erroneously trying to strip the scheme from the
// resulting fill_into_edit. Alternate nav matches are never shown, so there's
// no need to ever try and strip this scheme.
TEST_F(OmniboxEditModelTest, AlternateNavHasHTTP) {
AutocompleteMatch match(model()->autocomplete_controller()->search_provider(),
0, false,
AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED);
// |match.destination_url| has to be set to ensure that OnAutocompleteAccept
// is called and |alternate_nav_match| is populated.
match.destination_url = GURL("https://foo/");
const GURL alternate_nav_url("http://abcd/");
model()->OnSetFocus(false); // Avoids DCHECK in OpenMatch().
model()->SetUserText(u"http://abcd");
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
alternate_nav_url, std::u16string(), 0);
EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
controller_->alternate_nav_match().fill_into_edit));
model()->SetUserText(u"abcd");
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB,
alternate_nav_url, std::u16string(), 0);
EXPECT_TRUE(AutocompleteInput::HasHTTPScheme(
controller_->alternate_nav_match().fill_into_edit));
}
TEST_F(OmniboxEditModelTest, CurrentMatch) {
// Test the HTTP case.
{
location_bar_model()->set_url(GURL("http://www.example.com/"));
location_bar_model()->set_url_for_display(u"example.com");
model()->ResetDisplayTexts();
model()->Revert();
// iOS doesn't do elision in the textfield view.
#if BUILDFLAG(IS_IOS)
EXPECT_EQ(u"http://www.example.com/", view()->GetText());
#else
EXPECT_EQ(u"example.com", view()->GetText());
#endif
AutocompleteMatch match = model()->CurrentMatch(nullptr);
EXPECT_EQ(AutocompleteMatchType::URL_WHAT_YOU_TYPED, match.type);
EXPECT_TRUE(model()->CurrentTextIsURL());
EXPECT_EQ("http://www.example.com/", match.destination_url.spec());
}
// Test that generating a match from an elided HTTPS URL doesn't drop the
// secure scheme.
{
location_bar_model()->set_url(GURL("https://www.google.com/"));
location_bar_model()->set_url_for_display(u"google.com");
model()->ResetDisplayTexts();
model()->Revert();
// iOS doesn't do elision in the textfield view.
#if BUILDFLAG(IS_IOS)
EXPECT_EQ(u"https://www.google.com/", view()->GetText());
#else
EXPECT_EQ(u"google.com", view()->GetText());
#endif
AutocompleteMatch match = model()->CurrentMatch(nullptr);
EXPECT_EQ(AutocompleteMatchType::URL_WHAT_YOU_TYPED, match.type);
EXPECT_TRUE(model()->CurrentTextIsURL());
// Additionally verify we aren't accidentally dropping the HTTPS scheme.
EXPECT_EQ("https://www.google.com/", match.destination_url.spec());
}
}
TEST_F(OmniboxEditModelTest, DisplayText) {
location_bar_model()->set_url(GURL("https://www.example.com/"));
location_bar_model()->set_url_for_display(u"example.com");
EXPECT_TRUE(model()->ResetDisplayTexts());
model()->Revert();
EXPECT_TRUE(model()->CurrentTextIsURL());
#if BUILDFLAG(IS_IOS)
// iOS OmniboxEditModel always provides the full URL as the OmniboxView
// permanent display text. Unelision should return false.
EXPECT_EQ(u"https://www.example.com/", model()->GetPermanentDisplayText());
EXPECT_EQ(u"https://www.example.com/", view()->GetText());
EXPECT_FALSE(model()->Unelide());
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_FALSE(view()->IsSelectAll());
#else
// Verify we can unelide and show the full URL properly.
EXPECT_EQ(u"example.com", model()->GetPermanentDisplayText());
EXPECT_EQ(u"example.com", view()->GetText());
EXPECT_TRUE(model()->Unelide());
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(view()->IsSelectAll());
#endif
EXPECT_EQ(u"https://www.example.com/", view()->GetText());
EXPECT_TRUE(model()->CurrentTextIsURL());
// We should still show the current page's icon until the URL is modified.
EXPECT_TRUE(model()->ShouldShowCurrentPageIcon());
view()->SetUserText(u"something else");
EXPECT_FALSE(model()->ShouldShowCurrentPageIcon());
}
TEST_F(OmniboxEditModelTest, UnelideDoesNothingWhenFullURLAlreadyShown) {
location_bar_model()->set_url(GURL("https://www.example.com/"));
location_bar_model()->set_url_for_display(u"https://www.example.com/");
EXPECT_TRUE(model()->ResetDisplayTexts());
model()->Revert();
EXPECT_EQ(u"https://www.example.com/", model()->GetPermanentDisplayText());
EXPECT_TRUE(model()->CurrentTextIsURL());
// Verify Unelide does nothing.
EXPECT_FALSE(model()->Unelide());
EXPECT_EQ(u"https://www.example.com/", view()->GetText());
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_FALSE(view()->IsSelectAll());
EXPECT_TRUE(model()->CurrentTextIsURL());
EXPECT_TRUE(model()->ShouldShowCurrentPageIcon());
}
// The tab-switching system sometimes focuses the Omnibox even if it was not
// previously focused. In those cases, ignore the saved focus state.
TEST_F(OmniboxEditModelTest, IgnoreInvalidSavedFocusStates) {
// The Omnibox starts out unfocused. Save that state.
ASSERT_FALSE(model()->has_focus());
OmniboxEditModel::State state = model()->GetStateForTabSwitch();
ASSERT_EQ(OMNIBOX_FOCUS_NONE, state.focus_state);
// Simulate the tab-switching system focusing the Omnibox.
model()->OnSetFocus(false);
// Restoring the old saved state should not clobber the model's focus state.
model()->RestoreState(&state);
EXPECT_TRUE(model()->has_focus());
EXPECT_TRUE(model()->is_caret_visible());
}
// Tests ConsumeCtrlKey() consumes ctrl key when down, but does not affect ctrl
// state otherwise.
TEST_F(OmniboxEditModelTest, ConsumeCtrlKey) {
model()->control_key_state_ = TestOmniboxEditModel::UP;
model()->ConsumeCtrlKey();
EXPECT_EQ(model()->control_key_state_, TestOmniboxEditModel::UP);
model()->control_key_state_ = TestOmniboxEditModel::DOWN;
model()->ConsumeCtrlKey();
EXPECT_EQ(model()->control_key_state_,
TestOmniboxEditModel::DOWN_AND_CONSUMED);
model()->ConsumeCtrlKey();
EXPECT_EQ(model()->control_key_state_,
TestOmniboxEditModel::DOWN_AND_CONSUMED);
}
// Tests ctrl_key_state_ is set consumed if the ctrl key is down on focus.
TEST_F(OmniboxEditModelTest, ConsumeCtrlKeyOnRequestFocus) {
model()->control_key_state_ = TestOmniboxEditModel::DOWN;
model()->OnSetFocus(false);
EXPECT_EQ(model()->control_key_state_, TestOmniboxEditModel::UP);
model()->OnSetFocus(true);
EXPECT_EQ(model()->control_key_state_,
TestOmniboxEditModel::DOWN_AND_CONSUMED);
}
// Tests the ctrl key is consumed on a ctrl-action (e.g. ctrl-c to copy)
TEST_F(OmniboxEditModelTest, ConsumeCtrlKeyOnCtrlAction) {
model()->control_key_state_ = TestOmniboxEditModel::DOWN;
OmniboxView::StateChanges state_changes{nullptr, nullptr, 0, 0,
false, false, false, false};
model()->OnAfterPossibleChange(state_changes, false);
EXPECT_EQ(model()->control_key_state_,
TestOmniboxEditModel::DOWN_AND_CONSUMED);
}
TEST_F(OmniboxEditModelTest, KeywordModePreservesInlineAutocompleteText) {
// Set the edit model into an inline autocompletion state.
view()->SetUserText(u"user");
view()->OnInlineAutocompleteTextMaybeChanged(u"user text", {{9, 4}}, u"",
u" test");
// Entering keyword search mode should preserve the full display text as the
// user text, and select all.
model()->EnterKeywordModeForDefaultSearchProvider(
OmniboxEventProto::KEYBOARD_SHORTCUT);
EXPECT_EQ(u"user text", model()->GetUserTextForTesting());
EXPECT_EQ(u"user text", view()->GetText());
EXPECT_TRUE(view()->IsSelectAll());
// Deleting the user text (exiting keyword) mode should clear everything.
view()->SetUserText(std::u16string());
{
EXPECT_TRUE(view()->GetText().empty());
EXPECT_TRUE(model()->GetUserTextForTesting().empty());
size_t start = 0, end = 0;
view()->GetSelectionBounds(&start, &end);
EXPECT_EQ(0U, start);
EXPECT_EQ(0U, end);
}
}
TEST_F(OmniboxEditModelTest, KeywordModePreservesTemporaryText) {
// Set the edit model into a temporary text state.
view()->SetUserText(u"user text");
GURL destination_url("http://example.com");
// OnPopupDataChanged() is called when the user focuses a suggestion.
model()->OnPopupDataChanged(u"match text",
/*is_temporary_text=*/true, std::u16string(),
std::u16string(), std::u16string(), false,
std::u16string());
// Entering keyword search mode should preserve temporary text as the user
// text, and select all.
model()->EnterKeywordModeForDefaultSearchProvider(
OmniboxEventProto::KEYBOARD_SHORTCUT);
EXPECT_EQ(u"match text", model()->GetUserTextForTesting());
EXPECT_EQ(u"match text", view()->GetText());
EXPECT_TRUE(view()->IsSelectAll());
}
TEST_F(OmniboxEditModelTest, CtrlEnterNavigatesToDesiredTLD) {
// Set the edit model into an inline autocomplete state.
view()->SetUserText(u"foo");
model()->StartAutocomplete(false, false);
view()->OnInlineAutocompleteTextMaybeChanged(u"foobar", {{6, 3}}, u"",
u"bar");
model()->OnControlKeyChanged(true);
model()->AcceptInput(WindowOpenDisposition::UNKNOWN);
OmniboxEditModel::State state = model()->GetStateForTabSwitch();
EXPECT_EQ(GURL("http://www.foo.com/"),
state.autocomplete_input.canonicalized_url());
}
TEST_F(OmniboxEditModelTest, CtrlEnterNavigatesToDesiredTLDTemporaryText) {
// But if it's the temporary text, the View text should be used.
view()->SetUserText(u"foo");
model()->StartAutocomplete(false, false);
model()->OnPopupDataChanged(u"foobar",
/*is_temporary_text=*/true, std::u16string(),
std::u16string(), std::u16string(), false,
std::u16string());
model()->OnControlKeyChanged(true);
model()->AcceptInput(WindowOpenDisposition::UNKNOWN);
OmniboxEditModel::State state = model()->GetStateForTabSwitch();
EXPECT_EQ(GURL("http://www.foobar.com/"),
state.autocomplete_input.canonicalized_url());
}
TEST_F(OmniboxEditModelTest,
CtrlEnterNavigatesToDesiredTLDSteadyStateElisions) {
location_bar_model()->set_url(GURL("https://www.example.com/"));
location_bar_model()->set_url_for_display(u"example.com");
EXPECT_TRUE(model()->ResetDisplayTexts());
model()->Revert();
model()->OnControlKeyChanged(true);
model()->AcceptInput(WindowOpenDisposition::UNKNOWN);
OmniboxEditModel::State state = model()->GetStateForTabSwitch();
EXPECT_EQ(GURL("https://www.example.com/"),
state.autocomplete_input.canonicalized_url());
}
///////////////////////////////////////////////////////////////////////////////
// Popup-related tests
class OmniboxEditModelPopupTest : public ::testing::Test {
public:
OmniboxEditModelPopupTest()
: view_(&controller_), model_(&view_, &controller_, &pref_service_) {
omnibox::RegisterProfilePrefs(pref_service_.registry());
model_.set_popup_view(&popup_view_);
model_.SetPopupIsOpen(true);
}
OmniboxEditModelPopupTest(const OmniboxEditModelPopupTest&) = delete;
OmniboxEditModelPopupTest& operator=(const OmniboxEditModelPopupTest&) =
delete;
TestingPrefServiceSimple* pref_service() { return &pref_service_; }
TestOmniboxEditModel* model() { return &model_; }
private:
base::test::TaskEnvironment task_environment_;
TestOmniboxEditController controller_;
TestingPrefServiceSimple pref_service_;
TestOmniboxView view_;
TestOmniboxEditModel model_;
TestOmniboxPopupView popup_view_;
};
// This verifies that the new treatment of the user's selected match in
// |SetSelectedLine()| with removed |AutocompleteResult::Selection::empty()|
// is correct in the face of various replacement versions of |empty()|.
TEST_F(OmniboxEditModelPopupTest, SetSelectedLine) {
ACMatches matches;
for (size_t i = 0; i < 2; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.keyword = u"match";
match.allowed_to_be_default_match = true;
matches.push_back(match);
}
auto* result = &model()->autocomplete_controller()->result_;
AutocompleteInput input(u"match", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_TRUE(model()->IsPopupSelectionOnInitialLine());
model()->SetPopupSelection(Selection(0), true, false);
EXPECT_TRUE(model()->IsPopupSelectionOnInitialLine());
model()->SetPopupSelection(Selection(0), false, false);
EXPECT_TRUE(model()->IsPopupSelectionOnInitialLine());
}
TEST_F(OmniboxEditModelPopupTest, SetSelectedLineWithNoDefaultMatches) {
// Creates a set of matches with NO matches allowed to be default.
ACMatches matches;
for (size_t i = 0; i < 2; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.keyword = u"match";
matches.push_back(match);
}
auto* result = &model()->autocomplete_controller()->result_;
AutocompleteInput input(u"match", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(Selection::kNoMatch, model()->GetPopupSelection().line);
EXPECT_TRUE(model()->IsPopupSelectionOnInitialLine());
model()->SetPopupSelection(Selection(0), false, false);
EXPECT_EQ(0U, model()->GetPopupSelection().line);
EXPECT_FALSE(model()->IsPopupSelectionOnInitialLine());
model()->SetPopupSelection(Selection(1), false, false);
EXPECT_EQ(1U, model()->GetPopupSelection().line);
EXPECT_FALSE(model()->IsPopupSelectionOnInitialLine());
model()->ResetPopupToInitialState();
EXPECT_EQ(Selection::kNoMatch, model()->GetPopupSelection().line);
EXPECT_TRUE(model()->IsPopupSelectionOnInitialLine());
}
TEST_F(OmniboxEditModelPopupTest, PopupPositionChanging) {
ACMatches matches;
for (size_t i = 0; i < 3; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.keyword = u"match";
match.allowed_to_be_default_match = true;
matches.push_back(match);
}
auto* result = &model()->autocomplete_controller()->result_;
AutocompleteInput input(u"match", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(0u, model()->GetPopupSelection().line);
// Test moving and wrapping down.
for (size_t n : {1, 2, 0}) {
model()->OnUpOrDownKeyPressed(1);
EXPECT_EQ(n, model()->GetPopupSelection().line);
}
// And down.
for (size_t n : {2, 1, 0}) {
model()->OnUpOrDownKeyPressed(-1);
EXPECT_EQ(n, model()->GetPopupSelection().line);
}
}
TEST_F(OmniboxEditModelPopupTest, PopupStepSelection) {
ACMatches matches;
for (size_t i = 0; i < 6; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.keyword = u"match";
match.allowed_to_be_default_match = true;
matches.push_back(match);
}
// Make match index 1 deletable to verify we can step to that.
matches[1].deletable = true;
// Make match index 2 only have an associated keyword to verify we can step
// backwards into keyword search mode if keyword search button is enabled.
matches[2].associated_keyword =
std::make_unique<AutocompleteMatch>(matches.back());
// Make match index 3 have an associated keyword, tab match, and deletable to
// verify keyword mode doesn't override tab match and remove suggestion
// buttons (as it does with button row disabled)
matches[3].associated_keyword =
std::make_unique<AutocompleteMatch>(matches.back());
matches[3].has_tab_match = true;
matches[3].deletable = true;
// Make match index 4 have a suggestion_group_id to test header behavior.
const auto kNewGroupId = omnibox::GroupId::POLARIS_RESERVED_1;
matches[4].suggestion_group_id = kNewGroupId;
// Make match index 5 have a suggestion_group_id but no header text.
matches[5].suggestion_group_id = omnibox::GroupId::HISTORY_CLUSTER;
auto* result = &model()->autocomplete_controller()->result_;
result->AppendMatches(matches);
SuggestionGroupsMap suggestion_groups_map;
suggestion_groups_map[kNewGroupId].group_config_info.set_header_text(
"header");
suggestion_groups_map[omnibox::GroupId::HISTORY_CLUSTER]
.group_config_info.set_header_text("");
// Do not set the original_group_id on purpose to test that default visibility
// can be safely queried via AutocompleteResult::IsSuggestionGroupHidden().
result->MergeSuggestionGroupsMap(suggestion_groups_map);
AutocompleteInput input(u"match", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(0u, model()->GetPopupSelection().line);
// Step by lines forward.
for (size_t n : {1, 2, 3, 4, 5, 0}) {
model()->StepPopupSelection(Selection::kForward, Selection::kWholeLine);
EXPECT_EQ(n, model()->GetPopupSelection().line);
}
// Step by lines backward.
for (size_t n : {5, 4, 3, 2, 1, 0}) {
model()->StepPopupSelection(Selection::kBackward, Selection::kWholeLine);
EXPECT_EQ(n, model()->GetPopupSelection().line);
}
// Step by states forward.
for (auto selection : {
Selection(1, Selection::NORMAL),
Selection(1, Selection::FOCUSED_BUTTON_REMOVE_SUGGESTION),
Selection(2, Selection::NORMAL),
Selection(2, Selection::KEYWORD_MODE),
Selection(3, Selection::NORMAL),
Selection(3, Selection::KEYWORD_MODE),
Selection(3, Selection::FOCUSED_BUTTON_TAB_SWITCH),
Selection(3, Selection::FOCUSED_BUTTON_REMOVE_SUGGESTION),
Selection(4, Selection::FOCUSED_BUTTON_HEADER),
Selection(4, Selection::NORMAL),
Selection(5, Selection::NORMAL),
Selection(0, Selection::NORMAL),
}) {
model()->StepPopupSelection(Selection::kForward, Selection::kStateOrLine);
EXPECT_EQ(selection, model()->GetPopupSelection());
}
// Step by states backward. Unlike prior to suggestion button row, there is
// no difference in behavior for KEYWORD mode moving forward or backward.
for (auto selection : {
Selection(5, Selection::NORMAL),
Selection(4, Selection::NORMAL),
Selection(4, Selection::FOCUSED_BUTTON_HEADER),
Selection(3, Selection::FOCUSED_BUTTON_REMOVE_SUGGESTION),
Selection(3, Selection::FOCUSED_BUTTON_TAB_SWITCH),
Selection(3, Selection::KEYWORD_MODE),
Selection(3, Selection::NORMAL),
Selection(2, Selection::KEYWORD_MODE),
Selection(2, Selection::NORMAL),
Selection(1, Selection::FOCUSED_BUTTON_REMOVE_SUGGESTION),
Selection(1, Selection::NORMAL),
Selection(0, Selection::NORMAL),
Selection(5, Selection::NORMAL),
Selection(4, Selection::NORMAL),
Selection(4, Selection::FOCUSED_BUTTON_HEADER),
Selection(3, Selection::FOCUSED_BUTTON_REMOVE_SUGGESTION),
}) {
model()->StepPopupSelection(Selection::kBackward, Selection::kStateOrLine);
EXPECT_EQ(selection, model()->GetPopupSelection());
}
// Try the kAllLines step behavior.
model()->StepPopupSelection(Selection::kBackward, Selection::kAllLines);
EXPECT_EQ(Selection(0, Selection::NORMAL), model()->GetPopupSelection());
model()->StepPopupSelection(Selection::kForward, Selection::kAllLines);
EXPECT_EQ(Selection(5, Selection::NORMAL), model()->GetPopupSelection());
}
TEST_F(OmniboxEditModelPopupTest, PopupStepSelectionWithHiddenGroupIds) {
ACMatches matches;
for (size_t i = 0; i < 4; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.keyword = u"match";
match.allowed_to_be_default_match = true;
matches.push_back(match);
}
// Hide the second two matches.
const auto kNewGroupId = omnibox::GroupId::POLARIS_RESERVED_1;
matches[2].suggestion_group_id = kNewGroupId;
matches[3].suggestion_group_id = kNewGroupId;
auto* result = &model()->autocomplete_controller()->result_;
result->AppendMatches(matches);
SuggestionGroupsMap suggestion_groups_map;
suggestion_groups_map[kNewGroupId].group_config_info.set_header_text(
"header");
suggestion_groups_map[kNewGroupId].original_group_id = 12345;
// Setting the original_group_id allows the default visibility to be set via
// AutocompleteResult::SetSuggestionGroupHidden().
result->MergeSuggestionGroupsMap(suggestion_groups_map);
result->SetSuggestionGroupHidden(pref_service(), kNewGroupId,
/*hidden=*/true);
AutocompleteInput input(u"match", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(0u, model()->GetPopupSelection().line);
// Test the simple kAllLines case.
model()->StepPopupSelection(Selection::kForward, Selection::kAllLines);
EXPECT_EQ(1u, model()->GetPopupSelection().line);
model()->StepPopupSelection(Selection::kBackward, Selection::kAllLines);
EXPECT_EQ(0u, model()->GetPopupSelection().line);
// Test the kStateOrLine case, forwards and backwards.
for (auto selection : {
Selection(1, Selection::NORMAL),
Selection(2, Selection::FOCUSED_BUTTON_HEADER),
Selection(0, Selection::NORMAL),
}) {
model()->StepPopupSelection(Selection::kForward, Selection::kStateOrLine);
EXPECT_EQ(selection, model()->GetPopupSelection());
}
for (auto selection : {
Selection(2, Selection::FOCUSED_BUTTON_HEADER),
Selection(1, Selection::NORMAL),
}) {
model()->StepPopupSelection(Selection::kBackward, Selection::kStateOrLine);
EXPECT_EQ(selection, model()->GetPopupSelection());
}
// Test the kWholeLine case, forwards and backwards.
for (auto selection : {
Selection(0, Selection::NORMAL),
Selection(1, Selection::NORMAL),
}) {
model()->StepPopupSelection(Selection::kForward, Selection::kWholeLine);
EXPECT_EQ(selection, model()->GetPopupSelection());
}
for (auto selection : {
Selection(0, Selection::NORMAL),
Selection(1, Selection::NORMAL),
}) {
model()->StepPopupSelection(Selection::kBackward, Selection::kWholeLine);
EXPECT_EQ(selection, model()->GetPopupSelection());
}
}
TEST_F(OmniboxEditModelPopupTest, PopupInlineAutocompleteAndTemporaryText) {
// Create a set of three matches "a|1" (inline autocompleted), "a2", "a3".
// The third match has a suggestion group ID.
ACMatches matches;
for (size_t i = 0; i < 3; ++i) {
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::SEARCH_SUGGEST);
match.allowed_to_be_default_match = true;
matches.push_back(match);
}
matches[0].fill_into_edit = u"a1";
matches[0].inline_autocompletion = u"1";
matches[1].fill_into_edit = u"a2";
matches[2].fill_into_edit = u"a3";
const auto kNewGroupId = omnibox::GroupId::POLARIS_RESERVED_1;
matches[2].suggestion_group_id = kNewGroupId;
auto* result = &model()->autocomplete_controller()->result_;
result->AppendMatches(matches);
SuggestionGroupsMap suggestion_groups_map;
suggestion_groups_map[kNewGroupId].group_config_info.set_header_text(
"header");
// Do not set the original_group_id on purpose to test that default visibility
// can be safely queried via AutocompleteResult::IsSuggestionGroupHidden().
result->MergeSuggestionGroupsMap(suggestion_groups_map);
AutocompleteInput input(u"a", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
// Simulate OmniboxController updating the popup, then check initial state.
model()->OnPopupDataChanged(std::u16string(),
/*is_temporary_text=*/false, u"1",
std::u16string(), std::u16string(), false,
std::u16string());
EXPECT_EQ(Selection(0, Selection::NORMAL), model()->GetPopupSelection());
EXPECT_EQ(u"1", model()->text());
EXPECT_FALSE(model()->is_temporary_text());
// Tab down to second match.
model()->StepPopupSelection(Selection::kForward, Selection::kStateOrLine);
EXPECT_EQ(Selection(1, Selection::NORMAL), model()->GetPopupSelection());
EXPECT_EQ(u"a2", model()->text());
EXPECT_TRUE(model()->is_temporary_text());
// Tab down to header above the third match, expect that we have an empty
// string for our temporary text.
model()->StepPopupSelection(Selection::kForward, Selection::kStateOrLine);
EXPECT_EQ(Selection(2, Selection::FOCUSED_BUTTON_HEADER),
model()->GetPopupSelection());
EXPECT_EQ(std::u16string(), model()->text());
EXPECT_TRUE(model()->is_temporary_text());
// Now tab down to the third match, and expect that we update the temporary
// text to the third match.
model()->StepPopupSelection(Selection::kForward, Selection::kStateOrLine);
EXPECT_EQ(Selection(2, Selection::NORMAL), model()->GetPopupSelection());
EXPECT_EQ(u"a3", model()->text());
EXPECT_TRUE(model()->is_temporary_text());
// Now tab backwards to the header again, expect that we have an empty string
// for our temporary text.
model()->StepPopupSelection(Selection::kBackward, Selection::kStateOrLine);
EXPECT_EQ(Selection(2, Selection::FOCUSED_BUTTON_HEADER),
model()->GetPopupSelection());
EXPECT_EQ(std::u16string(), model()->text());
EXPECT_TRUE(model()->is_temporary_text());
// Now tab backwards to the second match, expect we update the temporary text
// to the second match.
model()->StepPopupSelection(Selection::kBackward, Selection::kStateOrLine);
EXPECT_EQ(Selection(1, Selection::NORMAL), model()->GetPopupSelection());
EXPECT_EQ(u"a2", model()->text());
EXPECT_TRUE(model()->is_temporary_text());
}
// Makes sure focus remains on the tab switch button when nothing changes,
// and leaves when it does. Exercises the ratcheting logic in
// OmniboxEditModel::OnPopupResultChanged().
TEST_F(OmniboxEditModelPopupTest, TestFocusFixing) {
ACMatches matches;
AutocompleteMatch match(nullptr, 1000, false,
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
match.contents = u"match1.com";
match.destination_url = GURL("http://match1.com");
match.allowed_to_be_default_match = true;
match.has_tab_match = true;
matches.push_back(match);
auto* result = &model()->autocomplete_controller()->result_;
AutocompleteInput input(u"match", metrics::OmniboxEventProto::NTP,
TestSchemeClassifier());
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
model()->SetPopupSelection(Selection(0), true, false);
// The default state should be unfocused.
EXPECT_EQ(Selection::NORMAL, model()->GetPopupSelection().state);
// Focus the selection.
model()->SetPopupSelection(
Selection(0, Selection::FOCUSED_BUTTON_TAB_SWITCH));
EXPECT_EQ(Selection::FOCUSED_BUTTON_TAB_SWITCH,
model()->GetPopupSelection().state);
// Adding a match at end won't change that we selected first suggestion, so
// shouldn't change focused state.
matches[0].relevance = 999;
// Give it a different name so not deduped.
matches[0].contents = u"match2.com";
matches[0].destination_url = GURL("http://match2.com");
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(Selection::FOCUSED_BUTTON_TAB_SWITCH,
model()->GetPopupSelection().state);
// Changing selection should change focused state.
model()->SetPopupSelection(Selection(1));
EXPECT_EQ(Selection::NORMAL, model()->GetPopupSelection().state);
// Adding a match at end will reset selection to first, so should change
// selected line, and thus focus.
model()->SetPopupSelection(Selection(model()->GetPopupSelection().line,
Selection::FOCUSED_BUTTON_TAB_SWITCH));
matches[0].relevance = 999;
matches[0].contents = u"match3.com";
matches[0].destination_url = GURL("http://match3.com");
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(0U, model()->GetPopupSelection().line);
EXPECT_EQ(Selection::NORMAL, model()->GetPopupSelection().state);
// Prepending a match won't change selection, but since URL is different,
// should clear the focus state.
model()->SetPopupSelection(Selection(model()->GetPopupSelection().line,
Selection::FOCUSED_BUTTON_TAB_SWITCH));
matches[0].relevance = 1100;
matches[0].contents = u"match4.com";
matches[0].destination_url = GURL("http://match4.com");
result->AppendMatches(matches);
result->SortAndCull(input, nullptr);
model()->OnPopupResultChanged();
EXPECT_EQ(0U, model()->GetPopupSelection().line);
EXPECT_EQ(Selection::NORMAL, model()->GetPopupSelection().state);
// Selecting |kNoMatch| should clear focus.
model()->SetPopupSelection(Selection(model()->GetPopupSelection().line,
Selection::FOCUSED_BUTTON_TAB_SWITCH));
model()->SetPopupSelection(Selection(Selection::kNoMatch));
model()->OnPopupResultChanged();
EXPECT_EQ(Selection::NORMAL, model()->GetPopupSelection().state);
}
TEST_F(OmniboxEditModelTest, OmniboxEscapeHistogram) {
{
// With both `kClosePopupWithEscape` and `kBlurWithEscape` enabled, escape
// should incrementally revert temporary text, close the popup, clear input,
// and blur the omnibox.
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures(
{omnibox::kClosePopupWithEscape, omnibox::kBlurWithEscape}, {});
AutocompleteMatch match;
match.type = AutocompleteMatchType::NAVSUGGEST;
match.destination_url = GURL("https://google.com");
model()->SetCurrentMatchForTest(match);
view()->SetUserText(u"user text");
model()->OnSetFocus(false);
model()->SetInputInProgress(true);
model()->SetPopupIsOpen(true);
model()->OnPopupDataChanged(/*temporary_text=*/u"fake_temporary_text",
/*is_temporary_text=*/true, std::u16string(),
std::u16string(), std::u16string(), false,
std::u16string());
EXPECT_TRUE(model()->HasTemporaryText());
EXPECT_TRUE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"fake_temporary_text");
EXPECT_TRUE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
{
// Revert temporary text.
base::HistogramTester histogram_tester;
EXPECT_TRUE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 1, 1);
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_TRUE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_TRUE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
}
{
// Close the popup.
base::HistogramTester histogram_tester;
EXPECT_TRUE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 2, 1);
model()->SetPopupIsOpen(
false); // `TestOmniboxEditModel` stubs the popup.
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_FALSE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_TRUE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
}
{
// Clear user input.
base::HistogramTester histogram_tester;
EXPECT_TRUE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 3, 1);
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_FALSE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
}
{
// Blur the omnibox.
base::HistogramTester histogram_tester;
EXPECT_TRUE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 5, 1);
model()->OnKillFocus(); // `TestOmniboxEditModel` stubs the client which
// handles blurring the omnibox.
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_FALSE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_FALSE(model()->has_focus());
}
}
{
// With both `kClosePopupWithEscape` and `kBlurWithEscape` disabled, escape
// should incrementally revert temporary text then simultaneously close the
// popup & clear input.
base::test::ScopedFeatureList feature_list;
feature_list.InitWithFeatures(
{}, {omnibox::kClosePopupWithEscape, omnibox::kBlurWithEscape});
AutocompleteMatch match;
match.type = AutocompleteMatchType::NAVSUGGEST;
match.destination_url = GURL("https://google.com");
model()->SetCurrentMatchForTest(match);
view()->SetUserText(u"user text");
model()->OnSetFocus(false);
model()->SetInputInProgress(true);
model()->SetPopupIsOpen(true);
model()->OnPopupDataChanged(/*temporary_text=*/u"fake_temporary_text",
/*is_temporary_text=*/true, std::u16string(),
std::u16string(), std::u16string(), false,
std::u16string());
EXPECT_TRUE(model()->HasTemporaryText());
EXPECT_TRUE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"fake_temporary_text");
EXPECT_TRUE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
{
// Revert temporary text.
base::HistogramTester histogram_tester;
EXPECT_TRUE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 1, 1);
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_TRUE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_TRUE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
}
{
// Close the popup & clear input.
base::HistogramTester histogram_tester;
EXPECT_TRUE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 4, 1);
model()->SetPopupIsOpen(
false); // `TestOmniboxEditModel` stubs the popup.
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_FALSE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
}
{
// Should not handle the key press.
base::HistogramTester histogram_tester;
EXPECT_FALSE(model()->OnEscapeKeyPressed());
histogram_tester.ExpectUniqueSample("Omnibox.Escape", 0, 1);
model()->SetPopupIsOpen(
false); // `TestOmniboxEditModel` stubs the popup.
EXPECT_FALSE(model()->HasTemporaryText());
EXPECT_FALSE(model()->PopupIsOpen());
EXPECT_EQ(view()->GetText(), u"");
EXPECT_FALSE(model()->user_input_in_progress());
EXPECT_TRUE(model()->has_focus());
}
}
}
#if !(BUILDFLAG(IS_IOS) || BUILDFLAG(IS_ANDROID))
// The keyword mode feature is only available on Desktop. Do not test on mobile.
TEST_F(OmniboxEditModelTest, OpenTabMatch) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(omnibox::kSiteSearchStarterPack);
// When the match comes from the Open Tab Provider while in keyword mode,
// the disposition should be set to SWITCH_TO_TAB.
AutocompleteMatch match(
model()->autocomplete_controller()->open_tab_provider(), 0, false,
AutocompleteMatchType::OPEN_TAB);
match.destination_url = GURL("https://foo/");
match.from_keyword = true;
model()->OnSetFocus(false); // Avoids DCHECK in OpenMatch().
model()->SetUserText(u"http://abcd");
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB, GURL(),
std::u16string(), 0);
EXPECT_EQ(controller_->disposition(), WindowOpenDisposition::SWITCH_TO_TAB);
// Suggestions not from the Open Tab Provider or not from keyword mode should
// not change the disposition.
match.from_keyword = false;
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB, GURL(),
std::u16string(), 0);
EXPECT_EQ(controller_->disposition(), WindowOpenDisposition::CURRENT_TAB);
match.provider = model()->autocomplete_controller()->search_provider();
match.from_keyword = true;
model()->OpenMatch(match, WindowOpenDisposition::CURRENT_TAB, GURL(),
std::u16string(), 0);
EXPECT_EQ(controller_->disposition(), WindowOpenDisposition::CURRENT_TAB);
}
#endif // !(BUILDFLAG(IS_IOS) || BUILDFLAG(IS_ANDROID))