| From 646352396b3879f156c342846a52230fffaa3e21 Mon Sep 17 00:00:00 2001 |
| From: Manuel Rego Casasnovas <rego@igalia.com> |
| Date: Mon, 15 May 2017 14:01:09 +0200 |
| Subject: [PATCH] Avoid flakiness on external/wpt/css/css-ui-3/outline-004.html |
| |
| This patch uses "ahem" instead of "Ahem" to avoid flakiness |
| on outline-004.html test. And removes it from TestExpectations. |
| |
| At the same time it adds a new test font-family-case-insensitive.html |
| using "ahem" to verify the behavior described on the spec: |
| https://drafts.csswg.org/css-fonts-3/#font-family-casing |
| |
| It's expected that this new test starts to be flaky on Windows |
| bots, so it'd should be flagged on TestExpectations once that happens, |
| and a specific bug should be reported. |
| |
| BUG=719299 |
| |
| Change-Id: Ic14b7a7d8f0db0c0c9a5501dd91032cd2758549b |
| --- |
| |
| diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations |
| index c4a04d1..38d47ac 100644 |
| --- a/third_party/WebKit/LayoutTests/TestExpectations |
| +++ b/third_party/WebKit/LayoutTests/TestExpectations |
| @@ -3368,4 +3368,3 @@ |
| |
| # Layout Tests on Swarming (Windows) - https://crbug.com/717347 |
| crbug.com/719298 [ Win ] fast/dnd/dropEffect-for-effectAllowed.html [ Failure Pass Timeout ] |
| -crbug.com/719299 [ Win ] external/wpt/css/css-ui-3/outline-004.html [ Failure Pass Timeout ] |
| diff --git a/third_party/WebKit/LayoutTests/external/wpt/css/css-ui-3/outline-004.html b/third_party/WebKit/LayoutTests/external/wpt/css/css-ui-3/outline-004.html |
| index c9e8dcb..7c4cc3a 100644 |
| --- a/third_party/WebKit/LayoutTests/external/wpt/css/css-ui-3/outline-004.html |
| +++ b/third_party/WebKit/LayoutTests/external/wpt/css/css-ui-3/outline-004.html |
| @@ -20,7 +20,7 @@ |
| line-height: 40px; |
| font-size: 40px; |
| background: red; |
| - font-family: ahem; |
| + font-family: Ahem; |
| } |
| </style> |
| |
| diff --git a/third_party/WebKit/LayoutTests/fast/css/font-family-case-insensitive-expected.html b/third_party/WebKit/LayoutTests/fast/css/font-family-case-insensitive-expected.html |
| new file mode 100644 |
| index 0000000..e8b1544 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/css/font-family-case-insensitive-expected.html |
| @@ -0,0 +1,13 @@ |
| +<!DOCTYPE html> |
| +<meta charset="utf-8"> |
| +<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com"> |
| +<style> |
| + div { |
| + width: 100px; |
| + height: 100px; |
| + background: green; |
| + } |
| +</style> |
| +<p>This test checks that font-family is case insensitive.</p> |
| +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> |
| +<div></div> |
| diff --git a/third_party/WebKit/LayoutTests/fast/css/font-family-case-insensitive.html b/third_party/WebKit/LayoutTests/fast/css/font-family-case-insensitive.html |
| new file mode 100644 |
| index 0000000..27eefe7 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/css/font-family-case-insensitive.html |
| @@ -0,0 +1,17 @@ |
| +<!DOCTYPE html> |
| +<meta charset="utf-8"> |
| +<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com"> |
| +<link rel="match" href="font-family-case-insensitive-expected.html"> |
| +<style> |
| + div { |
| + width: 100px; |
| + height: 100px; |
| + background: red; |
| + color: green; |
| + font-size: 100px; |
| + font-family: ahem; |
| + } |
| +</style> |
| +<p>This test checks that font-family is case insensitive.</p> |
| +<p>Test passes if there is a filled green square and <strong>no red</strong>.</p> |
| +<div>X</div> |
