| // Copyright 2015 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "base/task/sequence_manager/task_queue_selector.h" |
| |
| #include <stddef.h> |
| |
| #include <map> |
| #include <memory> |
| #include <set> |
| #include <utility> |
| #include <vector> |
| |
| #include "base/bind.h" |
| #include "base/macros.h" |
| #include "base/memory/ptr_util.h" |
| #include "base/pending_task.h" |
| #include "base/task/sequence_manager/task_queue_impl.h" |
| #include "base/task/sequence_manager/test/mock_time_domain.h" |
| #include "base/task/sequence_manager/work_queue.h" |
| #include "base/task/sequence_manager/work_queue_sets.h" |
| #include "base/test/metrics/histogram_tester.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| |
| using testing::_; |
| |
| namespace base { |
| namespace sequence_manager { |
| namespace internal { |
| // To avoid symbol collisions in jumbo builds. |
| namespace task_queue_selector_unittest { |
| |
| class MockObserver : public TaskQueueSelector::Observer { |
| public: |
| MockObserver() = default; |
| ~MockObserver() override = default; |
| |
| MOCK_METHOD1(OnTaskQueueEnabled, void(internal::TaskQueueImpl*)); |
| |
| private: |
| DISALLOW_COPY_AND_ASSIGN(MockObserver); |
| }; |
| |
| class TaskQueueSelectorForTest : public TaskQueueSelector { |
| public: |
| using TaskQueueSelector::TaskQueueSelector; |
| using TaskQueueSelector::prioritizing_selector_for_test; |
| using TaskQueueSelector::PrioritizingSelector; |
| using TaskQueueSelector::SetImmediateStarvationCountForTest; |
| |
| // Returns the number of highest priority tasks needed to starve high priority |
| // task. |
| static constexpr size_t NumberOfHighestPriorityToStarveHighPriority() { |
| return (kMaxHighPriorityStarvationScore + |
| kSmallScoreIncrementForHighPriorityStarvation - 1) / |
| kSmallScoreIncrementForHighPriorityStarvation; |
| } |
| |
| // Returns the number of highest priority tasks needed to starve normal |
| // priority tasks. |
| static constexpr size_t NumberOfHighestPriorityToStarveNormalPriority() { |
| return (kMaxNormalPriorityStarvationScore + |
| kSmallScoreIncrementForNormalPriorityStarvation - 1) / |
| kSmallScoreIncrementForNormalPriorityStarvation; |
| } |
| |
| // Returns the number of high priority tasks needed to starve normal priority |
| // tasks. |
| static constexpr size_t NumberOfHighPriorityToStarveNormalPriority() { |
| return (kMaxNormalPriorityStarvationScore + |
| kLargeScoreIncrementForNormalPriorityStarvation - 1) / |
| kLargeScoreIncrementForNormalPriorityStarvation; |
| } |
| |
| // Returns the number of highest priority tasks needed to starve low priority |
| // ones. |
| static constexpr size_t NumberOfHighestPriorityToStarveLowPriority() { |
| return (kMaxLowPriorityStarvationScore + |
| kSmallScoreIncrementForLowPriorityStarvation - 1) / |
| kSmallScoreIncrementForLowPriorityStarvation; |
| } |
| |
| // Returns the number of high/normal priority tasks needed to starve low |
| // priority ones. |
| static constexpr size_t NumberOfHighAndNormalPriorityToStarveLowPriority() { |
| return (kMaxLowPriorityStarvationScore + |
| kLargeScoreIncrementForLowPriorityStarvation - 1) / |
| kLargeScoreIncrementForLowPriorityStarvation; |
| } |
| }; |
| |
| class TaskQueueSelectorTest : public testing::Test { |
| public: |
| TaskQueueSelectorTest() |
| : test_closure_(BindRepeating(&TaskQueueSelectorTest::TestFunction)), |
| associated_thread_(AssociatedThreadId::CreateBound()), |
| selector_(associated_thread_) {} |
| ~TaskQueueSelectorTest() override = default; |
| |
| TaskQueueSelectorForTest::PrioritizingSelector* prioritizing_selector() { |
| return selector_.prioritizing_selector_for_test(); |
| } |
| |
| WorkQueueSets* delayed_work_queue_sets() { |
| return prioritizing_selector()->delayed_work_queue_sets(); |
| } |
| WorkQueueSets* immediate_work_queue_sets() { |
| return prioritizing_selector()->immediate_work_queue_sets(); |
| } |
| |
| void PushTasks(const size_t queue_indices[], size_t num_tasks) { |
| std::set<size_t> changed_queue_set; |
| EnqueueOrder::Generator enqueue_order_generator; |
| for (size_t i = 0; i < num_tasks; i++) { |
| changed_queue_set.insert(queue_indices[i]); |
| task_queues_[queue_indices[i]]->immediate_work_queue()->Push( |
| TaskQueueImpl::Task(TaskQueue::PostedTask(test_closure_, FROM_HERE), |
| TimeTicks(), EnqueueOrder(), |
| enqueue_order_generator.GenerateNext())); |
| } |
| } |
| |
| void PushTasksWithEnqueueOrder(const size_t queue_indices[], |
| const size_t enqueue_orders[], |
| size_t num_tasks) { |
| std::set<size_t> changed_queue_set; |
| for (size_t i = 0; i < num_tasks; i++) { |
| changed_queue_set.insert(queue_indices[i]); |
| task_queues_[queue_indices[i]]->immediate_work_queue()->Push( |
| TaskQueueImpl::Task( |
| TaskQueue::PostedTask(test_closure_, FROM_HERE), TimeTicks(), |
| EnqueueOrder(), |
| EnqueueOrder::FromIntForTesting(enqueue_orders[i]))); |
| } |
| } |
| |
| std::vector<size_t> PopTasks() { |
| std::vector<size_t> order; |
| WorkQueue* chosen_work_queue; |
| while (selector_.SelectWorkQueueToService(&chosen_work_queue)) { |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| order.push_back(chosen_queue_index); |
| chosen_work_queue->PopTaskForTesting(); |
| immediate_work_queue_sets()->OnPopQueue(chosen_work_queue); |
| } |
| return order; |
| } |
| |
| static void TestFunction() {} |
| |
| protected: |
| void SetUp() final { |
| time_domain_ = std::make_unique<MockTimeDomain>(TimeTicks() + |
| TimeDelta::FromSeconds(1)); |
| for (size_t i = 0; i < kTaskQueueCount; i++) { |
| std::unique_ptr<TaskQueueImpl> task_queue = |
| std::make_unique<TaskQueueImpl>(nullptr, time_domain_.get(), |
| TaskQueue::Spec("test")); |
| selector_.AddQueue(task_queue.get()); |
| task_queues_.push_back(std::move(task_queue)); |
| } |
| for (size_t i = 0; i < kTaskQueueCount; i++) { |
| EXPECT_EQ(TaskQueue::kNormalPriority, task_queues_[i]->GetQueuePriority()) |
| << i; |
| queue_to_index_map_.insert(std::make_pair(task_queues_[i].get(), i)); |
| } |
| histogram_tester_.reset(new HistogramTester()); |
| } |
| |
| void TearDown() final { |
| for (std::unique_ptr<TaskQueueImpl>& task_queue : task_queues_) { |
| // Note since this test doesn't have a SequenceManager we need to |
| // manually remove |task_queue| from the |selector_|. Normally |
| // UnregisterTaskQueue would do that. |
| selector_.RemoveQueue(task_queue.get()); |
| task_queue->UnregisterTaskQueue(); |
| } |
| } |
| |
| std::unique_ptr<TaskQueueImpl> NewTaskQueueWithBlockReporting() { |
| return std::make_unique<TaskQueueImpl>(nullptr, time_domain_.get(), |
| TaskQueue::Spec("test")); |
| } |
| |
| const size_t kTaskQueueCount = 5; |
| RepeatingClosure test_closure_; |
| scoped_refptr<AssociatedThreadId> associated_thread_; |
| TaskQueueSelectorForTest selector_; |
| std::unique_ptr<TimeDomain> time_domain_; |
| std::vector<std::unique_ptr<TaskQueueImpl>> task_queues_; |
| std::map<TaskQueueImpl*, size_t> queue_to_index_map_; |
| std::unique_ptr<HistogramTester> histogram_tester_; |
| }; |
| |
| TEST_F(TaskQueueSelectorTest, TestDefaultPriority) { |
| size_t queue_order[] = {4, 3, 2, 1, 0}; |
| PushTasks(queue_order, 5); |
| EXPECT_THAT(PopTasks(), testing::ElementsAre(4, 3, 2, 1, 0)); |
| EXPECT_EQ(histogram_tester_->GetBucketCount( |
| "TaskQueueSelector.TaskServicedPerSelectorLogic", |
| static_cast<int>(TaskQueueSelectorLogic::kNormalPriorityLogic)), |
| 5); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestHighestPriority) { |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| selector_.SetQueuePriority(task_queues_[2].get(), |
| TaskQueue::kHighestPriority); |
| EXPECT_THAT(PopTasks(), ::testing::ElementsAre(2, 0, 1, 3, 4)); |
| EXPECT_EQ( |
| histogram_tester_->GetBucketCount( |
| "TaskQueueSelector.TaskServicedPerSelectorLogic", |
| static_cast<int>(TaskQueueSelectorLogic::kHighestPriorityLogic)), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestHighPriority) { |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| selector_.SetQueuePriority(task_queues_[2].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| selector_.SetQueuePriority(task_queues_[0].get(), TaskQueue::kLowPriority); |
| EXPECT_THAT(PopTasks(), ::testing::ElementsAre(2, 1, 3, 4, 0)); |
| EXPECT_EQ(histogram_tester_->GetBucketCount( |
| "TaskQueueSelector.TaskServicedPerSelectorLogic", |
| static_cast<int>(TaskQueueSelectorLogic::kHighPriorityLogic)), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestLowPriority) { |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| selector_.SetQueuePriority(task_queues_[2].get(), TaskQueue::kLowPriority); |
| EXPECT_THAT(PopTasks(), testing::ElementsAre(0, 1, 3, 4, 2)); |
| EXPECT_EQ(histogram_tester_->GetBucketCount( |
| "TaskQueueSelector.TaskServicedPerSelectorLogic", |
| static_cast<int>(TaskQueueSelectorLogic::kLowPriorityLogic)), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestBestEffortPriority) { |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kBestEffortPriority); |
| selector_.SetQueuePriority(task_queues_[2].get(), TaskQueue::kLowPriority); |
| selector_.SetQueuePriority(task_queues_[3].get(), |
| TaskQueue::kHighestPriority); |
| EXPECT_THAT(PopTasks(), ::testing::ElementsAre(3, 1, 4, 2, 0)); |
| EXPECT_EQ( |
| histogram_tester_->GetBucketCount( |
| "TaskQueueSelector.TaskServicedPerSelectorLogic", |
| static_cast<int>(TaskQueueSelectorLogic::kBestEffortPriorityLogic)), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestControlPriority) { |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| selector_.SetQueuePriority(task_queues_[4].get(), |
| TaskQueue::kControlPriority); |
| EXPECT_EQ(TaskQueue::kControlPriority, task_queues_[4]->GetQueuePriority()); |
| selector_.SetQueuePriority(task_queues_[2].get(), |
| TaskQueue::kHighestPriority); |
| EXPECT_EQ(TaskQueue::kHighestPriority, task_queues_[2]->GetQueuePriority()); |
| EXPECT_THAT(PopTasks(), ::testing::ElementsAre(4, 2, 0, 1, 3)); |
| EXPECT_EQ( |
| histogram_tester_->GetBucketCount( |
| "TaskQueueSelector.TaskServicedPerSelectorLogic", |
| static_cast<int>(TaskQueueSelectorLogic::kControlPriorityLogic)), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestObserverWithEnabledQueue) { |
| task_queues_[1]->SetQueueEnabledForTest(false); |
| selector_.DisableQueue(task_queues_[1].get()); |
| MockObserver mock_observer; |
| selector_.SetTaskQueueSelectorObserver(&mock_observer); |
| EXPECT_CALL(mock_observer, OnTaskQueueEnabled(_)).Times(1); |
| task_queues_[1]->SetQueueEnabledForTest(true); |
| selector_.EnableQueue(task_queues_[1].get()); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, |
| TestObserverWithSetQueuePriorityAndQueueAlreadyEnabled) { |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kHighestPriority); |
| MockObserver mock_observer; |
| selector_.SetTaskQueueSelectorObserver(&mock_observer); |
| EXPECT_CALL(mock_observer, OnTaskQueueEnabled(_)).Times(0); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kNormalPriority); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestDisableEnable) { |
| MockObserver mock_observer; |
| selector_.SetTaskQueueSelectorObserver(&mock_observer); |
| |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| task_queues_[2]->SetQueueEnabledForTest(false); |
| selector_.DisableQueue(task_queues_[2].get()); |
| task_queues_[4]->SetQueueEnabledForTest(false); |
| selector_.DisableQueue(task_queues_[4].get()); |
| // Disabling a queue should not affect its priority. |
| EXPECT_EQ(TaskQueue::kNormalPriority, task_queues_[2]->GetQueuePriority()); |
| EXPECT_EQ(TaskQueue::kNormalPriority, task_queues_[4]->GetQueuePriority()); |
| EXPECT_THAT(PopTasks(), testing::ElementsAre(0, 1, 3)); |
| |
| EXPECT_CALL(mock_observer, OnTaskQueueEnabled(_)).Times(2); |
| task_queues_[2]->SetQueueEnabledForTest(true); |
| selector_.EnableQueue(task_queues_[2].get()); |
| selector_.SetQueuePriority(task_queues_[2].get(), |
| TaskQueue::kBestEffortPriority); |
| EXPECT_THAT(PopTasks(), testing::ElementsAre(2)); |
| task_queues_[4]->SetQueueEnabledForTest(true); |
| selector_.EnableQueue(task_queues_[4].get()); |
| EXPECT_THAT(PopTasks(), testing::ElementsAre(4)); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestDisableChangePriorityThenEnable) { |
| EXPECT_TRUE(task_queues_[2]->delayed_work_queue()->Empty()); |
| EXPECT_TRUE(task_queues_[2]->immediate_work_queue()->Empty()); |
| |
| task_queues_[2]->SetQueueEnabledForTest(false); |
| selector_.SetQueuePriority(task_queues_[2].get(), |
| TaskQueue::kHighestPriority); |
| |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasks(queue_order, 5); |
| |
| EXPECT_TRUE(task_queues_[2]->delayed_work_queue()->Empty()); |
| EXPECT_FALSE(task_queues_[2]->immediate_work_queue()->Empty()); |
| task_queues_[2]->SetQueueEnabledForTest(true); |
| |
| EXPECT_EQ(TaskQueue::kHighestPriority, task_queues_[2]->GetQueuePriority()); |
| EXPECT_THAT(PopTasks(), ::testing::ElementsAre(2, 0, 1, 3, 4)); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestEmptyQueues) { |
| WorkQueue* chosen_work_queue = nullptr; |
| EXPECT_FALSE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| // Test only disabled queues. |
| size_t queue_order[] = {0}; |
| PushTasks(queue_order, 1); |
| task_queues_[0]->SetQueueEnabledForTest(false); |
| selector_.DisableQueue(task_queues_[0].get()); |
| EXPECT_FALSE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| // These tests are unusual since there's no TQM. To avoid a later DCHECK when |
| // deleting the task queue, we re-enable the queue here so the selector |
| // doesn't get out of sync. |
| task_queues_[0]->SetQueueEnabledForTest(true); |
| selector_.EnableQueue(task_queues_[0].get()); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestAge) { |
| size_t enqueue_order[] = {10, 1, 2, 9, 4}; |
| size_t queue_order[] = {0, 1, 2, 3, 4}; |
| PushTasksWithEnqueueOrder(queue_order, enqueue_order, 5); |
| EXPECT_THAT(PopTasks(), testing::ElementsAre(1, 2, 4, 3, 0)); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestControlStarvesOthers) { |
| size_t queue_order[] = {0, 1, 2, 3}; |
| PushTasks(queue_order, 4); |
| selector_.SetQueuePriority(task_queues_[3].get(), |
| TaskQueue::kControlPriority); |
| selector_.SetQueuePriority(task_queues_[2].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kBestEffortPriority); |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| EXPECT_EQ(task_queues_[3].get(), chosen_work_queue->task_queue()); |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestHighestPriorityDoesNotStarveHigh) { |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| |
| size_t counts[] = {0, 0}; |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| counts[chosen_queue_index]++; |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| EXPECT_GT(counts[1], 0ul); // Check highest doesn't starve high. |
| EXPECT_GT(counts[0], counts[1]); // Check highest gets more chance to run. |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestHighestPriorityDoesNotStarveHighOrNormal) { |
| size_t queue_order[] = {0, 1, 2}; |
| PushTasks(queue_order, 3); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| |
| size_t counts[] = {0, 0, 0}; |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| counts[chosen_queue_index]++; |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check highest runs more frequently then high. |
| EXPECT_GT(counts[0], counts[1]); |
| |
| // Check high runs at least as frequently as normal. |
| EXPECT_GE(counts[1], counts[2]); |
| |
| // Check normal isn't starved. |
| EXPECT_GT(counts[2], 0ul); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, |
| TestHighestPriorityDoesNotStarveHighOrNormalOrLow) { |
| size_t queue_order[] = {0, 1, 2, 3}; |
| PushTasks(queue_order, 4); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| selector_.SetQueuePriority(task_queues_[3].get(), TaskQueue::kLowPriority); |
| |
| size_t counts[] = {0, 0, 0, 0}; |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| counts[chosen_queue_index]++; |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check highest runs more frequently then high. |
| EXPECT_GT(counts[0], counts[1]); |
| |
| // Check high runs at least as frequently as normal. |
| EXPECT_GE(counts[1], counts[2]); |
| |
| // Check normal runs more frequently than low. |
| EXPECT_GT(counts[2], counts[3]); |
| |
| // Check low isn't starved. |
| EXPECT_GT(counts[3], 0ul); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestHighPriorityDoesNotStarveNormal) { |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| |
| selector_.SetQueuePriority(task_queues_[0].get(), TaskQueue::kHighPriority); |
| |
| size_t counts[] = {0, 0, 0, 0}; |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| counts[chosen_queue_index]++; |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check high runs more frequently then normal. |
| EXPECT_GT(counts[0], counts[1]); |
| |
| // Check low isn't starved. |
| EXPECT_GT(counts[1], 0ul); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestHighPriorityDoesNotStarveNormalOrLow) { |
| size_t queue_order[] = {0, 1, 2}; |
| PushTasks(queue_order, 3); |
| selector_.SetQueuePriority(task_queues_[0].get(), TaskQueue::kHighPriority); |
| selector_.SetQueuePriority(task_queues_[2].get(), TaskQueue::kLowPriority); |
| |
| size_t counts[] = {0, 0, 0}; |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| counts[chosen_queue_index]++; |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check high runs more frequently than normal. |
| EXPECT_GT(counts[0], counts[1]); |
| |
| // Check normal runs more frequently than low. |
| EXPECT_GT(counts[1], counts[2]); |
| |
| // Check low isn't starved. |
| EXPECT_GT(counts[2], 0ul); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestNormalPriorityDoesNotStarveLow) { |
| size_t queue_order[] = {0, 1, 2}; |
| PushTasks(queue_order, 3); |
| selector_.SetQueuePriority(task_queues_[0].get(), TaskQueue::kLowPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kBestEffortPriority); |
| size_t counts[] = {0, 0, 0}; |
| for (int i = 0; i < 100; i++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| size_t chosen_queue_index = |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second; |
| counts[chosen_queue_index]++; |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| EXPECT_GT(counts[0], 0ul); // Check normal doesn't starve low. |
| EXPECT_GT(counts[2], counts[0]); // Check normal gets more chance to run. |
| EXPECT_EQ(0ul, counts[1]); // Check best effort is starved. |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestBestEffortGetsStarved) { |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kBestEffortPriority); |
| EXPECT_EQ(TaskQueue::kNormalPriority, task_queues_[1]->GetQueuePriority()); |
| |
| // Check that normal priority tasks starve best effort. |
| WorkQueue* chosen_work_queue = nullptr; |
| for (int i = 0; i < 100; i++) { |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| EXPECT_EQ(task_queues_[1].get(), chosen_work_queue->task_queue()); |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check that highest priority tasks starve best effort. |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kHighestPriority); |
| for (int i = 0; i < 100; i++) { |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| EXPECT_EQ(task_queues_[1].get(), chosen_work_queue->task_queue()); |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check that high priority tasks starve best effort. |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| for (int i = 0; i < 100; i++) { |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| EXPECT_EQ(task_queues_[1].get(), chosen_work_queue->task_queue()); |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check that low priority tasks starve best effort. |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kLowPriority); |
| for (int i = 0; i < 100; i++) { |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| EXPECT_EQ(task_queues_[1].get(), chosen_work_queue->task_queue()); |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| |
| // Check that control priority tasks starve best effort. |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kControlPriority); |
| for (int i = 0; i < 100; i++) { |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| EXPECT_EQ(task_queues_[1].get(), chosen_work_queue->task_queue()); |
| // Don't remove task from queue to simulate all queues still being full. |
| } |
| } |
| |
| TEST_F(TaskQueueSelectorTest, |
| TestHighPriorityStarvationScoreIncreasedOnlyWhenTasksArePresent) { |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kHighestPriority); |
| |
| // Run a number of highest priority tasks needed to starve high priority |
| // tasks (when present). |
| for (size_t num_tasks = 0; |
| num_tasks <= |
| TaskQueueSelectorForTest::NumberOfHighestPriorityToStarveHighPriority(); |
| num_tasks++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| // Don't remove task from queue to simulate the queue is still full. |
| } |
| |
| // Post a high priority task. |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| // Check that the high priority task is not considered starved, and thus isn't |
| // processed. |
| EXPECT_NE( |
| static_cast<int>( |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, |
| TestNormalPriorityStarvationScoreIncreasedOnllWhenTasksArePresent) { |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kHighestPriority); |
| |
| // Run a number of highest priority tasks needed to starve normal priority |
| // tasks (when present). |
| for (size_t num_tasks = 0; |
| num_tasks <= TaskQueueSelectorForTest:: |
| NumberOfHighestPriorityToStarveNormalPriority(); |
| num_tasks++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| // Don't remove task from queue to simulate the queue is still full. |
| } |
| |
| selector_.SetQueuePriority(task_queues_[0].get(), TaskQueue::kHighPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kHighPriority); |
| |
| // Run a number of high priority tasks needed to starve normal priority |
| // tasks (when present). |
| for (size_t num_tasks = 0; |
| num_tasks <= |
| TaskQueueSelectorForTest::NumberOfHighPriorityToStarveNormalPriority(); |
| num_tasks++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| // Don't remove task from queue to simulate the queue is still full. |
| } |
| |
| // Post a normal priority task. |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kNormalPriority); |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| // Check that the normal priority task is not considered starved, and thus |
| // isn't processed. |
| EXPECT_NE( |
| static_cast<int>( |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, |
| TestLowPriorityTaskStarvationOnlyIncreasedWhenTasksArePresent) { |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kHighestPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), |
| TaskQueue::kHighestPriority); |
| |
| // Run a number of highest priority tasks needed to starve low priority |
| // tasks (when present). |
| for (size_t num_tasks = 0; |
| num_tasks <= |
| TaskQueueSelectorForTest::NumberOfHighestPriorityToStarveLowPriority(); |
| num_tasks++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| // Don't remove task from queue to simulate the queue is still full. |
| } |
| |
| selector_.SetQueuePriority(task_queues_[0].get(), TaskQueue::kHighPriority); |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kNormalPriority); |
| |
| // Run a number of high/normal priority tasks needed to starve low priority |
| // tasks (when present). |
| for (size_t num_tasks = 0; |
| num_tasks <= TaskQueueSelectorForTest:: |
| NumberOfHighAndNormalPriorityToStarveLowPriority(); |
| num_tasks++) { |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| // Don't remove task from queue to simulate the queue is still full. |
| } |
| |
| // Post a low priority task. |
| selector_.SetQueuePriority(task_queues_[1].get(), TaskQueue::kLowPriority); |
| WorkQueue* chosen_work_queue = nullptr; |
| ASSERT_TRUE(selector_.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| // Check that the low priority task is not considered starved, and thus |
| // isn't processed. |
| EXPECT_NE( |
| static_cast<int>( |
| queue_to_index_map_.find(chosen_work_queue->task_queue())->second), |
| 1); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, AllEnabledWorkQueuesAreEmpty) { |
| EXPECT_TRUE(selector_.AllEnabledWorkQueuesAreEmpty()); |
| size_t queue_order[] = {0, 1}; |
| PushTasks(queue_order, 2); |
| |
| EXPECT_FALSE(selector_.AllEnabledWorkQueuesAreEmpty()); |
| PopTasks(); |
| EXPECT_TRUE(selector_.AllEnabledWorkQueuesAreEmpty()); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, AllEnabledWorkQueuesAreEmpty_ControlPriority) { |
| size_t queue_order[] = {0}; |
| PushTasks(queue_order, 1); |
| |
| selector_.SetQueuePriority(task_queues_[0].get(), |
| TaskQueue::kControlPriority); |
| |
| EXPECT_FALSE(selector_.AllEnabledWorkQueuesAreEmpty()); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, ChooseOldestWithPriority_Empty) { |
| WorkQueue* chosen_work_queue = nullptr; |
| bool chose_delayed_over_immediate = false; |
| EXPECT_FALSE(prioritizing_selector()->ChooseOldestWithPriority( |
| TaskQueue::kNormalPriority, &chose_delayed_over_immediate, |
| &chosen_work_queue)); |
| EXPECT_FALSE(chose_delayed_over_immediate); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, ChooseOldestWithPriority_OnlyDelayed) { |
| task_queues_[0]->delayed_work_queue()->Push(TaskQueueImpl::Task( |
| TaskQueue::PostedTask(test_closure_, FROM_HERE), TimeTicks(), |
| EnqueueOrder(), EnqueueOrder::FromIntForTesting(2))); |
| |
| WorkQueue* chosen_work_queue = nullptr; |
| bool chose_delayed_over_immediate = false; |
| EXPECT_TRUE(prioritizing_selector()->ChooseOldestWithPriority( |
| TaskQueue::kNormalPriority, &chose_delayed_over_immediate, |
| &chosen_work_queue)); |
| EXPECT_EQ(chosen_work_queue, task_queues_[0]->delayed_work_queue()); |
| EXPECT_FALSE(chose_delayed_over_immediate); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, ChooseOldestWithPriority_OnlyImmediate) { |
| task_queues_[0]->immediate_work_queue()->Push(TaskQueueImpl::Task( |
| TaskQueue::PostedTask(test_closure_, FROM_HERE), TimeTicks(), |
| EnqueueOrder(), EnqueueOrder::FromIntForTesting(2))); |
| |
| WorkQueue* chosen_work_queue = nullptr; |
| bool chose_delayed_over_immediate = false; |
| EXPECT_TRUE(prioritizing_selector()->ChooseOldestWithPriority( |
| TaskQueue::kNormalPriority, &chose_delayed_over_immediate, |
| &chosen_work_queue)); |
| EXPECT_EQ(chosen_work_queue, task_queues_[0]->immediate_work_queue()); |
| EXPECT_FALSE(chose_delayed_over_immediate); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestObserverWithOneBlockedQueue) { |
| TaskQueueSelectorForTest selector(associated_thread_); |
| MockObserver mock_observer; |
| selector.SetTaskQueueSelectorObserver(&mock_observer); |
| |
| EXPECT_CALL(mock_observer, OnTaskQueueEnabled(_)).Times(1); |
| |
| std::unique_ptr<TaskQueueImpl> task_queue(NewTaskQueueWithBlockReporting()); |
| selector.AddQueue(task_queue.get()); |
| |
| task_queue->SetQueueEnabledForTest(false); |
| selector.DisableQueue(task_queue.get()); |
| |
| TaskQueueImpl::Task task(TaskQueue::PostedTask(test_closure_, FROM_HERE), |
| TimeTicks(), EnqueueOrder(), |
| EnqueueOrder::FromIntForTesting(2)); |
| task_queue->immediate_work_queue()->Push(std::move(task)); |
| |
| WorkQueue* chosen_work_queue; |
| EXPECT_FALSE(selector.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| task_queue->SetQueueEnabledForTest(true); |
| selector.EnableQueue(task_queue.get()); |
| selector.RemoveQueue(task_queue.get()); |
| task_queue->UnregisterTaskQueue(); |
| } |
| |
| TEST_F(TaskQueueSelectorTest, TestObserverWithTwoBlockedQueues) { |
| TaskQueueSelectorForTest selector(associated_thread_); |
| MockObserver mock_observer; |
| selector.SetTaskQueueSelectorObserver(&mock_observer); |
| |
| std::unique_ptr<TaskQueueImpl> task_queue(NewTaskQueueWithBlockReporting()); |
| std::unique_ptr<TaskQueueImpl> task_queue2(NewTaskQueueWithBlockReporting()); |
| selector.AddQueue(task_queue.get()); |
| selector.AddQueue(task_queue2.get()); |
| |
| task_queue->SetQueueEnabledForTest(false); |
| task_queue2->SetQueueEnabledForTest(false); |
| selector.DisableQueue(task_queue.get()); |
| selector.DisableQueue(task_queue2.get()); |
| |
| selector.SetQueuePriority(task_queue2.get(), TaskQueue::kControlPriority); |
| |
| TaskQueueImpl::Task task1(TaskQueue::PostedTask(test_closure_, FROM_HERE), |
| TimeTicks(), EnqueueOrder::FromIntForTesting(2), |
| EnqueueOrder::FromIntForTesting(2)); |
| TaskQueueImpl::Task task2(TaskQueue::PostedTask(test_closure_, FROM_HERE), |
| TimeTicks(), EnqueueOrder::FromIntForTesting(3), |
| EnqueueOrder::FromIntForTesting(3)); |
| task_queue->immediate_work_queue()->Push(std::move(task1)); |
| task_queue2->immediate_work_queue()->Push(std::move(task2)); |
| |
| WorkQueue* chosen_work_queue; |
| EXPECT_FALSE(selector.SelectWorkQueueToService(&chosen_work_queue)); |
| testing::Mock::VerifyAndClearExpectations(&mock_observer); |
| |
| EXPECT_CALL(mock_observer, OnTaskQueueEnabled(_)).Times(2); |
| |
| task_queue->SetQueueEnabledForTest(true); |
| selector.EnableQueue(task_queue.get()); |
| |
| selector.RemoveQueue(task_queue.get()); |
| task_queue->UnregisterTaskQueue(); |
| EXPECT_FALSE(selector.SelectWorkQueueToService(&chosen_work_queue)); |
| |
| task_queue2->SetQueueEnabledForTest(true); |
| selector.EnableQueue(task_queue2.get()); |
| selector.RemoveQueue(task_queue2.get()); |
| task_queue2->UnregisterTaskQueue(); |
| } |
| |
| struct ChooseOldestWithPriorityTestParam { |
| int delayed_task_enqueue_order; |
| int immediate_task_enqueue_order; |
| int immediate_starvation_count; |
| const char* expected_work_queue_name; |
| bool expected_did_starve_immediate_queue; |
| }; |
| |
| static const ChooseOldestWithPriorityTestParam |
| kChooseOldestWithPriorityTestCases[] = { |
| {1, 2, 0, "delayed", true}, {1, 2, 1, "delayed", true}, |
| {1, 2, 2, "delayed", true}, {1, 2, 3, "immediate", false}, |
| {1, 2, 4, "immediate", false}, {2, 1, 4, "immediate", false}, |
| {2, 1, 4, "immediate", false}, |
| }; |
| |
| class ChooseOldestWithPriorityTest |
| : public TaskQueueSelectorTest, |
| public testing::WithParamInterface<ChooseOldestWithPriorityTestParam> {}; |
| |
| TEST_P(ChooseOldestWithPriorityTest, RoundRobinTest) { |
| task_queues_[0]->immediate_work_queue()->Push(TaskQueueImpl::Task( |
| TaskQueue::PostedTask(test_closure_, FROM_HERE), TimeTicks(), |
| EnqueueOrder::FromIntForTesting(GetParam().immediate_task_enqueue_order), |
| EnqueueOrder::FromIntForTesting( |
| GetParam().immediate_task_enqueue_order))); |
| |
| task_queues_[0]->delayed_work_queue()->Push(TaskQueueImpl::Task( |
| TaskQueue::PostedTask(test_closure_, FROM_HERE), TimeTicks(), |
| EnqueueOrder::FromIntForTesting(GetParam().delayed_task_enqueue_order), |
| EnqueueOrder::FromIntForTesting(GetParam().delayed_task_enqueue_order))); |
| |
| selector_.SetImmediateStarvationCountForTest( |
| GetParam().immediate_starvation_count); |
| |
| WorkQueue* chosen_work_queue = nullptr; |
| bool chose_delayed_over_immediate = false; |
| EXPECT_TRUE(prioritizing_selector()->ChooseOldestWithPriority( |
| TaskQueue::kNormalPriority, &chose_delayed_over_immediate, |
| &chosen_work_queue)); |
| EXPECT_EQ(chosen_work_queue->task_queue(), task_queues_[0].get()); |
| EXPECT_STREQ(chosen_work_queue->name(), GetParam().expected_work_queue_name); |
| EXPECT_EQ(chose_delayed_over_immediate, |
| GetParam().expected_did_starve_immediate_queue); |
| } |
| |
| INSTANTIATE_TEST_CASE_P(ChooseOldestWithPriorityTest, |
| ChooseOldestWithPriorityTest, |
| testing::ValuesIn(kChooseOldestWithPriorityTestCases)); |
| |
| } // namespace task_queue_selector_unittest |
| } // namespace internal |
| } // namespace sequence_manager |
| } // namespace base |
