| commit | 82b1f2ac9a1e15ac7ffe2764dd0a032a6b9737b2 | [log] [tgz] |
|---|---|---|
| author | James Cook <jamescook@chromium.org> | Mon Feb 11 22:32:36 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 11 22:32:36 2019 |
| tree | 27cbbc5280b53ee18d2497bb48e55e03812617b9 | |
| parent | 2037f6e837f80251122671f849e3843c40e4ecdc [diff] |
Convert CHECK(false) to LOG(FATAL) in ash Otherwise the log string isn't captured in the logs. Bug: none Change-Id: Iaec642686a29cce13a54b35186e7fd8aafd82854 Reviewed-on: https://chromium-review.googlesource.com/c/1464937 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630960}
diff --git a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc index 7648581..ddeb028 100644 --- a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc +++ b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc
@@ -231,7 +231,7 @@ base::GetFileSize(image_path, &golden_screenshot_size); if (golden_screenshot_size == -1) { - CHECK(false) << "Can't get golden screenshot size"; + LOG(FATAL) << "Can't get golden screenshot size"; } scoped_refptr<base::RefCountedBytes> png_data = new base::RefCountedBytes; png_data->data().resize(golden_screenshot_size);
diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc index 25f4068..89da0274 100644 --- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc +++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
@@ -58,7 +58,7 @@ void ErrorCallbackFunction(const std::string& error_name, const std::string& error_message) { - CHECK(false) << "Shill Error: " << error_name << " : " << error_message; + LOG(FATAL) << "Shill Error: " << error_name << " : " << error_message; } void SetConnected(const std::string& service_path) {