ash: Remove StubDelegate from SessionManagerClient

Remove StubDelegate and SetStubDelegate from SessionManagerClient and
FakeSessionManagerClient.

In production, SessionManagerClient::RequestLockScreen forwards a lock
request to the session_manager daemon, which later calls back into
ScreenLockServiceProvider. For testing, ScreenLockObserver previously
used StubDelegate to intercept RequestLockScreen and directly show
the lock screen.

This change replaces StubDelegate with a repeating callback on
FakeSessionManagerClient (set_on_request_lock_screen_callback) and
introduces ScreenLockerTester::ScopedRequestLockScreenOverride to set
up this callback during tests. Callsites that previously depended on
StubDelegate or manual lock handling have been updated to use
ScreenLockerTester::Lock() or set the callback explicitly.

TAG=agy

Bug: b:539761804
Change-Id: I02e83282cac1f0717e1bad9612d91c2caba28b1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8150800
Commit-Queue: Jun Ishiguro <junis@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1670986}
30 files changed
tree: 583c5b83e358995d175299028d128823a9dbdbf2
  1. .agents/
  2. .claude/
  3. .gemini/
  4. .github/
  5. agents/
  6. android_webview/
  7. apps/
  8. ash/
  9. base/
  10. build/
  11. build_overrides/
  12. buildtools/
  13. cc/
  14. chrome/
  15. chromecast/
  16. chromeos/
  17. codelabs/
  18. components/
  19. content/
  20. crypto/
  21. dbus/
  22. device/
  23. docs/
  24. extensions/
  25. fuchsia_web/
  26. gin/
  27. google_apis/
  28. gpu/
  29. headless/
  30. infra/
  31. ios/
  32. ipc/
  33. media/
  34. mojo/
  35. net/
  36. pdf/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webkit/
  52. .clang-format
  53. .clang-tidy
  54. .clangd
  55. .cursorignore
  56. .geminiignore
  57. .git-blame-ignore-revs
  58. .gitallowed
  59. .gitattributes
  60. .gitignore
  61. .gitmodules
  62. .gn
  63. .mailmap
  64. .rustfmt.toml
  65. .vpython3
  66. .yapfignore
  67. ATL_OWNERS
  68. AUTHORS
  69. BRANCH_FEATURE_OWNERS
  70. BRANCH_OWNERS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. package.json
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. SECURITY_OWNERS
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.