Run Clang-Tidy on //ui/views Under Windows
BUG=
TBR=sky@chromium.org
Change-Id: Idbe0b2ff95fb7e429f02c72a0086a849b32e4f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612226
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660631}
diff --git a/ui/views/accessibility/view_ax_platform_node_delegate_unittest.cc b/ui/views/accessibility/view_ax_platform_node_delegate_unittest.cc
index 9e10ff5..5671f5fb 100644
--- a/ui/views/accessibility/view_ax_platform_node_delegate_unittest.cc
+++ b/ui/views/accessibility/view_ax_platform_node_delegate_unittest.cc
@@ -196,7 +196,7 @@
class TestAXEventObserver : public AXEventObserver {
public:
- TestAXEventObserver(AXAuraObjCache* cache) : cache_(cache) {
+ explicit TestAXEventObserver(AXAuraObjCache* cache) : cache_(cache) {
AXEventManager::Get()->AddObserver(this);
}
diff --git a/ui/views/metadata/metadata_cache.cc b/ui/views/metadata/metadata_cache.cc
index 7480ccd..5a2f10a 100644
--- a/ui/views/metadata/metadata_cache.cc
+++ b/ui/views/metadata/metadata_cache.cc
@@ -13,8 +13,8 @@
namespace views {
namespace metadata {
-MetaDataCache::MetaDataCache() {}
-MetaDataCache::~MetaDataCache() {}
+MetaDataCache::MetaDataCache() = default;
+MetaDataCache::~MetaDataCache() = default;
// static
MetaDataCache* MetaDataCache::GetInstance() {
diff --git a/ui/views/metadata/metadata_unittest.cc b/ui/views/metadata/metadata_unittest.cc
index 6cea628..73529c1f 100644
--- a/ui/views/metadata/metadata_unittest.cc
+++ b/ui/views/metadata/metadata_unittest.cc
@@ -16,8 +16,8 @@
class MetadataTest : public PlatformTest {
public:
- MetadataTest() {}
- ~MetadataTest() override {}
+ MetadataTest() = default;
+ ~MetadataTest() override = default;
bool float_property_changed() const { return float_property_changed_; }
void OnFloatPropertyChanged() { float_property_changed_ = true; }
diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
index 04271aa..3741ace5 100644
--- a/ui/views/widget/widget.cc
+++ b/ui/views/widget/widget.cc
@@ -128,7 +128,8 @@
class Widget::PaintAsActiveLockImpl : public Widget::PaintAsActiveLock {
public:
- PaintAsActiveLockImpl(base::WeakPtr<Widget>&& widget) : widget_(widget) {}
+ explicit PaintAsActiveLockImpl(base::WeakPtr<Widget>&& widget)
+ : widget_(widget) {}
~PaintAsActiveLockImpl() override {
Widget* const widget = widget_.get();
