| // Copyright 2015 The Chromium Authors |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #include "net/quic/crypto/proof_verifier_chromium.h" |
| |
| #include <algorithm> |
| #include <memory> |
| #include <ranges> |
| #include <string_view> |
| #include <utility> |
| |
| #include "base/memory/raw_ptr.h" |
| #include "base/memory/ref_counted.h" |
| #include "base/test/metrics/histogram_tester.h" |
| #include "base/test/scoped_feature_list.h" |
| #include "base/test/task_environment.h" |
| #include "net/base/completion_once_callback.h" |
| #include "net/base/features.h" |
| #include "net/base/hash_value.h" |
| #include "net/base/net_errors.h" |
| #include "net/base/network_anonymization_key.h" |
| #include "net/cert/cert_status_flags.h" |
| #include "net/cert/cert_verifier.h" |
| #include "net/cert/ct_log_verifier.h" |
| #include "net/cert/ct_policy_enforcer.h" |
| #include "net/cert/ct_policy_status.h" |
| #include "net/cert/ct_serialization.h" |
| #include "net/cert/mock_cert_verifier.h" |
| #include "net/cert/sct_auditing_delegate.h" |
| #include "net/cert/x509_util.h" |
| #include "net/http/transport_security_state.h" |
| #include "net/http/transport_security_state_test_util.h" |
| #include "net/quic/crypto/proof_source_chromium.h" |
| #include "net/quic/quic_context.h" |
| #include "net/test/cert_test_util.h" |
| #include "net/test/test_data_directory.h" |
| #include "net/third_party/quiche/src/quiche/quic/core/crypto/proof_verifier.h" |
| #include "net/third_party/quiche/src/quiche/quic/core/quic_error_codes.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| |
| using ::testing::_; |
| using ::testing::Return; |
| |
| namespace net::test { |
| |
| namespace { |
| |
| const char kCTAndPKPHost[] = "hsts-hpkp-preloaded.test"; |
| |
| // CertVerifier that will fail the test if it is ever called. |
| class FailsTestCertVerifier : public CertVerifier { |
| public: |
| FailsTestCertVerifier() = default; |
| ~FailsTestCertVerifier() override = default; |
| |
| // CertVerifier implementation |
| int Verify(const RequestParams& params, |
| CertVerifyResult* verify_result, |
| CompletionOnceCallback callback, |
| std::unique_ptr<Request>* out_req, |
| const NetLogWithSource& net_log) override { |
| ADD_FAILURE() << "CertVerifier::Verify() should not be called"; |
| return ERR_FAILED; |
| } |
| void Verify2QwacBinding( |
| const std::string& binding, |
| const std::string& hostname, |
| const scoped_refptr<net::X509Certificate>& tls_cert, |
| base::OnceCallback<void(const scoped_refptr<net::X509Certificate>&)> |
| callback, |
| const net::NetLogWithSource& net_log) override { |
| ADD_FAILURE() << "CertVerifier::Verify2QwacBinding() should not be called"; |
| std::move(callback).Run(nullptr); |
| } |
| void SetConfig(const Config& config) override {} |
| void AddObserver(Observer* observer) override {} |
| void RemoveObserver(Observer* observer) override {} |
| }; |
| |
| class MockSCTAuditingDelegate : public SCTAuditingDelegate { |
| public: |
| MOCK_METHOD(bool, IsSCTAuditingEnabled, ()); |
| MOCK_METHOD(void, |
| MaybeEnqueueReport, |
| (const net::HostPortPair&, |
| const net::X509Certificate*, |
| const net::SignedCertificateTimestampAndStatusList&)); |
| }; |
| |
| // Proof source callback which saves the signature into |signature|. |
| class SignatureSaver : public quic::ProofSource::Callback { |
| public: |
| explicit SignatureSaver(std::string* signature) : signature_(signature) {} |
| ~SignatureSaver() override = default; |
| |
| void Run(bool /*ok*/, |
| const quiche::QuicheReferenceCountedPointer< |
| quic::ProofSource::Chain>& /*chain*/, |
| const quic::QuicCryptoProof& proof, |
| std::unique_ptr<quic::ProofSource::Details> /*details*/) override { |
| *signature_ = proof.signature; |
| } |
| |
| raw_ptr<std::string> signature_; |
| }; |
| |
| class DummyProofVerifierCallback : public quic::ProofVerifierCallback { |
| public: |
| DummyProofVerifierCallback() = default; |
| ~DummyProofVerifierCallback() override = default; |
| |
| void Run(bool ok, |
| const std::string& error_details, |
| std::unique_ptr<quic::ProofVerifyDetails>* details) override { |
| // Do nothing |
| } |
| }; |
| |
| const char kTestHostname[] = "test.example.com"; |
| const uint16_t kTestPort = 8443; |
| const char kTestConfig[] = "server config bytes"; |
| const char kTestChloHash[] = "CHLO hash"; |
| const char kTestEmptyOCSPResponse[] = ""; |
| const char kTestEmptySCT[] = ""; |
| const char kTestEmptySignature[] = ""; |
| |
| // This test exercises code that does not depend on the QUIC version in use |
| // but that still requires a version so we just use the first one. |
| const quic::QuicTransportVersion kTestTransportVersion = |
| AllSupportedQuicVersions().front().transport_version; |
| |
| } // namespace |
| |
| class ProofVerifierChromiumTest : public ::testing::Test { |
| public: |
| ProofVerifierChromiumTest() |
| : verify_context_(std::make_unique<ProofVerifyContextChromium>( |
| 0 /*cert_verify_flags*/, |
| NetLogWithSource())) {} |
| |
| void SetUp() override { |
| static const char kTestCert[] = "quic-chain.pem"; |
| test_cert_ = ImportCertFromFile(GetTestCertsDirectory(), kTestCert); |
| ASSERT_TRUE(test_cert_); |
| certs_.clear(); |
| certs_.emplace_back( |
| x509_util::CryptoBufferAsStringPiece(test_cert_->cert_buffer())); |
| |
| dummy_result_.verified_cert = test_cert_; |
| dummy_result_.is_issued_by_known_root = true; |
| dummy_result_.policy_compliance = |
| ct::CTPolicyCompliance::CT_POLICY_NOT_ENOUGH_SCTS; |
| } |
| |
| std::string GetTestSignature() { |
| ProofSourceChromium source; |
| source.Initialize(GetTestCertsDirectory().AppendASCII("quic-chain.pem"), |
| GetTestCertsDirectory().AppendASCII("quic-leaf-cert.key"), |
| base::FilePath()); |
| std::string signature; |
| source.GetProof(quic::QuicSocketAddress(), quic::QuicSocketAddress(), |
| kTestHostname, kTestConfig, kTestTransportVersion, |
| kTestChloHash, |
| std::make_unique<SignatureSaver>(&signature)); |
| return signature; |
| } |
| |
| protected: |
| base::test::SingleThreadTaskEnvironment task_environment_; |
| |
| TransportSecurityState transport_security_state_; |
| |
| std::unique_ptr<quic::ProofVerifyContext> verify_context_; |
| std::unique_ptr<quic::ProofVerifyDetails> details_; |
| std::string error_details_; |
| uint8_t tls_alert_; |
| std::vector<std::string> certs_; |
| CertVerifyResult dummy_result_; |
| scoped_refptr<X509Certificate> test_cert_; |
| }; |
| |
| TEST_F(ProofVerifierChromiumTest, VerifyProof) { |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_EQ(dummy_result_.cert_status, |
| verify_details->cert_verify_result.cert_status); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_EQ(dummy_result_.cert_status, |
| verify_details->cert_verify_result.cert_status); |
| } |
| |
| // Tests that the quic::ProofVerifier fails verification if certificate |
| // verification fails. |
| TEST_F(ProofVerifierChromiumTest, FailsIfCertFails) { |
| MockCertVerifier dummy_verifier; |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| } |
| |
| // Confirms that the parameters get passed through to the |
| // CertVerifier::RequestParams as expected. |
| TEST_F(ProofVerifierChromiumTest, PassesCertVerifierRequestParams) { |
| CertVerifyResult dummy_result; |
| dummy_result.verified_cert = test_cert_; |
| dummy_result.is_issued_by_known_root = true; |
| |
| ParamRecordingMockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result, OK); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| const std::string kTestOcspResponse = "ocsp"; |
| const std::string kTestSctList = "sct list"; |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestOcspResponse, kTestSctList, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| ASSERT_EQ(dummy_verifier.GetVerifyParams().size(), 1u); |
| const auto& params = dummy_verifier.GetVerifyParams().front(); |
| EXPECT_TRUE(params.certificate()->EqualsIncludingChain(test_cert_.get())); |
| EXPECT_EQ(params.hostname(), kTestHostname); |
| EXPECT_EQ(params.ocsp_response(), kTestOcspResponse); |
| EXPECT_EQ(params.sct_list(), kTestSctList); |
| } |
| |
| // Tests that the quic::ProofVerifier doesn't verify certificates if the config |
| // signature fails. |
| TEST_F(ProofVerifierChromiumTest, FailsIfSignatureFails) { |
| FailsTestCertVerifier cert_verifier; |
| ProofVerifierChromium proof_verifier(&cert_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, kTestEmptySignature, |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| } |
| |
| std::vector<SHA256HashValue> MakeHashValueVector(uint8_t tag) { |
| SHA256HashValue hash; |
| std::ranges::fill(hash, tag); |
| std::vector<SHA256HashValue> hashes; |
| hashes.push_back(hash); |
| return hashes; |
| } |
| |
| TEST_F(ProofVerifierChromiumTest, IsFatalErrorNotSetForNonFatalError) { |
| dummy_result_.cert_status = CERT_STATUS_DATE_INVALID; |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, |
| ERR_CERT_DATE_INVALID); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_FALSE(verify_details->is_fatal_cert_error); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_FALSE(verify_details->is_fatal_cert_error); |
| } |
| |
| TEST_F(ProofVerifierChromiumTest, IsFatalErrorSetForFatalError) { |
| dummy_result_.cert_status = CERT_STATUS_DATE_INVALID; |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, |
| ERR_CERT_DATE_INVALID); |
| |
| const base::Time expiry = base::Time::Now() + base::Seconds(1000); |
| transport_security_state_.AddHSTS(kTestHostname, expiry, true); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->is_fatal_cert_error); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->is_fatal_cert_error); |
| } |
| |
| // Test that PKP is enforced for certificates that chain up to known roots. |
| TEST_F(ProofVerifierChromiumTest, PKPEnforced) { |
| base::test::ScopedFeatureList scoped_feature_list_; |
| scoped_feature_list_.InitAndEnableFeature( |
| net::features::kStaticKeyPinningEnforcement); |
| dummy_result_.is_issued_by_known_root = true; |
| dummy_result_.public_key_hashes = MakeHashValueVector(0x01); |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| transport_security_state_.EnableStaticPinsForTesting(); |
| transport_security_state_.SetPinningListAlwaysTimelyForTesting(true); |
| ScopedTransportSecurityStateSource scoped_security_state_source; |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kCTAndPKPHost, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| ASSERT_TRUE(details_.get()); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->cert_verify_result.cert_status & |
| CERT_STATUS_PINNED_KEY_MISSING); |
| EXPECT_FALSE(verify_details->pkp_bypassed); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kCTAndPKPHost, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| ASSERT_TRUE(details_.get()); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->cert_verify_result.cert_status & |
| CERT_STATUS_PINNED_KEY_MISSING); |
| EXPECT_FALSE(verify_details->pkp_bypassed); |
| } |
| |
| // Test |pkp_bypassed| is set when PKP is bypassed due to a local |
| // trust anchor |
| TEST_F(ProofVerifierChromiumTest, PKPBypassFlagSet) { |
| base::test::ScopedFeatureList scoped_feature_list_; |
| scoped_feature_list_.InitAndEnableFeature( |
| net::features::kStaticKeyPinningEnforcement); |
| dummy_result_.is_issued_by_known_root = false; |
| dummy_result_.public_key_hashes = MakeHashValueVector(0x01); |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| transport_security_state_.EnableStaticPinsForTesting(); |
| transport_security_state_.SetPinningListAlwaysTimelyForTesting(true); |
| ScopedTransportSecurityStateSource scoped_security_state_source; |
| |
| ProofVerifierChromium proof_verifier( |
| &dummy_verifier, &transport_security_state_, nullptr, {kCTAndPKPHost}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kCTAndPKPHost, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->pkp_bypassed); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kCTAndPKPHost, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->pkp_bypassed); |
| } |
| |
| // Test that PKP is considered even when CT fails. |
| TEST_F(ProofVerifierChromiumTest, PKPAndCTBothTested) { |
| base::test::ScopedFeatureList scoped_feature_list_; |
| scoped_feature_list_.InitAndEnableFeature( |
| net::features::kStaticKeyPinningEnforcement); |
| dummy_result_.is_issued_by_known_root = true; |
| dummy_result_.public_key_hashes = MakeHashValueVector(0x01); |
| dummy_result_.policy_compliance = |
| ct::CTPolicyCompliance::CT_POLICY_NOT_ENOUGH_SCTS; |
| dummy_result_.cert_status = CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED; |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, |
| ERR_CERTIFICATE_TRANSPARENCY_REQUIRED); |
| |
| // Set up PKP. |
| transport_security_state_.EnableStaticPinsForTesting(); |
| transport_security_state_.SetPinningListAlwaysTimelyForTesting(true); |
| ScopedTransportSecurityStateSource scoped_security_state_source; |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kCTAndPKPHost, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| ASSERT_TRUE(details_.get()); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->cert_verify_result.cert_status & |
| CERT_STATUS_PINNED_KEY_MISSING); |
| EXPECT_TRUE(verify_details->cert_verify_result.cert_status & |
| CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kCTAndPKPHost, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| |
| ASSERT_TRUE(details_.get()); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_TRUE(verify_details->cert_verify_result.cert_status & |
| CERT_STATUS_PINNED_KEY_MISSING); |
| EXPECT_TRUE(verify_details->cert_verify_result.cert_status & |
| CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED); |
| } |
| |
| TEST_F(ProofVerifierChromiumTest, UnknownRootRejected) { |
| dummy_result_.is_issued_by_known_root = false; |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| EXPECT_EQ( |
| "Failed to verify certificate chain: net::ERR_QUIC_CERT_ROOT_NOT_KNOWN", |
| error_details_); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_FAILURE, status); |
| EXPECT_EQ( |
| "Failed to verify certificate chain: net::ERR_QUIC_CERT_ROOT_NOT_KNOWN", |
| error_details_); |
| } |
| |
| TEST_F(ProofVerifierChromiumTest, UnknownRootAcceptedWithOverride) { |
| dummy_result_.is_issued_by_known_root = false; |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| ProofVerifierChromium proof_verifier( |
| &dummy_verifier, &transport_security_state_, nullptr, {kTestHostname}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_EQ(dummy_result_.cert_status, |
| verify_details->cert_verify_result.cert_status); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_EQ(dummy_result_.cert_status, |
| verify_details->cert_verify_result.cert_status); |
| } |
| |
| TEST_F(ProofVerifierChromiumTest, UnknownRootAcceptedWithWildcardOverride) { |
| dummy_result_.is_issued_by_known_root = false; |
| |
| MockCertVerifier dummy_verifier; |
| dummy_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, |
| {""}, NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| ProofVerifyDetailsChromium* verify_details = |
| static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_EQ(dummy_result_.cert_status, |
| verify_details->cert_verify_result.cert_status); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| ASSERT_TRUE(details_.get()); |
| verify_details = static_cast<ProofVerifyDetailsChromium*>(details_.get()); |
| EXPECT_EQ(dummy_result_.cert_status, |
| verify_details->cert_verify_result.cert_status); |
| } |
| |
| // Tests that the SCTAuditingDelegate is called to enqueue SCT reports when |
| // verifying a good proof and cert. |
| TEST_F(ProofVerifierChromiumTest, SCTAuditingReportCollected) { |
| dummy_result_.policy_compliance = |
| ct::CTPolicyCompliance::CT_POLICY_COMPLIES_VIA_SCTS; |
| MockCertVerifier cert_verifier; |
| cert_verifier.AddResultForCert(test_cert_.get(), dummy_result_, OK); |
| |
| MockSCTAuditingDelegate sct_auditing_delegate; |
| EXPECT_CALL(sct_auditing_delegate, IsSCTAuditingEnabled()) |
| .WillRepeatedly(Return(true)); |
| // MaybeEnqueueReport() will be called twice: once in VerifyProof() (which |
| // calls VerifyCert()) and once in VerifyCertChain(). |
| HostPortPair host_port_pair(kTestHostname, kTestPort); |
| EXPECT_CALL(sct_auditing_delegate, MaybeEnqueueReport(host_port_pair, _, _)) |
| .Times(2); |
| |
| ProofVerifierChromium proof_verifier( |
| &cert_verifier, &transport_security_state_, &sct_auditing_delegate, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| |
| callback = std::make_unique<DummyProofVerifierCallback>(); |
| status = proof_verifier.VerifyCertChain( |
| kTestHostname, kTestPort, certs_, kTestEmptyOCSPResponse, kTestEmptySCT, |
| verify_context_.get(), &error_details_, &details_, &tls_alert_, |
| std::move(callback)); |
| ASSERT_EQ(quic::QUIC_SUCCESS, status); |
| } |
| |
| // Make sure that destroying ProofVerifierChromium while there's a pending |
| // request doesn't result in any raw pointer warnings or other crashes. |
| TEST_F(ProofVerifierChromiumTest, DestroyWithPendingRequest) { |
| MockCertVerifier dummy_verifier; |
| // In async mode, the MockCertVerifier's Request will hang onto a raw_ptr to |
| // the CertVerifyResult, just like a real Request. |
| dummy_verifier.set_async(true); |
| |
| ProofVerifierChromium proof_verifier(&dummy_verifier, |
| &transport_security_state_, nullptr, {}, |
| NetworkAnonymizationKey()); |
| |
| auto callback = std::make_unique<DummyProofVerifierCallback>(); |
| quic::QuicAsyncStatus status = proof_verifier.VerifyProof( |
| kTestHostname, kTestPort, kTestConfig, kTestTransportVersion, |
| kTestChloHash, certs_, kTestEmptySCT, GetTestSignature(), |
| verify_context_.get(), &error_details_, &details_, std::move(callback)); |
| ASSERT_EQ(quic::QUIC_PENDING, status); |
| } |
| |
| } // namespace net::test |