| // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| |
| #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h" |
| |
| #import <Cocoa/Cocoa.h> |
| |
| #include <utility> |
| |
| #import "base/mac/scoped_nsobject.h" |
| #include "base/strings/sys_string_conversions.h" |
| #include "base/strings/utf_string_conversions.h" |
| #import "chrome/browser/extensions/extension_install_prompt.h" |
| #include "chrome/browser/ui/browser.h" |
| #import "chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h" |
| #include "chrome/browser/ui/cocoa/test/cocoa_profile_test.h" |
| #include "extensions/common/extension.h" |
| #include "extensions/common/permissions/permission_message_provider.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| #import "testing/gtest_mac.h" |
| |
| using extensions::Extension; |
| using extensions::PermissionIDSet; |
| using extensions::PermissionMessage; |
| using extensions::PermissionMessages; |
| |
| namespace { |
| |
| class MockExtensionInstallViewDelegate : public ExtensionInstallViewDelegate { |
| public: |
| enum class Action { |
| UNDEFINED, |
| OKAY, |
| CANCEL, |
| LINK, |
| }; |
| |
| MockExtensionInstallViewDelegate() : action_(Action::UNDEFINED) {} |
| ~MockExtensionInstallViewDelegate() override {} |
| |
| void OnOkButtonClicked() override { SetAction(Action::OKAY); } |
| void OnCancelButtonClicked() override { SetAction(Action::CANCEL); } |
| void OnStoreLinkClicked() override { SetAction(Action::LINK); } |
| |
| Action action() const { return action_; } |
| |
| private: |
| void SetAction(Action action) { |
| if (action_ != Action::UNDEFINED) |
| ADD_FAILURE() << "SetAction() called twice!"; |
| action_ = action; |
| } |
| |
| Action action_; |
| |
| DISALLOW_COPY_AND_ASSIGN(MockExtensionInstallViewDelegate); |
| }; |
| |
| // Base class for our tests. |
| class ExtensionInstallViewControllerTest : public CocoaProfileTest { |
| public: |
| ExtensionInstallViewControllerTest() { |
| extension_ = chrome::LoadInstallPromptExtension(); |
| } |
| |
| protected: |
| scoped_refptr<extensions::Extension> extension_; |
| }; |
| |
| } // namespace |
| |
| // Test that we can load the two kinds of prompts correctly, that the outlets |
| // are hooked up, and that the dialog calls cancel when cancel is pressed. |
| TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) { |
| MockExtensionInstallViewDelegate delegate; |
| |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt( |
| chrome::BuildExtensionInstallPrompt(extension_.get())); |
| ExtensionInstallPrompt::PermissionsType type = |
| ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS; |
| |
| PermissionMessages permissions; |
| permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"), |
| PermissionIDSet())); |
| prompt->AddPermissions(permissions, type); |
| base::string16 permissionString = prompt->GetPermission(0, type); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate |
| prompt:std::move(prompt)]); |
| |
| [controller view]; // Force nib load. |
| |
| // Test the right nib loaded. |
| EXPECT_NSEQ(@"ExtensionInstallPrompt", [controller nibName]); |
| |
| // Check all the controls. |
| // Make sure everything is non-nil, and that the fields that are |
| // auto-translated don't start with a caret (that would indicate that they |
| // were not translated). |
| EXPECT_TRUE([controller iconView]); |
| EXPECT_TRUE([[controller iconView] image]); |
| |
| EXPECT_TRUE([controller titleField]); |
| EXPECT_NE(0u, [[[controller titleField] stringValue] length]); |
| |
| NSOutlineView* outlineView = [controller outlineView]; |
| EXPECT_TRUE(outlineView); |
| EXPECT_EQ(2, [outlineView numberOfRows]); |
| EXPECT_NSEQ(base::SysUTF16ToNSString(permissionString), |
| [[outlineView dataSource] outlineView:outlineView |
| objectValueForTableColumn:nil |
| byItem:[outlineView itemAtRow:1]]); |
| |
| EXPECT_TRUE([controller cancelButton]); |
| EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]); |
| EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]); |
| |
| EXPECT_TRUE([controller okButton]); |
| EXPECT_NE(0u, [[[controller okButton] stringValue] length]); |
| EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]); |
| |
| // Test that cancel calls our callback. |
| [controller cancel:nil]; |
| EXPECT_EQ(MockExtensionInstallViewDelegate::Action::CANCEL, |
| delegate.action()); |
| } |
| |
| TEST_F(ExtensionInstallViewControllerTest, BasicsNormalOK) { |
| MockExtensionInstallViewDelegate delegate; |
| |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt( |
| chrome::BuildExtensionInstallPrompt(extension_.get())); |
| ExtensionInstallPrompt::PermissionsType type = |
| ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS; |
| |
| PermissionMessages permissions; |
| permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"), |
| PermissionIDSet())); |
| prompt->AddPermissions(permissions, type); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate |
| prompt:std::move(prompt)]); |
| |
| [controller view]; // Force nib load. |
| [controller ok:nil]; |
| |
| EXPECT_EQ(MockExtensionInstallViewDelegate::Action::OKAY, |
| delegate.action()); |
| } |
| |
| // Test that controls get repositioned when there are two warnings vs one |
| // warning. |
| TEST_F(ExtensionInstallViewControllerTest, MultipleWarnings) { |
| MockExtensionInstallViewDelegate delegate1; |
| MockExtensionInstallViewDelegate delegate2; |
| |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> one_warning_prompt( |
| chrome::BuildExtensionInstallPrompt(extension_.get())); |
| ExtensionInstallPrompt::PermissionsType type = |
| ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS; |
| |
| PermissionMessages permissions; |
| permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"), |
| PermissionIDSet())); |
| one_warning_prompt->AddPermissions(permissions, type); |
| |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> two_warnings_prompt( |
| chrome::BuildExtensionInstallPrompt(extension_.get())); |
| permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 2"), |
| PermissionIDSet())); |
| two_warnings_prompt->AddPermissions(permissions, type); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller1( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate1 |
| prompt:std::move(one_warning_prompt)]); |
| |
| [controller1 view]; // Force nib load. |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller2( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate2 |
| prompt:std::move(two_warnings_prompt)]); |
| |
| [controller2 view]; // Force nib load. |
| |
| // Test control positioning. We don't test exact positioning because we don't |
| // want this to depend on string details and localization. But we do know the |
| // relative effect that adding a second warning should have on the layout. |
| ASSERT_LT([[controller1 view] frame].size.height, |
| [[controller2 view] frame].size.height); |
| |
| ASSERT_LT([[controller1 view] frame].size.height, |
| [[controller2 view] frame].size.height); |
| } |
| |
| // Test that we can load the skinny prompt correctly, and that the outlets are |
| // are hooked up. |
| TEST_F(ExtensionInstallViewControllerTest, BasicsSkinny) { |
| MockExtensionInstallViewDelegate delegate; |
| |
| // No warnings should trigger skinny prompt. |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> no_warnings_prompt( |
| chrome::BuildExtensionInstallPrompt(extension_.get())); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate |
| prompt:std::move(no_warnings_prompt)]); |
| |
| [controller view]; // Force nib load. |
| |
| // Test the right nib loaded. |
| EXPECT_NSEQ(@"ExtensionInstallPromptNoWarnings", [controller nibName]); |
| |
| // Check all the controls. |
| // In the skinny prompt, only the icon, title and buttons are non-nill. |
| // Everything else is nil. |
| EXPECT_TRUE([controller iconView]); |
| EXPECT_TRUE([[controller iconView] image]); |
| |
| EXPECT_TRUE([controller titleField]); |
| EXPECT_NE(0u, [[[controller titleField] stringValue] length]); |
| |
| EXPECT_TRUE([controller cancelButton]); |
| EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]); |
| EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]); |
| |
| EXPECT_TRUE([controller okButton]); |
| EXPECT_NE(0u, [[[controller okButton] stringValue] length]); |
| EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]); |
| |
| EXPECT_FALSE([controller outlineView]); |
| } |
| |
| |
| // Test that we can load the inline prompt correctly, and that the outlets are |
| // are hooked up. |
| TEST_F(ExtensionInstallViewControllerTest, BasicsInline) { |
| MockExtensionInstallViewDelegate delegate; |
| |
| // No warnings should trigger skinny prompt. |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> inline_prompt( |
| new ExtensionInstallPrompt::Prompt( |
| ExtensionInstallPrompt::INLINE_INSTALL_PROMPT)); |
| inline_prompt->SetWebstoreData("1,000", true, 3.5, 200); |
| inline_prompt->set_extension(extension_.get()); |
| inline_prompt->set_icon(chrome::LoadInstallPromptIcon()); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate |
| prompt:std::move(inline_prompt)]); |
| |
| [controller view]; // Force nib load. |
| |
| // Test the right nib loaded. |
| EXPECT_NSEQ(@"ExtensionInstallPromptWebstoreData", [controller nibName]); |
| |
| // Check all the controls. |
| EXPECT_TRUE([controller iconView]); |
| EXPECT_TRUE([[controller iconView] image]); |
| |
| EXPECT_TRUE([controller titleField]); |
| EXPECT_NE(0u, [[[controller titleField] stringValue] length]); |
| |
| EXPECT_TRUE([controller cancelButton]); |
| EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]); |
| EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]); |
| |
| EXPECT_TRUE([controller okButton]); |
| EXPECT_NE(0u, [[[controller okButton] stringValue] length]); |
| EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]); |
| |
| EXPECT_TRUE([controller ratingStars]); |
| EXPECT_EQ(5u, [[[controller ratingStars] subviews] count]); |
| |
| EXPECT_TRUE([controller ratingCountField]); |
| EXPECT_NE(0u, [[[controller ratingCountField] stringValue] length]); |
| |
| EXPECT_TRUE([controller userCountField]); |
| EXPECT_NE(0u, [[[controller userCountField] stringValue] length]); |
| |
| EXPECT_TRUE([controller storeLinkButton]); |
| EXPECT_NE(0u, [[[controller storeLinkButton] stringValue] length]); |
| EXPECT_NE('^', |
| [[[controller storeLinkButton] stringValue] characterAtIndex:0]); |
| |
| // Though we have no permissions warnings, these should still be hooked up, |
| // just invisible. |
| EXPECT_TRUE([controller outlineView]); |
| EXPECT_TRUE([[[controller outlineView] enclosingScrollView] isHidden]); |
| EXPECT_TRUE([controller warningsSeparator]); |
| EXPECT_TRUE([[controller warningsSeparator] isHidden]); |
| } |
| |
| TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) { |
| MockExtensionInstallViewDelegate delegate; |
| |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt( |
| chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get())); |
| ExtensionInstallPrompt::PermissionsType type = |
| ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS; |
| |
| PermissionMessages permissions; |
| permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"), |
| PermissionIDSet())); |
| prompt->AddPermissions(permissions, type); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate |
| prompt:std::move(prompt)]); |
| |
| [controller view]; // Force nib load. |
| |
| EXPECT_TRUE([controller cancelButton]); |
| EXPECT_FALSE([controller okButton]); |
| |
| [controller cancel:nil]; |
| EXPECT_EQ(MockExtensionInstallViewDelegate::Action::CANCEL, |
| delegate.action()); |
| } |
| |
| // Test that permission details show up. |
| TEST_F(ExtensionInstallViewControllerTest, PermissionsDetails) { |
| MockExtensionInstallViewDelegate delegate; |
| |
| std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt( |
| chrome::BuildExtensionInstallPrompt(extension_.get())); |
| ExtensionInstallPrompt::PermissionsType type = |
| ExtensionInstallPrompt::PermissionsType::REGULAR_PERMISSIONS; |
| |
| PermissionMessages permissions; |
| permissions.push_back(PermissionMessage( |
| base::UTF8ToUTF16("warning 1"), |
| PermissionIDSet(), |
| std::vector<base::string16>(1, base::UTF8ToUTF16("Detail 1")))); |
| prompt->AddPermissions(permissions, type); |
| prompt->SetIsShowingDetails( |
| ExtensionInstallPrompt::PERMISSIONS_DETAILS, 0, true); |
| base::string16 permissionString = prompt->GetPermissionsDetails(0, type); |
| |
| base::scoped_nsobject<ExtensionInstallViewController> controller( |
| [[ExtensionInstallViewController alloc] |
| initWithProfile:profile() |
| navigator:browser() |
| delegate:&delegate |
| prompt:std::move(prompt)]); |
| |
| [controller view]; // Force nib load. |
| |
| NSOutlineView* outlineView = [controller outlineView]; |
| EXPECT_TRUE(outlineView); |
| EXPECT_EQ(4, [outlineView numberOfRows]); |
| EXPECT_NSEQ(base::SysUTF16ToNSString(permissionString), |
| [[outlineView dataSource] outlineView:outlineView |
| objectValueForTableColumn:nil |
| byItem:[outlineView itemAtRow:2]]); |
| } |