Remove default argument from NotificationDisplayService::Display().
Default arguments are banned on virtual functions.
Change-Id: I9b511a8d0f6a55cfd708545f930b1ac6cf726b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533087
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642834}diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 43bbafd..f8c67a1 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -164,7 +164,7 @@
{}, delegate);
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, notification);
+ NotificationHandler::Type::TRANSIENT, notification, /*metadata=*/nullptr);
}
// Show a popup notification balloon with a crash message for a given app/
diff --git a/chrome/browser/chromeos/android_sms/pairing_lost_notifier.cc b/chrome/browser/chromeos/android_sms/pairing_lost_notifier.cc
index 613a70d..07b6f196 100644
--- a/chrome/browser/chromeos/android_sms/pairing_lost_notifier.cc
+++ b/chrome/browser/chromeos/android_sms/pairing_lost_notifier.cc
@@ -125,7 +125,8 @@
&PairingLostNotifier::OnPairingLostNotificationClick,
weak_ptr_factory_.GetWeakPtr())),
ash::kNotificationMessagesIcon,
- message_center::SystemNotificationWarningLevel::NORMAL));
+ message_center::SystemNotificationWarningLevel::NORMAL),
+ /*metadata=*/nullptr);
}
void PairingLostNotifier::ClosePairingLostNotificationIfVisible() {
diff --git a/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc b/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
index 94ccad3..fabde3b 100644
--- a/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
+++ b/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
@@ -72,7 +72,8 @@
notification->set_renotify(true);
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
} // namespace arc
diff --git a/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc b/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc
index e1520299..484b542 100644
--- a/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc
+++ b/chrome/browser/chromeos/arc/notification/arc_boot_error_notification.cc
@@ -83,7 +83,8 @@
ash::kNotificationStorageFullIcon,
message_center::SystemNotificationWarningLevel::CRITICAL_WARNING);
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
// Singleton factory for ArcBootErrorNotificationFactory.
diff --git a/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc b/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc
index 30c18a7..ea7ed4b 100644
--- a/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc
+++ b/chrome/browser/chromeos/arc/notification/arc_provision_notification_service.cc
@@ -97,7 +97,7 @@
notifier_id, optional_fields, new message_center::NotificationDelegate());
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, notification);
+ NotificationHandler::Type::TRANSIENT, notification, /*metadata=*/nullptr);
}
void ArcProvisionNotificationService::HideNotification() {
diff --git a/chrome/browser/chromeos/arc/notification/arc_supervision_transition_notification.cc b/chrome/browser/chromeos/arc/notification/arc_supervision_transition_notification.cc
index 478cd42..6cf1487 100644
--- a/chrome/browser/chromeos/arc/notification/arc_supervision_transition_notification.cc
+++ b/chrome/browser/chromeos/arc/notification/arc_supervision_transition_notification.cc
@@ -108,7 +108,8 @@
new NotificationDelegate(profile), ash::kNotificationFamilyLinkIcon,
message_center::SystemNotificationWarningLevel::NORMAL);
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
} // namespace arc
diff --git a/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc b/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
index f624597..66a8dd7 100644
--- a/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
+++ b/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
@@ -286,7 +286,8 @@
// Add the notification.
NotificationDisplayServiceFactory::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
shown_notifications_.insert(message_id);
}
diff --git a/chrome/browser/chromeos/child_accounts/time_limit_notifier.cc b/chrome/browser/chromeos/child_accounts/time_limit_notifier.cc
index 93d5d76..bce0e26 100644
--- a/chrome/browser/chromeos/child_accounts/time_limit_notifier.cc
+++ b/chrome/browser/chromeos/child_accounts/time_limit_notifier.cc
@@ -59,7 +59,8 @@
message_center::SystemNotificationWarningLevel::NORMAL);
NotificationDisplayService::GetForProfile(
Profile::FromBrowserContext(context))
- ->Display(NotificationHandler::Type::TRANSIENT, *notification);
+ ->Display(NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
} // namespace
diff --git a/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc b/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc
index 476420d3..480a54e 100644
--- a/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc
+++ b/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc
@@ -115,7 +115,8 @@
NOTREACHED();
}
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification_);
+ NotificationHandler::Type::TRANSIENT, *notification_,
+ /*metadata=*/nullptr);
}
void CrostiniExportImportNotification::Close(bool by_user) {
diff --git a/chrome/browser/chromeos/crostini/crostini_package_notification.cc b/chrome/browser/chromeos/crostini/crostini_package_notification.cc
index 29698c3..1be09cd 100644
--- a/chrome/browser/chromeos/crostini/crostini_package_notification.cc
+++ b/chrome/browser/chromeos/crostini/crostini_package_notification.cc
@@ -224,8 +224,8 @@
NotificationDisplayService* display_service =
NotificationDisplayService::GetForProfile(profile_);
- display_service->Display(NotificationHandler::Type::TRANSIENT,
- *notification_);
+ display_service->Display(NotificationHandler::Type::TRANSIENT, *notification_,
+ /*metadata=*/nullptr);
}
} // namespace crostini
diff --git a/chrome/browser/chromeos/eol_notification.cc b/chrome/browser/chromeos/eol_notification.cc
index 4c56fd0..de36459 100644
--- a/chrome/browser/chromeos/eol_notification.cc
+++ b/chrome/browser/chromeos/eol_notification.cc
@@ -165,7 +165,8 @@
message_center::SystemNotificationWarningLevel::CRITICAL_WARNING);
NotificationDisplayServiceFactory::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
} // namespace chromeos
diff --git a/chrome/browser/chromeos/file_system_provider/notification_manager.cc b/chrome/browser/chromeos/file_system_provider/notification_manager.cc
index d5e5f72..4aba0f8 100644
--- a/chrome/browser/chromeos/file_system_provider/notification_manager.cc
+++ b/chrome/browser/chromeos/file_system_provider/notification_manager.cc
@@ -113,7 +113,7 @@
notification.SetSystemPriority();
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, notification);
+ NotificationHandler::Type::TRANSIENT, notification, /*metadata=*/nullptr);
}
void NotificationManager::OnNotificationResult(NotificationResult result) {
diff --git a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
index 855caba9..ca4b4c2 100644
--- a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
+++ b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
@@ -459,7 +459,7 @@
data, std::move(delegate));
notification.set_priority(message_center::LOW_PRIORITY);
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, notification);
+ NotificationHandler::Type::TRANSIENT, notification, /*metadata=*/nullptr);
}
} // namespace chromeos
diff --git a/chrome/browser/chromeos/hats/hats_notification_controller.cc b/chrome/browser/chromeos/hats/hats_notification_controller.cc
index 46b83ff..d4ff2a3 100644
--- a/chrome/browser/chromeos/hats/hats_notification_controller.cc
+++ b/chrome/browser/chromeos/hats/hats_notification_controller.cc
@@ -220,7 +220,8 @@
message_center::SystemNotificationWarningLevel::NORMAL);
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void HatsNotificationController::UpdateLastInteractionTime() {
diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
index 00ac029..9b7bcbc5 100644
--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
@@ -128,7 +128,8 @@
std::unique_ptr<message_center::Notification> notification) {
notification->SetSystemPriority();
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void EasyUnlockNotificationController::LaunchEasyUnlockSettings() {
diff --git a/chrome/browser/chromeos/login/session/user_session_manager.cc b/chrome/browser/chromeos/login/session/user_session_manager.cc
index 78e2ac7..df96289 100644
--- a/chrome/browser/chromeos/login/session/user_session_manager.cc
+++ b/chrome/browser/chromeos/login/session/user_session_manager.cc
@@ -1269,7 +1269,8 @@
notification->set_priority(message_center::SYSTEM_PRIORITY);
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void UserSessionManager::InitProfilePreferences(
diff --git a/chrome/browser/chromeos/printing/cups_print_job_notification.cc b/chrome/browser/chromeos/printing/cups_print_job_notification.cc
index 07404c0..cc5bb09 100644
--- a/chrome/browser/chromeos/printing/cups_print_job_notification.cc
+++ b/chrome/browser/chromeos/printing/cups_print_job_notification.cc
@@ -152,16 +152,17 @@
print_job_->state() == CupsPrintJob::State::STATE_PAGE_DONE) {
// If the notification was closed during the printing, prevent showing the
// following printing progress.
- if (!closed_in_middle_)
+ if (!closed_in_middle_) {
display_service->Display(NotificationHandler::Type::TRANSIENT,
- *notification_);
+ *notification_, /*metadata=*/nullptr);
+ }
} else {
closed_in_middle_ = false;
// In order to make sure it pop up, we should delete it before readding it.
display_service->Close(NotificationHandler::Type::TRANSIENT,
notification_id_);
display_service->Display(NotificationHandler::Type::TRANSIENT,
- *notification_);
+ *notification_, /*metadata=*/nullptr);
}
// |print_job_| will be deleted by CupsPrintJobManager if the job is finished
diff --git a/chrome/browser/chromeos/tpm_firmware_update_notification.cc b/chrome/browser/chromeos/tpm_firmware_update_notification.cc
index d1fcd32..6eddfe5 100644
--- a/chrome/browser/chromeos/tpm_firmware_update_notification.cc
+++ b/chrome/browser/chromeos/tpm_firmware_update_notification.cc
@@ -86,7 +86,8 @@
message_center::SystemNotificationWarningLevel::WARNING);
NotificationDisplayServiceFactory::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
} // namespace
diff --git a/chrome/browser/download/notification/download_item_notification.cc b/chrome/browser/download/notification/download_item_notification.cc
index 0e77bff..d65fbe3 100644
--- a/chrome/browser/download/notification/download_item_notification.cc
+++ b/chrome/browser/download/notification/download_item_notification.cc
@@ -250,7 +250,8 @@
notification_->set_priority(message_center::LOW_PRIORITY);
closed_ = false;
NotificationDisplayServiceFactory::GetForProfile(profile())->Display(
- NotificationHandler::Type::TRANSIENT, *notification_);
+ NotificationHandler::Type::TRANSIENT, *notification_,
+ /*metadata=*/nullptr);
}
void DownloadItemNotification::Close(bool by_user) {
@@ -450,7 +451,8 @@
if (display) {
closed_ = false;
NotificationDisplayServiceFactory::GetForProfile(profile())->Display(
- NotificationHandler::Type::TRANSIENT, *notification_);
+ NotificationHandler::Type::TRANSIENT, *notification_,
+ /*metadata=*/nullptr);
}
if (item_->IsDone() && image_decode_status_ == NOT_STARTED) {
diff --git a/chrome/browser/download/notification/download_item_notification_unittest.cc b/chrome/browser/download/notification/download_item_notification_unittest.cc
index e11255e..80be557 100644
--- a/chrome/browser/download/notification/download_item_notification_unittest.cc
+++ b/chrome/browser/download/notification/download_item_notification_unittest.cc
@@ -129,7 +129,7 @@
download_notification_manager_->items_.at(id).get();
NotificationDisplayServiceFactory::GetForProfile(profile_)->Display(
NotificationHandler::Type::TRANSIENT,
- *download_item_notification_->notification_);
+ *download_item_notification_->notification_, /*metadata=*/nullptr);
}
content::TestBrowserThreadBundle test_browser_thread_bundle_;
diff --git a/chrome/browser/extensions/api/file_system/request_file_system_notification.cc b/chrome/browser/extensions/api/file_system/request_file_system_notification.cc
index cbb73bb..f4672d8 100644
--- a/chrome/browser/extensions/api/file_system/request_file_system_notification.cc
+++ b/chrome/browser/extensions/api/file_system/request_file_system_notification.cc
@@ -60,7 +60,8 @@
pending_notification_->set_icon(*extension_icon_);
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *pending_notification_);
+ NotificationHandler::Type::TRANSIENT, *pending_notification_,
+ /*metadata=*/nullptr);
delete this;
}
diff --git a/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc b/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc
index 1e3bff2..b140a5d 100644
--- a/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc
+++ b/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc
@@ -31,7 +31,7 @@
std::make_unique<message_center::Notification>(notification));
GetDisplayService()->Display(NotificationHandler::Type::EXTENSION,
- notification);
+ notification, /*metadata=*/nullptr);
}
message_center::Notification*
diff --git a/chrome/browser/extensions/extension_storage_monitor.cc b/chrome/browser/extensions/extension_storage_monitor.cc
index 50f7a416..b00bfed 100644
--- a/chrome/browser/extensions/extension_storage_monitor.cc
+++ b/chrome/browser/extensions/extension_storage_monitor.cc
@@ -437,7 +437,7 @@
weak_ptr_factory_.GetWeakPtr(), extension_id)));
notification.SetSystemPriority();
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, notification);
+ NotificationHandler::Type::TRANSIENT, notification, /*metadata=*/nullptr);
notified_extension_ids_.insert(extension_id);
}
diff --git a/chrome/browser/notifications/chrome_ash_message_center_client_browsertest.cc b/chrome/browser/notifications/chrome_ash_message_center_client_browsertest.cc
index b374f19..32fd511 100644
--- a/chrome/browser/notifications/chrome_ash_message_center_client_browsertest.cc
+++ b/chrome/browser/notifications/chrome_ash_message_center_client_browsertest.cc
@@ -53,14 +53,16 @@
auto* display_service =
NotificationDisplayService::GetForProfile(browser()->profile());
- display_service->Display(NotificationHandler::Type::TRANSIENT, notification);
+ display_service->Display(NotificationHandler::Type::TRANSIENT, notification,
+ /*metadata=*/nullptr);
display_service->Close(NotificationHandler::Type::TRANSIENT,
notification.id());
// The Close callback should be fired asynchronously, so there is no close
// yet.
EXPECT_EQ(0, delegate->close_count());
- display_service->Display(NotificationHandler::Type::TRANSIENT, notification);
+ display_service->Display(NotificationHandler::Type::TRANSIENT, notification,
+ /*metadata=*/nullptr);
display_service->Close(NotificationHandler::Type::TRANSIENT,
notification.id());
ChromeAshMessageCenterClient::FlushForTesting();
diff --git a/chrome/browser/notifications/notification_display_service.h b/chrome/browser/notifications/notification_display_service.h
index 9c3b0a6..a9ee846 100644
--- a/chrome/browser/notifications/notification_display_service.h
+++ b/chrome/browser/notifications/notification_display_service.h
@@ -48,7 +48,7 @@
virtual void Display(
NotificationHandler::Type notification_type,
const message_center::Notification& notification,
- std::unique_ptr<NotificationCommon::Metadata> metadata = nullptr) = 0;
+ std::unique_ptr<NotificationCommon::Metadata> metadata) = 0;
// Closes the notification having |notification_id| of |notification_type|.
virtual void Close(NotificationHandler::Type notification_type,
diff --git a/chrome/browser/notifications/notification_display_service_impl.h b/chrome/browser/notifications/notification_display_service_impl.h
index 4504b67..d8d5b7e6 100644
--- a/chrome/browser/notifications/notification_display_service_impl.h
+++ b/chrome/browser/notifications/notification_display_service_impl.h
@@ -66,8 +66,7 @@
void Shutdown() override;
void Display(NotificationHandler::Type notification_type,
const message_center::Notification& notification,
- std::unique_ptr<NotificationCommon::Metadata> metadata =
- nullptr) override;
+ std::unique_ptr<NotificationCommon::Metadata> metadata) override;
void Close(NotificationHandler::Type notification_type,
const std::string& notification_id) override;
void GetDisplayed(DisplayedNotificationsCallback callback) override;
diff --git a/chrome/browser/notifications/notification_platform_bridge_chromeos_browsertest.cc b/chrome/browser/notifications/notification_platform_bridge_chromeos_browsertest.cc
index bc47d75..0aaf1d2 100644
--- a/chrome/browser/notifications/notification_platform_bridge_chromeos_browsertest.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_chromeos_browsertest.cc
@@ -48,6 +48,7 @@
weak_ptr_factory_.GetWeakPtr()));
NotificationDisplayService::GetForProfile(browser()->profile())
- ->Display(NotificationHandler::Type::TRANSIENT, notification);
+ ->Display(NotificationHandler::Type::TRANSIENT, notification,
+ /*metadata=*/nullptr);
expected_close_count_ = 1;
}
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 06949640..3468a6a3 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -155,7 +155,8 @@
notification_data, notification_resources);
NotificationDisplayServiceFactory::GetForProfile(profile)->Display(
- NotificationHandler::Type::WEB_NON_PERSISTENT, notification);
+ NotificationHandler::Type::WEB_NON_PERSISTENT, notification,
+ /*metadata=*/nullptr);
}
void PlatformNotificationServiceImpl::DisplayPersistentNotification(
diff --git a/chrome/browser/notifications/system_notification_helper.cc b/chrome/browser/notifications/system_notification_helper.cc
index 38cb177..96e8e56 100644
--- a/chrome/browser/notifications/system_notification_helper.cc
+++ b/chrome/browser/notifications/system_notification_helper.cc
@@ -33,7 +33,7 @@
void SystemNotificationHelper::Display(
const message_center::Notification& notification) {
GetSystemService()->Display(NotificationHandler::Type::TRANSIENT,
- notification);
+ notification, /*metadata=*/nullptr);
}
void SystemNotificationHelper::Close(const std::string& notification_id) {
diff --git a/chrome/browser/printing/cloud_print/privet_notifications.cc b/chrome/browser/printing/cloud_print/privet_notifications.cc
index 39b3868..8087b4f7e 100644
--- a/chrome/browser/printing/cloud_print/privet_notifications.cc
+++ b/chrome/browser/printing/cloud_print/privet_notifications.cc
@@ -295,7 +295,8 @@
NotificationDisplayService::GetForProfile(
Profile::FromBrowserContext(profile_))
- ->Display(NotificationHandler::Type::TRANSIENT, notification);
+ ->Display(NotificationHandler::Type::TRANSIENT, notification,
+ /*metadata=*/nullptr);
}
void PrivetNotificationService::PrivetRemoveNotification() {
diff --git a/chrome/browser/send_tab_to_self/desktop_notification_handler.cc b/chrome/browser/send_tab_to_self/desktop_notification_handler.cc
index f9142ff..351c33f 100644
--- a/chrome/browser/send_tab_to_self/desktop_notification_handler.cc
+++ b/chrome/browser/send_tab_to_self/desktop_notification_handler.cc
@@ -47,7 +47,8 @@
base::UTF8ToUTF16(url.host()), url, message_center::NotifierId(url),
optional_fields, /*delegate=*/nullptr);
NotificationDisplayServiceFactory::GetForProfile(profile_)->Display(
- NotificationHandler::Type::SEND_TAB_TO_SELF, notification);
+ NotificationHandler::Type::SEND_TAB_TO_SELF, notification,
+ /*metadata=*/nullptr);
}
void DesktopNotificationHandler::DismissEntries(
@@ -103,7 +104,8 @@
base::UTF8ToUTF16(url.host()), url, message_center::NotifierId(url),
message_center::RichNotificationData(), /*delegate=*/nullptr);
NotificationDisplayServiceFactory::GetForProfile(profile_)->Display(
- NotificationHandler::Type::SEND_TAB_TO_SELF, notification);
+ NotificationHandler::Type::SEND_TAB_TO_SELF, notification,
+ /*metadata=*/nullptr);
}
void DesktopNotificationHandler::DisplayFailureMessage() {
diff --git a/chrome/browser/signin/signin_error_notifier_ash.cc b/chrome/browser/signin/signin_error_notifier_ash.cc
index 03cf1b95..15fe137a 100644
--- a/chrome/browser/signin/signin_error_notifier_ash.cc
+++ b/chrome/browser/signin/signin_error_notifier_ash.cc
@@ -146,7 +146,8 @@
// Update or add the notification.
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void SigninErrorNotifier::HandleSecondaryAccountError(
@@ -182,7 +183,8 @@
// Update or add the notification.
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void SigninErrorNotifier::HandleSecondaryAccountReauthNotificationClick(
diff --git a/chrome/browser/status_icons/desktop_notification_balloon.cc b/chrome/browser/status_icons/desktop_notification_balloon.cc
index 306bfb3..0460e84b 100644
--- a/chrome/browser/status_icons/desktop_notification_balloon.cc
+++ b/chrome/browser/status_icons/desktop_notification_balloon.cc
@@ -51,5 +51,5 @@
new message_center::NotificationDelegate());
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, notification);
+ NotificationHandler::Type::TRANSIENT, notification, /*metadata=*/nullptr);
}
diff --git a/chrome/browser/sync/sync_error_notifier_ash.cc b/chrome/browser/sync/sync_error_notifier_ash.cc
index 168b9ab..445ecb7 100644
--- a/chrome/browser/sync/sync_error_notifier_ash.cc
+++ b/chrome/browser/sync/sync_error_notifier_ash.cc
@@ -127,6 +127,7 @@
ash::kNotificationWarningIcon,
message_center::SystemNotificationWarningLevel::WARNING);
- display_service->Display(NotificationHandler::Type::TRANSIENT, *notification);
+ display_service->Display(NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
notification_displayed_ = true;
}
diff --git a/chrome/browser/ui/ash/assistant/assistant_setup.cc b/chrome/browser/ui/ash/assistant/assistant_setup.cc
index cee0021..83ec501 100644
--- a/chrome/browser/ui/ash/assistant/assistant_setup.cc
+++ b/chrome/browser/ui/ash/assistant/assistant_setup.cc
@@ -151,7 +151,8 @@
message_center::SystemNotificationWarningLevel::NORMAL);
NotificationDisplayService::GetForProfile(profile)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void AssistantSetup::SyncActivityControlState() {
diff --git a/chrome/browser/ui/ash/chrome_screenshot_grabber.cc b/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
index 1fd6af2..bb15f7d 100644
--- a/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
+++ b/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
@@ -701,7 +701,8 @@
message_center::SystemNotificationWarningLevel::NORMAL);
NotificationDisplayService::GetForProfile(GetProfile())
- ->Display(NotificationHandler::Type::TRANSIENT, *notification);
+ ->Display(NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
Profile* ChromeScreenshotGrabber::GetProfile() {
diff --git a/chrome/browser/ui/ash/network/tether_notification_presenter.cc b/chrome/browser/ui/ash/network/tether_notification_presenter.cc
index 879797c..9d4b492 100644
--- a/chrome/browser/ui/ash/network/tether_notification_presenter.cc
+++ b/chrome/browser/ui/ash/network/tether_notification_presenter.cc
@@ -319,7 +319,8 @@
std::unique_ptr<message_center::Notification> notification) {
showing_notification_id_ = notification->id();
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
void TetherNotificationPresenter::OpenSettingsAndRemoveNotification(
diff --git a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
index de4cf8b0..4c3a684 100644
--- a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
+++ b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
@@ -186,7 +186,8 @@
CloseNotification(notification_profile_);
notification_profile_ = profiles[0];
NotificationDisplayService::GetForProfile(notification_profile_)
- ->Display(NotificationHandler::Type::TRANSIENT, *notification_);
+ ->Display(NotificationHandler::Type::TRANSIENT, *notification_,
+ /*metadata=*/nullptr);
// Always return false, the notification UI can be used to quit all apps which
// will cause Chrome to quit.
diff --git a/chrome/browser/ui/extensions/extension_installed_notification.cc b/chrome/browser/ui/extensions/extension_installed_notification.cc
index 50b2c10..d63de75 100644
--- a/chrome/browser/ui/extensions/extension_installed_notification.cc
+++ b/chrome/browser/ui/extensions/extension_installed_notification.cc
@@ -54,7 +54,8 @@
message_center::SystemNotificationWarningLevel::NORMAL);
NotificationDisplayService::GetForProfile(profile_)->Display(
- NotificationHandler::Type::TRANSIENT, *notification);
+ NotificationHandler::Type::TRANSIENT, *notification,
+ /*metadata=*/nullptr);
}
ExtensionInstalledNotification::~ExtensionInstalledNotification() {}
